From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1893EC43334 for ; Tue, 12 Jul 2022 11:57:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A21B940064; Tue, 12 Jul 2022 07:57:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5784E940063; Tue, 12 Jul 2022 07:57:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 467E7940064; Tue, 12 Jul 2022 07:57:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 38C00940063 for ; Tue, 12 Jul 2022 07:57:42 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0AE2734E79 for ; Tue, 12 Jul 2022 11:57:42 +0000 (UTC) X-FDA: 79678298364.06.30FC346 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf07.hostedemail.com (Postfix) with ESMTP id 945294003B for ; Tue, 12 Jul 2022 11:57:41 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8977BB81815; Tue, 12 Jul 2022 11:57:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C170DC3411C; Tue, 12 Jul 2022 11:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657627058; bh=I2isUddvIfyYxIILfJHOITCIxJP3S9I3oDgIC7Pbt48=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UP4OLaoPDWXgj0dQ5SMvidVyDcHYo0UKYj4XJOmtvCHOPh6dezwodkVVzqkSuOAhO mjIPVQxOA5IeO7i1+9fa9Zeu5RmHUNS5KUgNXFtbnPV/C6cWiMx0Psfe8dLKB9vYpI WR8Ww4F8fyYRVQ+p+hIc0kMhJETRI7O4hef8Uum+8SA9UiuzFV8I9jxqZyqCx+j5zo 0ojzM6fGKuuJbz/CcLv2U0MKM71XellXJdmbtvgp0vV8yMnUv7hEQzT60hN662MMRz JxrDUpqzXzqqQDOhjjWSpmX/J6GokjnlgFKZkHzYgBq/Xd1HO8KzPT3W0eYBxJRo1C a8EB/1Zu3bP8A== Date: Tue, 12 Jul 2022 14:57:34 +0300 From: Jarkko Sakkinen To: Ashish Kalra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, michael.roth@amd.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com Subject: Re: [PATCH Part2 v6 09/49] x86/fault: Add support to handle the RMP fault for user address Message-ID: References: <0ecb0a4781be933fcadeb56a85070818ef3566e7.1655761627.git.ashish.kalra@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ecb0a4781be933fcadeb56a85070818ef3566e7.1655761627.git.ashish.kalra@amd.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657627061; a=rsa-sha256; cv=none; b=3PF8AduxFoveBxpe2kajV5H9ND4a/Nqn2cYyET1vm2zetQImgjpnIeW5gpXU19vII5U/a1 z8TrGfwGVp+J5KHby8pXhGZQoeGUJj2uBfawLn3yoyDp0mVIqI52vqqJ/z2q2t4LLSnjKi GhRJzNU3l4ygMYnGlljOaTe4n8ia+vs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657627061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G/DPoxMSupcEt7KNET8RRm6mKMxFC6qxhFfp2JQFxtI=; b=P0KasXIDEeYUNoWGzxa6uYXFf+eO0EurU/lwIKn4+Xhl0imoAh66LIRXFe8QwDUTWAVES7 LdKg7ZpYcn5HQ6ftR6/5Yv+CpNBltMzpdHYVH5KbPBvvwrNMvntTM3sAKa6YldSB4tnim/ wRX0FO5H6dZi/HtvVTnSHluXnHhnkus= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UP4OLaoP; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of jarkko@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jarkko@kernel.org Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UP4OLaoP; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of jarkko@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jarkko@kernel.org X-Rspamd-Server: rspam03 X-Stat-Signature: ppuyr9sc66utmxrnppcerae7jbqyfsgt X-Rspamd-Queue-Id: 945294003B X-Rspam-User: X-HE-Tag: 1657627061-45692 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 20, 2022 at 11:03:43PM +0000, Ashish Kalra wrote: > +/* > + * Return 1 if the caller need to retry, 0 if it the address need to be split > + * in order to resolve the fault. > + */ > +static int handle_user_rmp_page_fault(struct pt_regs *regs, unsigned long error_code, > + unsigned long address) > +{ > + int rmp_level, level; > + pte_t *pte; > + u64 pfn; > + > + pte = lookup_address_in_mm(current->mm, address, &level); As discussed in [1], the lookup should be done in kvm->mm, along the lines of host_pfn_mapping_level(). [1] https://lore.kernel.org/kvm/YmwIi3bXr%2F1yhYV%2F@google.com/ | BR, Jarkko