From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C36E6C433EF for ; Tue, 12 Jul 2022 12:34:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 512C56B0072; Tue, 12 Jul 2022 08:34:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49C666B0078; Tue, 12 Jul 2022 08:34:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33E726B0074; Tue, 12 Jul 2022 08:34:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1DE30940063 for ; Tue, 12 Jul 2022 08:34:04 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id EE4D060C35 for ; Tue, 12 Jul 2022 12:34:03 +0000 (UTC) X-FDA: 79678389966.12.85234CF Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 5AB35C0078 for ; Tue, 12 Jul 2022 12:34:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B1658B817B0; Tue, 12 Jul 2022 12:34:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F14B1C341C8; Tue, 12 Jul 2022 12:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657629240; bh=9DjX9o6ibssfN2gVfTH2pbVMipRj/UkB3PPyZA75DLc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XCdKNUuRGjW9rRR0xnr8jYvOUe05Iuaci0Az7i0qa/N7392kbXhDQcOTEWElhi5jE 6HK6icZCWNZCpC4q3LQ1iT2ud7LV14A/VOLk7SOoNTEW+FLFU5rl1J/GPOF1scyQKr CQaJO8PtaGbulZdGcLg1SB75oPB6jvgVZk+CydYqVg6jiDP1IgRQf2xDgDMLPnchsV 6oxB9FpN/ZqFq8Ffx6uybtcggIDqvya5PUeFGfE6dG2diC/tD35aFY+N9qoQrMsX8T 41aU/Gl0mawE3ShnsZtjXC4GfXVxG15vJkbXBPCTmqHlS0d5H/ljEasTJbEtpSAGzS 8Ahr0dc6hjxmw== Date: Tue, 12 Jul 2022 15:33:57 +0300 From: Jarkko Sakkinen To: Ashish Kalra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, michael.roth@amd.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com Subject: Re: [PATCH Part2 v6 41/49] KVM: SVM: Add support to handle the RMP nested page fault Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657629243; a=rsa-sha256; cv=none; b=Wvi3jtuhAVYV8krVIQb6FKurPUQhgKusE/VHO0cly1dFIu7zF9xXvjx7SKIyvZTincFUpY HX9IWFJFetf+FWV2Ecp96ZIjS0eDSFGMi+Z6v2Rl8Ir01re3wBFw6pP4yByR28PTdTDVAI 8bt/TtS1CIrH+GbT/Z5u2KQF5o4rvrA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XCdKNUuR; spf=pass (imf28.hostedemail.com: domain of jarkko@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657629243; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yYPu2Gk2QbCiWf63wkTCwpnuzgDFV/MQLmN+U9I2mhs=; b=meuxHiMJRJmoDC+XOarmFKsGB9tiR8SkPPnAc990aLYZqQsFo09mKpIckksD8snEOXS8iI 2jm+gQIo+4xGLyIE0RsSNTiw9/0ytDAAulZxA5heRpEGC1J9SA/YmfyxyubDfWjQvydopO tY5UGcln5Et9wXBf63xhIzzWR+hj1Pw= X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5AB35C0078 X-Rspam-User: X-Stat-Signature: di4ipqgd8cjdi78w77o7kzt63snw6hhf Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XCdKNUuR; spf=pass (imf28.hostedemail.com: domain of jarkko@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1657629243-76889 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 20, 2022 at 11:13:03PM +0000, Ashish Kalra wrote: > From: Brijesh Singh > > When SEV-SNP is enabled in the guest, the hardware places restrictions on > all memory accesses based on the contents of the RMP table. When hardware > encounters RMP check failure caused by the guest memory access it raises > the #NPF. The error code contains additional information on the access > type. See the APM volume 2 for additional information. > > Signed-off-by: Brijesh Singh > --- > arch/x86/kvm/svm/sev.c | 76 ++++++++++++++++++++++++++++++++++++++++++ > arch/x86/kvm/svm/svm.c | 14 +++++--- > 2 files changed, 86 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 4ed90331bca0..7fc0fad87054 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -4009,3 +4009,79 @@ void sev_post_unmap_gfn(struct kvm *kvm, gfn_t gfn, kvm_pfn_t pfn) > > spin_unlock(&sev->psc_lock); > } > + > +void handle_rmp_page_fault(struct kvm_vcpu *vcpu, gpa_t gpa, u64 error_code) > +{ > + int rmp_level, npt_level, rc, assigned; > + struct kvm *kvm = vcpu->kvm; > + gfn_t gfn = gpa_to_gfn(gpa); > + bool need_psc = false; > + enum psc_op psc_op; > + kvm_pfn_t pfn; > + bool private; > + > + write_lock(&kvm->mmu_lock); > + > + if (unlikely(!kvm_mmu_get_tdp_walk(vcpu, gpa, &pfn, &npt_level))) This function does not exist. Should it be kvm_mmu_get_tdp_page? BR, Jarkko