From: Heiko Carstens <hca@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: Steffen Eiden <seiden@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, nrb@linux.ibm.com
Subject: Re: [PATCH 1/3] s390/cpufeature: rework to allow more than only hwcap bits
Date: Tue, 12 Jul 2022 21:27:53 +0200 [thread overview]
Message-ID: <Ys3LOT/fGcGo+4Eh@osiris> (raw)
In-Reply-To: <20220712184619.45edd420@p-imbrenda>
On Tue, Jul 12, 2022 at 06:46:19PM +0200, Claudio Imbrenda wrote:
> > +int cpu_have_feature(unsigned int num)
> > +{
> > + struct s390_cpu_feature *feature;
> > +
> > + feature = &s390_cpu_features[num];
>
> I would put some check to make sure you are going past the end of the
> array.
>
> Maybe something like
>
> if (num >= MAX_CPU_FEATURES) {
> WARN(1, "Invalid feature %d", num);
> return 0;
That makes sense. I would go for a simple
if (WARN_ON_ONCE(num >= MAX_CPU_FEATURES))
return 0;
next prev parent reply other threads:[~2022-07-12 19:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 10:52 [PATCH 0/3] s390/cpufeature: rework to allow different types of cpufeatures Steffen Eiden
2022-07-12 10:52 ` [PATCH 1/3] s390/cpufeature: rework to allow more than only hwcap bits Steffen Eiden
2022-07-12 11:56 ` Steffen Eiden
2022-07-12 16:46 ` Claudio Imbrenda
2022-07-12 19:27 ` Heiko Carstens [this message]
2022-07-12 19:25 ` Heiko Carstens
2022-07-13 8:32 ` Steffen Eiden
2022-07-14 10:52 ` Heiko Carstens
2022-07-15 8:03 ` Hendrik Brueckner
2022-07-12 10:52 ` [PATCH 2/3] s390/cpufeature: allow for facility bits Steffen Eiden
2022-07-12 16:50 ` Claudio Imbrenda
2022-07-12 10:52 ` [PATCH 3/3] s390/uvdevice: autoload module based on CPU facility Steffen Eiden
2022-07-12 16:49 ` Claudio Imbrenda
2022-07-13 8:39 ` Steffen Eiden
2022-07-13 9:16 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys3LOT/fGcGo+4Eh@osiris \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=seiden@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).