Re: [PATCH bpf-next 1/3] mm/vmalloc: introduce vmalloc_exec which allocates RO+X memory

Song Liu
2022-07-14T04:55:37Z

> On Jul 13, 2022, at 9:23 PM, Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Jul 13, 2022 at 03:49:45PM +0000, Song Liu wrote:
>>
>>
>>> On Jul 13, 2022, at 3:08 AM, Christoph Hellwig <hch@infradead.org> wrote:
>>>
>>> NAK. This is not something that should be an exported public API
>>> ever.
>>
>> Hmm.. I will remove EXPORT_SYMBOL_GPL (if we ever do a v2 of this..)
>
> Even without that it really is not a vmalloc API anyway.

This ...

> Executable
> memory needs to be written first, so we should allocate it in that state
> and only mark it executable after that write has completed.

... and this are two separate NAKs.

For the first NAK, I agree that my version is another layer on top of
vmalloc. But what do you think about Peter's idea? AFAICT, that fits
well in vmalloc logic.

For the second NAK, I acknowledge the concern. However, I think we
will need some mechanism to update text without flipping W and X bit in
the page table. Otherwise, set_memory_* w/ alias will fragment the
direct map, and cause significant performance drop over time. If this
really doesn't work because of this concern, we will need to look into
other solutions discussed in LSFMMBPF [1].

Thanks,
Song
[1] https://lwn.net/Articles/894557/