Re: [PATCH bpf-next 1/3] mm/vmalloc: introduce vmalloc_exec which allocates RO+X memory

Christoph Hellwig
2022-07-14T04:24:04Z

On Wed, Jul 13, 2022 at 03:49:45PM +0000, Song Liu wrote:
>
>
> > On Jul 13, 2022, at 3:08 AM, Christoph Hellwig <hch@infradead.org> wrote:
> >
> > NAK. This is not something that should be an exported public API
> > ever.
>
> Hmm.. I will remove EXPORT_SYMBOL_GPL (if we ever do a v2 of this..)

Even without that it really is not a vmalloc API anyway. Executable
memory needs to be written first, so we should allocate it in that state
and only mark it executable after that write has completed.