From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF884C433EF for ; Sun, 3 Jul 2022 21:55:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD3238E0001; Sun, 3 Jul 2022 17:54:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B78776B0073; Sun, 3 Jul 2022 17:54:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A65408E0001; Sun, 3 Jul 2022 17:54:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 94EEB6B0072 for ; Sun, 3 Jul 2022 17:54:59 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 6B120815D0 for ; Sun, 3 Jul 2022 21:54:59 +0000 (UTC) X-FDA: 79647144318.14.2FCA39E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id E2BB6C005B for ; Sun, 3 Jul 2022 21:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+MGiKEfl9xrsgJZ7q400SimQ9kR8E7tJt+7JZCpxN+M=; b=SHfDE5+6mBKPlBCsEOm5QP5yij 8KU96A8vwOX+IDsEWrs9aJENczKn0RR+ucv0UgGLJuzRETPiRnk97j960pKVDWXup/epaiuhYQ7sc lpRtgNCIo0c8+veMEhsKXmjsQbJW2VVFVfK6qURCKgssti0tgSMvYZItSMqiFp7vbMmAM29ep0jby 7Bm5yyy5R82u59478H5/Zfro9dQkULW/V1um6IBHGR+GCvnusUKMLPuJZWqyAwS2/EMsZWIap6lxX X0mdMnIuTGWtBtwX+q5heba1Rwhs658yDib36h3OuX5vfvR7u2AYQi5EvYU3s7QhvfMvhERepib69 5nTPYdgg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o87YH-00GjBn-FN; Sun, 03 Jul 2022 21:54:49 +0000 Date: Sun, 3 Jul 2022 22:54:49 +0100 From: Matthew Wilcox To: "Russell King (Oracle)" Cc: Andrew Morton , Arnd Bergmann , Mike Rapoport , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/14] arm: Rename PMD_ORDER to PMD_BITS Message-ID: References: <20220703141203.147893-1-rppt@kernel.org> <20220703211441.3981873-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656885298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+MGiKEfl9xrsgJZ7q400SimQ9kR8E7tJt+7JZCpxN+M=; b=ZiKjf8qrwsYiqN/nD34A/69mTslinpEHjDvBbdAa58P7DFv1jh2fVKzU6dtBdQCtIptamT jXwdNmRCqPjjrm/+vvF/SLU3Xa2p3OrJZDFQLlzSfWGG5nD0z2qXBsI615YzljpNU/4pss dPBplbuVXNNEbZjswjKbOBneEiHXjQk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656885298; a=rsa-sha256; cv=none; b=xU3MZ6yjaZ9Cy9+dYzDHbwNkwm/hNYERN5PTMy0Ux9Jza0nvy/MKsuPYOYQLt3aZ+Rb1Tq FkpdZ9De9slmca4aApQt1actUjnt9qtFdNWqJM7HkzH4IOkByd37OpEOSUo1/k0jAR7Zek HJZyFEa8ckoE3Z4jN0ZI7RJhSYwbypM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SHfDE5+6; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: 5tfx631xn81d341wzsqch64cbr3q897r X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SHfDE5+6; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E2BB6C005B X-HE-Tag: 1656885297-936829 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 03, 2022 at 10:16:45PM +0100, Russell King (Oracle) wrote: > On Sun, Jul 03, 2022 at 10:14:41PM +0100, Matthew Wilcox (Oracle) wrote: > > This is the number of bits used by a PMD entry, not the order of a PMD. > > No, it's not the number of bits. A PMD entry doesn't fit in 2 or 3 bits. > This is even more confusing. Well, what is it then? The order of something is PAGE_SIZE << n, and that doesn't seem to be what this is. Happy to call it whatever you want to call it.