From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E55C43334 for ; Mon, 4 Jul 2022 22:48:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 850996B0071; Mon, 4 Jul 2022 18:48:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 801CA6B0073; Mon, 4 Jul 2022 18:48:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EF186B0074; Mon, 4 Jul 2022 18:48:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5D7F86B0071 for ; Mon, 4 Jul 2022 18:48:26 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2EAA9603E7 for ; Mon, 4 Jul 2022 22:48:26 +0000 (UTC) X-FDA: 79650907812.11.4565480 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 6ACBCA0015 for ; Mon, 4 Jul 2022 22:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tVbYeuMqVTWB9+a2w9YagXruu2c1wBOJ3lmVRIIQvTA=; b=JM20klr5daeztXsLkAIPypjiXc hPsm6SIhSFP5fQ86Mso2LQlakk4+El9lKuq9za+WkTrMp3B10VnWxUfx83ViFaLxnZm29m7CBziOQ Uce+U9p/xia1JMhj545L/PI1GqLBr/q3SzUKHYfM6gkY0ZLIfAKo9y/7reOoRPbjiQnpU0YUkug7T j5Djr02CkG5bv9LMDFJrkBSo+Yypb1GtSuiL6DuyPR9yKS1uM9fJbOu+0+96GtmDz7gTVVTWMn5wg 6qT3Cv4BhyZY0vwx6R6fWsKifRfZH3f7O1uh+Tcmqj4KSGTcEdVpXJaXAMYZTub3T8O46YRA17rCR 2OMxWtqw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8Ura-00031u-0w; Mon, 04 Jul 2022 22:48:18 +0000 Date: Mon, 4 Jul 2022 23:48:17 +0100 From: Matthew Wilcox To: Peter Xu Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Morton , David Hildenbrand , "Dr . David Alan Gilbert" , Andrea Arcangeli , Linux MM Mailing List , Sean Christopherson Subject: Re: [PATCH 1/4] mm/gup: Add FOLL_INTERRUPTIBLE Message-ID: References: <20220622213656.81546-1-peterx@redhat.com> <20220622213656.81546-2-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220622213656.81546-2-peterx@redhat.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656974905; a=rsa-sha256; cv=none; b=lCXEq1ayBoTZBORH/56p9ls2cBYSe1VWaFV1NmGNjOBiOk18rO9PUsA6S67O2e9lEhtaLy os+8ApL/VhnjhAJ9W+0KON7peRi8zhNDYE6o5kNdbaoajmqJfwSHFafbEyPx1kqj2eiSdz UOqvUKVoRoGcVEQtsYNwhqC8HwYzoGc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JM20klr5; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656974905; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tVbYeuMqVTWB9+a2w9YagXruu2c1wBOJ3lmVRIIQvTA=; b=xZmJryHTtXs0oM4mPs6BfzTBeuTxkoDi2qMtEux4naRl9rNHOd+n6p07KOCZWf8mJCaB6G ZZsp3YjW9aPdsF4+vRU1E+k4B/mENof/Wbc+UdXCHbsTUaRj+aQsFMWgFYpseTt73jPwsT XR8IwUm8f1aR7UtF6dm+qMiiqv2ATDc= Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JM20klr5; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Stat-Signature: bkaubnrno1akx5opoxbsaforme7cpdrk X-Rspamd-Queue-Id: 6ACBCA0015 X-Rspamd-Server: rspam04 X-HE-Tag: 1656974905-121317 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 22, 2022 at 05:36:53PM -0400, Peter Xu wrote: > +/* > + * GUP always responds to fatal signals. When FOLL_INTERRUPTIBLE is > + * specified, it'll also respond to generic signals. The caller of GUP > + * that has FOLL_INTERRUPTIBLE should take care of the GUP interruption. > + */ > +static bool gup_signal_pending(unsigned int flags) > +{ > + if (fatal_signal_pending(current)) > + return true; > + > + if (!(flags & FOLL_INTERRUPTIBLE)) > + return false; > + > + return signal_pending(current); > +} This should resemble signal_pending_state() more closely, if indeed not be a wrapper of signal_pending_state().