From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAFE9C43334 for ; Thu, 7 Jul 2022 20:59:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63F7A6B0072; Thu, 7 Jul 2022 16:59:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EEC06B0073; Thu, 7 Jul 2022 16:59:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B63B6B0074; Thu, 7 Jul 2022 16:59:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3D26E6B0072 for ; Thu, 7 Jul 2022 16:59:47 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0D8E9303CD for ; Thu, 7 Jul 2022 20:59:47 +0000 (UTC) X-FDA: 79661520414.08.A001B96 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf18.hostedemail.com (Postfix) with ESMTP id A976C1C0009 for ; Thu, 7 Jul 2022 20:59:46 +0000 (UTC) Received: by mail-pg1-f170.google.com with SMTP id s27so20636097pga.13 for ; Thu, 07 Jul 2022 13:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=A5MhBcXf8LVQ9gbV4fE8wcZW4gjzBdDH9411SgBm9nA=; b=JZQC6m6xR5sT0Jada7pN2ctPDZoVBgPNmsmVFV9xaOD0K1VcjdaDGI+Dbb9m6z+j0M HQZao2MwdnxdUCyFyWlgXqE0vhn5k0x3cFJEqeUSkVEsaLaami6rP5dYbVbdIFtecFK0 bszrtlQ/BBq6HtrtoG8nU1E+PvhE0lLr6U7Movo+h1ZN1VwhTvdz1ZHCpBxehT1XrGLp ldw665ro4GytFHnalr0o9hUTUOKVZe4kPdeCD4oNOEE/cifAyBR7BH7HyjVvjpbMGLv/ wuBFBMUf1JFMK20mDchKuifuX9NzhPRD+zMlfMD3Uo00M9pihW0RWuo1fPBLXJlg8Qnc EHBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=A5MhBcXf8LVQ9gbV4fE8wcZW4gjzBdDH9411SgBm9nA=; b=mhAsFykGhEhujQRyfjuSw3C4BMWcFRzF/Y4sYlweeORIDZXLy72SrVUbQM/wpLrwE6 DcMzmQPvWNIIUGh5XW+u9HvSUuhKoDpQg0GkXyEUppB0TooxUGk+/EUwx8p2a07mK+/b fEYvzt7g3cQxhWGCEnpUYbu0+PUh+qBzOIgOeQA0y85rkLUOTvaUpg0z2Zw1Kxa7zd6a wF4hNHS3PcWcbOH8LeIxpBU3L5zeQAOZIJxh1uzID+nmaVVT8nj8rwIz8lMN4gr7IzHL lWH2i1A0f5i9Pz72OmjoiqEXZbd7rqgsi06c9+ilp/bS62319tYyRXfnxPl4Sr9Qi/Zv pq1g== X-Gm-Message-State: AJIora+KcNSrUfwSViiWCxfTHo0GnmLjw6yPLebcg9+vgeFtF0XjZPgx RavFJlED60rP5PP+BHjovhXxgw== X-Google-Smtp-Source: AGRyM1sARh3FSc0YJzBOfjfu9tVk8n9I1lJXGq5XAEdqRD+A3gMvMxGVzqr9kHPYDPOxaQ6woa23oA== X-Received: by 2002:a63:4756:0:b0:412:88b5:2a23 with SMTP id w22-20020a634756000000b0041288b52a23mr11516pgk.442.1657227585430; Thu, 07 Jul 2022 13:59:45 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id rt5-20020a17090b508500b001ef8ac4c681sm22733pjb.0.2022.07.07.13.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 13:59:44 -0700 (PDT) Date: Thu, 7 Jul 2022 20:59:41 +0000 From: Sean Christopherson To: Yosry Ahmed Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , Huang@google.com, Shaoqin , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses. Message-ID: References: <20220628220938.3657876-1-yosryahmed@google.com> <20220628220938.3657876-2-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220628220938.3657876-2-yosryahmed@google.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657227586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A5MhBcXf8LVQ9gbV4fE8wcZW4gjzBdDH9411SgBm9nA=; b=cRpLH62vWPmJATxU+n67CSXkVQSM8JBxVDqkohfgxYwD9sE1slEAE9vXW3/1mng9KmtWt5 kFqTxh8Tu31LaYQZdcwqaanhG+CIBqY+Bu46tXDyNqMezgFbUW2cgX/bn0tH3LqbvBvEpW inK8Wm9tVyxbBvi//t/MTnsQMuHLd04= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657227586; a=rsa-sha256; cv=none; b=SKAi1L/GRC4zNX3cKhk83SkV/Sjl/VIuJh57pw46HhuwtElSW5W3MTJNu2ynYWn5RrZ1ea RMpENWjs1b3e6+HZNrDkmzQnDakoFR37a38DWRgdVtkMI819cshOSKoWHgVYTg3bD9XLAa jWjwVz2lvV+7xl84uxGTpP5sLKLN38E= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JZQC6m6x; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of seanjc@google.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=seanjc@google.com Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JZQC6m6x; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf18.hostedemail.com: domain of seanjc@google.com designates 209.85.215.170 as permitted sender) smtp.mailfrom=seanjc@google.com X-Stat-Signature: jkd5uxcodje6cz4do9ypqqcrxoo7mknc X-Rspamd-Queue-Id: A976C1C0009 X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1657227586-283350 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 28, 2022, Yosry Ahmed wrote: > We keep track of several kernel memory stats (total kernel memory, page > tables, stack, vmalloc, etc) on multiple levels (global, per-node, > per-memcg, etc). These stats give insights to users to how much memory > is used by the kernel and for what purposes. > > Currently, memory used by kvm mmu is not accounted in any of those Nit, capitalize KVM (mainly to be consistent). > @@ -1085,6 +1086,9 @@ KernelStack > Memory consumed by the kernel stacks of all tasks > PageTables > Memory consumed by userspace page tables > +SecPageTables > + Memory consumed by secondary page tables, this currently > + currently includes KVM mmu allocations on x86 and arm64. Nit, this line has a tab instead of eight spaces. Not sure if it actually matters, there are plenty of tabs elsewhere in the file, but all the entries in this block use only spaces. > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index aab70355d64f3..13190d298c986 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -216,6 +216,7 @@ enum node_stat_item { > NR_KERNEL_SCS_KB, /* measured in KiB */ > #endif > NR_PAGETABLE, /* used for pagetables */ > + NR_SECONDARY_PAGETABLE, /* secondary pagetables, e.g. kvm shadow pagetables */ Nit, s/kvm/KVM, and drop the "shadow", which might be misinterpreted as saying KVM pagetables are only accounted when KVM is using shadow paging. KVM's usage of "shadow" is messy, so I totally understand why you included it, but in this case it's unnecessary and potentially confusing. And finally, something that's not a nit. Should this be wrapped with CONFIG_KVM (using IS_ENABLED() because KVM can be built as a module)? That could be removed if another non-KVM secondary MMU user comes along, but until then, #ifdeffery for stats the depend on a single feature seems to be the status quo for this code. > #ifdef CONFIG_SWAP > NR_SWAPCACHE, > #endif