From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75383C433EF for ; Sat, 9 Jul 2022 08:14:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A45986B0072; Sat, 9 Jul 2022 04:14:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CECF6B0073; Sat, 9 Jul 2022 04:14:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86EE16B0074; Sat, 9 Jul 2022 04:14:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 734906B0072 for ; Sat, 9 Jul 2022 04:14:31 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3F3D73C0 for ; Sat, 9 Jul 2022 08:14:31 +0000 (UTC) X-FDA: 79666849542.10.EF39006 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf17.hostedemail.com (Postfix) with ESMTP id AB14440004 for ; Sat, 9 Jul 2022 08:14:30 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id eq6so953313edb.6 for ; Sat, 09 Jul 2022 01:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wowsignal-io.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KCVIYTQNe+wDD0/zWfqLiKVkZZ+O9JV55zL9SUtvHbw=; b=1WVWsQtJRZny+10NGMIZOJ97sDzcrdiUVUABiLfDTovhm1VzNL3UuGMfEW+vYD591K oquW/LZHBcYyowtwtpJAZ+p+/khFwiKoL7BaQR9JuF6jpkpJMs7js9q981i84W8EAXHk g2iVQtEWROkIUACprvBjoEMci0kCEHJdmWI7EoRicqX4zHSJc21/n83zePIvgzoz/nOv nKaLELRHtmOlnPPIvjl1o0yktLqtxKByLTmQVFoSdCDVyeMy7gdOTTWuCU48yRMRNOJE G3IYJb4EYl5k2yGZ1LOkB0j5bTuGpjdpXcEHtw+owiP7uCW3WUTdi1sfqdfJ3YTi8toD zTUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KCVIYTQNe+wDD0/zWfqLiKVkZZ+O9JV55zL9SUtvHbw=; b=7X6rqreq6RXoakY00LpEhqRR6sBvCCDaSURCNRy1je7z0nb6xi5qarOAiAqqeeIMIm 0KJ6Tg3WPIYWcG8VvTxdb9KzIfBSHcnotwgCZhErAm3zyR9MUZo8W6+2AAO7zggnpkaG FFFaoz3J69K5kICSP8f0SxUXwM+RmtxZv4N/MOMwuGJrC2Y6fLOLcB1qLQXh9FSoqd4e uLX1hKh7dHVyjZygTdGE+FlTRPjpD9p7FFdN7xRaMqZjq0xrbC4TYUdudpxLLJ82NKxQ te1icd5CVh7YlH6yV0cgkS7zJXnGa8XNIRY6bIe20mkzoaxAaA+KsW4+9NqXlWI48Do2 5azg== X-Gm-Message-State: AJIora+rwC+svCe0yt1dj+123aABnqpL0FjTVVrgtJsEPNUvA9yvJTtb lr01TtzHDgV6MQguGIUiC/KQIA== X-Google-Smtp-Source: AGRyM1u9aWkpwHIVJHEfyfEWFlkemMndlMMbdSJpCKDsSnfZcZOrCMTS8fnqWW173CEomEq41LB0mw== X-Received: by 2002:a50:fd93:0:b0:43a:71e2:781e with SMTP id o19-20020a50fd93000000b0043a71e2781emr9965616edt.396.1657354469065; Sat, 09 Jul 2022 01:14:29 -0700 (PDT) Received: from localhost (212-51-140-210.fiber7.init7.net. [212.51.140.210]) by smtp.gmail.com with ESMTPSA id r20-20020a170906c29400b0072ae174cdd4sm354658ejz.111.2022.07.09.01.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 01:14:28 -0700 (PDT) Date: Sat, 9 Jul 2022 10:14:27 +0200 From: Adam Sindelar To: Andrew Morton Cc: linux-mm@kvack.org, Adam Sindelar , David Vernet , kernel-team@fb.com Subject: Re: [PATCH] selftests/vm: fix va_128TBswitch.sh permissions Message-ID: References: <20220708090646.34927-1-adam@wowsignal.io> <20220708130801.411ace64e0244a75f483a9f0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220708130801.411ace64e0244a75f483a9f0@linux-foundation.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657354470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KCVIYTQNe+wDD0/zWfqLiKVkZZ+O9JV55zL9SUtvHbw=; b=4bprxWSo+rHGpHbBWibUahh/9yfL/pDhWLeXpjyjo/42AfzQlGAWDDtjCuvjKhNloI0s25 0p0Ql+ymo03mfskB08aOcxuty5upAc91/PhIqV60yu6heDDRnb5/aRL0Sob3sVDyGcuMNb 5brPo/TSpu9X1UqfF9Iwv42GFjYu++E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657354470; a=rsa-sha256; cv=none; b=ZQ2I8/36eFdU6GylLzHQtP6+aqy1GGj8ynYNWu54R+pnlT5ndevQ7qLaGgN6lJPtDk6s2n NNw3Obev3+9S5eY/PJ1anAgfHRFoEOVAhMENwKA4hG0A3N4YQS+OcfAYKVZUfVOq3oBHNN l1jo+jKnNWLQ4J/8QWnBN7189J7+bEU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=wowsignal-io.20210112.gappssmtp.com header.s=20210112 header.b=1WVWsQtJ; dmarc=none; spf=none (imf17.hostedemail.com: domain of adam@wowsignal.io has no SPF policy when checking 209.85.208.44) smtp.mailfrom=adam@wowsignal.io Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=wowsignal-io.20210112.gappssmtp.com header.s=20210112 header.b=1WVWsQtJ; dmarc=none; spf=none (imf17.hostedemail.com: domain of adam@wowsignal.io has no SPF policy when checking 209.85.208.44) smtp.mailfrom=adam@wowsignal.io X-Stat-Signature: dc7ywakf7kc9bfnpx7duxk4pn49mi7dm X-Rspamd-Queue-Id: AB14440004 X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1657354470-750063 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 08, 2022 at 01:08:01PM -0700, Andrew Morton wrote: > On Fri, 8 Jul 2022 11:06:46 +0200 Adam Sindelar wrote: > > > Restores the +x bit to va_128TBswitch.sh, which got dropped from the > > previous patch, somehow. > > > > Fixes: 1afd01d43efc3 ("selftests/vm: Only run 128TBswitch with 5-level > > paging") > > > > Signed-off-by: Adam Sindelar > > --- > > tools/testing/selftests/vm/va_128TBswitch.sh | 0 > > 1 file changed, 0 insertions(+), 0 deletions(-) > > mode change 100644 => 100755 tools/testing/selftests/vm/va_128TBswitch.sh > > > > diff --git a/tools/testing/selftests/vm/va_128TBswitch.sh b/tools/testing/selftests/vm/va_128TBswitch.sh > > old mode 100644 > > new mode 100755 > > Half of tools/testing/selftests/vm/*.sh don't have the x bit set. > They're invoked via `/bin/sh foo.sh', which is more robust. > > Can we hunt down and fix the invoking code? Might be as simple as > > --- a/tools/testing/selftests/vm/run_vmtests.sh~a > +++ a/tools/testing/selftests/vm/run_vmtests.sh > @@ -144,7 +144,7 @@ run_test() { > local sep=$(echo -n "$title" | tr "[:graph:][:space:]" -) > printf "%s\n%s\n%s\n" "$sep" "$title" "$sep" > > - "$@" > + /bin/sh "$@" > local ret=$? > if [ $ret -eq 0 ]; then > echo "[PASS]" > _ > I think that would impose the choice of shell on the test scripts. About half of them start with '#!/bin/sh' and the other half with '#!/bin/bash'. Maybe that's something we'd want to do anyway, but it seems like it could have subtle and unintended side effects if the goal is to fix a failing test. (It would also invoke the ELF binaries through /bin/sh, but that probably doesn't matter, since sh will I think exec right away.)