Re: [PATCH -V2 4/7] migrate_pages(): fix failure counting for THP subpages retrying

Oscar Salvador
2022-07-11T12:13:08Z

On Mon, Jul 11, 2022 at 04:49:45PM +0800, Huang Ying wrote:
> If THP is failed to be migrated for -ENOSYS and -ENOMEM, the THP will
> be split into thp_split_pages, and after other pages are migrated,
> pages in thp_split_pages will be migrated with no_subpage_counting ==
> true, because its failure have been counted already. If some pages in
> thp_split_pages are retried during migration, we should not count
> their failure if no_subpage_counting == true too. This is done this
> patch to fix the failure counting for THP subpages retrying.
>
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> Fixes: 5984fabb6e82 ("mm: move_pages: report the number of non-attempted pages")
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: Yang Shi <shy828301@gmail.com>

Reviewed-by: Oscar Salvador <osalvador@suse.de>

--
Oscar Salvador
SUSE Labs