From: Mike Kravetz <mike.kravetz@oracle.com>
To: Peter Xu <peterx@redhat.com>
Cc: Axel Rasmussen <axelrasmussen@google.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Muchun Song <songmuchun@bytedance.com>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/hugetlb: avoid corrupting page->mapping in hugetlb_mcopy_atomic_pte
Date: Fri, 15 Jul 2022 10:29:33 -0700 [thread overview]
Message-ID: <YtGj/YYixDT0npgL@monkey> (raw)
In-Reply-To: <YtGe2qIO038e627p@xz-m1.local>
On 07/15/22 13:07, Peter Xu wrote:
> On Fri, Jul 15, 2022 at 09:45:37AM -0700, Axel Rasmussen wrote:
> > I don't really have a strong preference between the two. The second option
> > is what I originally proposed in the first version of the minor fault
> > series, so going back to that isn't a problem at least from my perspective.
> > If in the future we find a real use case for this, we could always easily
> > re-enable it and add selftests for it at that point.
>
> I'd go for fixing the test case if possible. Mike, would it be fine if we
> go back to /dev/hugepages path based approach in the test case?
>
No problem going back to using a file for private mapping testing. Removing
that was more of a simplification, because of new MADV_DONTNEED support.
Just want to make sure we also keep remap and remove event testing.
--
Mike Kravetz
next prev parent reply other threads:[~2022-07-15 17:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 13:05 [PATCH] mm/hugetlb: avoid corrupting page->mapping in hugetlb_mcopy_atomic_pte Miaohe Lin
2022-07-12 17:39 ` Mike Kravetz
2022-07-13 2:10 ` Miaohe Lin
2022-07-13 14:24 ` Peter Xu
2022-07-13 16:10 ` Peter Xu
2022-07-13 22:46 ` Axel Rasmussen
2022-07-13 23:36 ` Mike Kravetz
2022-07-14 0:20 ` Axel Rasmussen
2022-07-14 10:09 ` Miaohe Lin
2022-07-14 15:45 ` Peter Xu
2022-07-15 2:50 ` Miaohe Lin
2022-07-13 17:23 ` Andrew Morton
2022-07-14 9:59 ` Miaohe Lin
2022-07-14 15:52 ` Peter Xu
2022-07-15 3:56 ` Miaohe Lin
2022-07-15 12:35 ` Peter Xu
2022-07-15 16:45 ` Axel Rasmussen
2022-07-15 17:07 ` Peter Xu
2022-07-15 17:28 ` Axel Rasmussen
2022-07-15 17:39 ` Peter Xu
2022-07-15 17:51 ` Axel Rasmussen
2022-07-16 1:32 ` Miaohe Lin
2022-07-15 17:29 ` Mike Kravetz [this message]
2022-07-15 17:38 ` Peter Xu
2022-07-16 23:06 ` Andrew Morton
2022-07-18 2:25 ` Miaohe Lin
2022-07-18 18:07 ` Axel Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtGj/YYixDT0npgL@monkey \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).