From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03FC3C25B06 for ; Mon, 15 Aug 2022 02:52:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BA0F6B0074; Sun, 14 Aug 2022 22:52:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 969576B0075; Sun, 14 Aug 2022 22:52:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 831108D0002; Sun, 14 Aug 2022 22:52:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 751826B0074 for ; Sun, 14 Aug 2022 22:52:54 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4C0CEA02AF for ; Mon, 15 Aug 2022 02:52:54 +0000 (UTC) X-FDA: 79800304668.31.E39A14E Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf07.hostedemail.com (Postfix) with ESMTP id DA5AB40051 for ; Mon, 15 Aug 2022 02:52:53 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id q9-20020a17090a2dc900b001f58bcaca95so13302343pjm.3 for ; Sun, 14 Aug 2022 19:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=97tyCh/hztKpfXO6u7xzBaFIppY93MdOrm2n8zHUB64=; b=H8jdlmhwkxVG0lk4LDQB/bJj0Mm+afebg1AZ+jF9cTIqiY25bexB+7F6sn1382nDE8 XyIT1Ntt+lpGJ7nC0kJnjcAp3mg4cajjFMTLfESOT4PWfl9tFNPgMF/A+h3/Nf36TuyW CDm+Mg67fRHXAm9tOxDBvyMhaRe90aN5VMq6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=97tyCh/hztKpfXO6u7xzBaFIppY93MdOrm2n8zHUB64=; b=4ZEs74MmKdwb1BzOnBKX2PhbnGXdLf/7FLaKly9EDkY3Kh/gRCSBBwBmGlTTvxVI4K Md29CYQSwC+DhaNIHbBlIrE387cLrYkwReZx0bC0HYrXS0uQvqMVdxCsZhF7BW0wi1r3 IaWGC7WGstr+a90m6oDcxDg5P62PfxUL0K1aykK68IpGJCFIvPAOxsxA/rTZC5Xx+pWV WQmA4CfA5huGDIPu8ZnGEwterL9fQGYRd4v4JtKSll0EG+IlSci5Lx0+PL7sQD7hbBKC kwX/wC9mazxJlRbwV7xL+qv8KexTeDgRyhWrT5RjD63tn52E12uQ9KBp4+EWz+ddEG4p oTFQ== X-Gm-Message-State: ACgBeo3z0gjs2P5D70Em2mhPzOAp3BtGldSysXoVOS5Pt9hbPFXo08vI AVyAMqoDe33amMAsFdceDzUP+Q== X-Google-Smtp-Source: AA6agR6ehp0puQvxCbDXA3dNRkeihvvt7eY4tDwGsjqcpgYgSX6GwZTIv+f05mPav55ebhupdmaUvQ== X-Received: by 2002:a17:90a:640c:b0:1f7:6ecf:33b6 with SMTP id g12-20020a17090a640c00b001f76ecf33b6mr25658771pjj.3.1660531972720; Sun, 14 Aug 2022 19:52:52 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:110b:946c:84b2:7c95]) by smtp.gmail.com with ESMTPSA id s1-20020a170902a50100b0016f0c2ea14csm5989566plq.275.2022.08.14.19.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Aug 2022 19:52:52 -0700 (PDT) Date: Mon, 15 Aug 2022 11:52:47 +0900 From: Sergey Senozhatsky To: Alexey Romanov Cc: minchan@kernel.org, senozhatsky@chromium.org, ngupta@vflare.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@sberdevices.ru Subject: Re: [PATCH v1 1/2] zsmalloc: zs_object_copy: add clarifying comment Message-ID: References: <20220811153755.16102-1-avromanov@sberdevices.ru> <20220811153755.16102-2-avromanov@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220811153755.16102-2-avromanov@sberdevices.ru> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660531974; a=rsa-sha256; cv=none; b=4lEv5O3C5OM29HvTvkxx/IE0v1cUCmt1vymkUhlu5xUlNq4vl0+QYufIFUD0jwODO0mR+T 9LXKTdRkWujx5Z5k/J37ncKcRZJH5TnZlS1vRByjjZASZCV0vkCV8wU7stiPt/hKIttj31 3bJ+0X5K7SgjS9D5gjRc/daMYWotOxM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=H8jdlmhw; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.42 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660531974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=97tyCh/hztKpfXO6u7xzBaFIppY93MdOrm2n8zHUB64=; b=nlxZbShMDnCPrcE2VDoZNG+PPnxIM1bcJ53FIFfWsrGfrbJHjadL0GV2wj58CDpmKbJwsw ++MkR/TqtVFuzHJ7Es6hpCszvcr9dQZzjhaSbmIKrC4iZokZ1XXv0r1zbf2kRM1Wclwr4n vi7R7NcL6OZnuWDocpuFfAatvg5Wz+E= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DA5AB40051 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=H8jdlmhw; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.42 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org X-Rspam-User: X-Stat-Signature: 5c9o7ppwynzm5czgi9a5rcffibpwcrpj X-HE-Tag: 1660531973-669901 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/08/11 18:37), Alexey Romanov wrote: > @@ -1564,6 +1564,12 @@ static void zs_object_copy(struct size_class *class, unsigned long dst, > d_off += size; > d_size -= size; > > + /* Calling kunmap_atomic(d_addr) is necessary. kunmap_atomic() calls > + * must occurs in reverse order of calls to kmap_atomic(). > + * So, to call kunmap_atomic(s_addr) we should first call kunmap_atomic(d_addr). > + * For more details see: > + * https://lore.kernel.org/linux-mm/5512421D.4000603@samsung.com/ > + */ I'd drop the link part, Emails are not documentation, kmap_atomic is documented in Documentation/mm/highmem