From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFA6ECAAD1 for ; Tue, 30 Aug 2022 03:26:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB3C86B0073; Mon, 29 Aug 2022 23:26:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3C50940008; Mon, 29 Aug 2022 23:26:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB6E1940007; Mon, 29 Aug 2022 23:26:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B993C6B0073 for ; Mon, 29 Aug 2022 23:26:27 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 901BD120D7F for ; Tue, 30 Aug 2022 03:26:27 +0000 (UTC) X-FDA: 79854821214.10.05B3649 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 3F6E01A0008 for ; Tue, 30 Aug 2022 03:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Sj2YAf+jcJpwZgorIhbu6IO4GDMZ2Kf9QmWmBPLXWvU=; b=kSS0ivJZA881DO1pPuT5Jep76P EKfzIVdydNx9TKycdzueqIPeCY0HoFzlgRsNay+JdDbP6aJR9v6uZRcrHYsL/tGbgzlOBbIWQp0mr p3vq0+rO67wFe3vR5/P8o75ACPROvcJh6G/vVmldTrPI8muBkZK3tyrDE2w232PN4adJC9oDtpE+6 rJ2hh9pTqRjpTxTH9zYRfKO9L0prazTDkP9iZXlscM5s9RfjJu4WMzzrocBq5GUDQTcZVOfbTHPaB MvOKYqDkqbDfQ5pKDo+NxdR7VoZqFWGN9ebgS0H67O7L656skRPc650HDxz77sSloGFJkgAT/wr7M CEJP/64g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSrtI-003dkn-T1; Tue, 30 Aug 2022 03:26:16 +0000 Date: Tue, 30 Aug 2022 04:26:16 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, vbabka@suse.cz, william.kucharski@oracle.com, dhowells@redhat.com, peterx@redhat.com, arnd@arndb.de, ccross@google.com, hughd@google.com, ebiederm@xmission.com Subject: Re: [PATCH 5/7] mm/hugetlb: convert hugetlb_delete_from_page_cache() to use folios Message-ID: References: <20220829230014.384722-1-sidhartha.kumar@oracle.com> <20220829230014.384722-6-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829230014.384722-6-sidhartha.kumar@oracle.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661829987; a=rsa-sha256; cv=none; b=exNekaNXk2f+LtWWiIpsjr+Bs+S+6h9D8jNAD5PqLxVW3mCZPEIIa9hnWqxyObrcDT6aVp I0sCKMoOBfMpTCJMqs2sCzr9/tuR9aqPy/1Z8ubOVOKf9n+raqx/FqtnscP5Wt+JYydEo6 5Agrcnu7l1dmjP+TZNLTumdyk23UHAA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kSS0ivJZ; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661829987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sj2YAf+jcJpwZgorIhbu6IO4GDMZ2Kf9QmWmBPLXWvU=; b=dY21XnLMFef99nBOx55bX6ZjMd7FmijA+9dMQvgOXaH04yFg4u/IuoC2yzptFOHLeSNKjX pVmakVw9yabMDZIFTWCf1fkt1Rt0SmXFlEMqLkQesYtGF/2GC7X+gIbgCzDdgICVN5+O5v DmhSgh8fR5uog6klzLiiNExX+srubpA= Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kSS0ivJZ; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: cbceznne1p5bg9wzkc3c6b6emsjjgenk X-Rspamd-Queue-Id: 3F6E01A0008 X-HE-Tag: 1661829986-756843 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 29, 2022 at 04:00:12PM -0700, Sidhartha Kumar wrote: > static void hugetlb_delete_from_page_cache(struct page *page) > { > - ClearPageDirty(page); > - ClearPageUptodate(page); > - delete_from_page_cache(page); > + folio_clear_dirty(folio); > + folio_clear_uptodate(folio); > + filemap_remove_folio(folio); > } Did you send the right version of this patch? It doesn't look like it'll compile.