From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAEBCECAAD1 for ; Tue, 30 Aug 2022 03:33:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E1426B0073; Mon, 29 Aug 2022 23:33:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39074940008; Mon, 29 Aug 2022 23:33:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27FBA940007; Mon, 29 Aug 2022 23:33:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1A1506B0073 for ; Mon, 29 Aug 2022 23:33:19 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EB1221A0C4F for ; Tue, 30 Aug 2022 03:33:18 +0000 (UTC) X-FDA: 79854838476.03.E1BD5A1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id A856C14000C for ; Tue, 30 Aug 2022 03:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AegjQ+c2RLhkoxY7qPbOU3nl+MXQe5Bj6KmEXlJT790=; b=AbBfcj0E38zqkhdNCr94y667xh i8bjL22ZUdWYBIRs+2cAjGbGLlnUYuQnpfS36XFCrBtm+lsK7cSKZbfrlvAx6nuSexYsF5g/nia8B qT/eFxOH8jz0+Wf0eDd/9AdoXtd2MKg+LqZndeCGuwgJnz9ohDE5Jyr1aP7R3IYWbdhXCW3VLjeyR ik17cti651e/xMvWShj11bu9novevTMO1g6MMHC01xLKC+ZXNImfyTl6XlPlYa4n5nTC+kIS0eWcd mS8nlIF+SKKXVBa7GHkRAanwQhnys5eyuMVRhNH+cIyEdwfojOcQFBNp+kddDQhLjhyn3aDMYKinA WXMBbu7Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSrzz-003dvj-6d; Tue, 30 Aug 2022 03:33:11 +0000 Date: Tue, 30 Aug 2022 04:33:11 +0100 From: Matthew Wilcox To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, vbabka@suse.cz, william.kucharski@oracle.com, dhowells@redhat.com, peterx@redhat.com, arnd@arndb.de, ccross@google.com, hughd@google.com, ebiederm@xmission.com Subject: Re: [PATCH 1/7] mm/hugetlb: add folio support to hugetlb specific flag macros Message-ID: References: <20220829230014.384722-1-sidhartha.kumar@oracle.com> <20220829230014.384722-2-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829230014.384722-2-sidhartha.kumar@oracle.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661830398; a=rsa-sha256; cv=none; b=V4ULXEAUG6Lvz3BQs0+UaqqxFQx3eU8Nwv2SppRrBFtCrlfBeMZNEn6nG4UuJvew4fYoKE oNDdn92YRqrdLw2u2MaSG3KalfJ+WsXY71rPTwLdvBOVuNUusjicN0BAvVWzRgeowNIr43 J3VNBoNHFaVfxkyXWrgvTce5juw78sg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AbBfcj0E; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661830398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AegjQ+c2RLhkoxY7qPbOU3nl+MXQe5Bj6KmEXlJT790=; b=DFZ8qlxicO5t9ORhNJsSNJknOJtdmH50lj5iAa/mggMYmzoQqya/Z9uceOjFOAWZIM71Uz yqnOorbj4LQIx0FyhBP1OhLZ9LX0fEuYYClxhjdsrcQBTg1N6ZPaUhMvNyH5KY1MqVK/Lw zAgeaTgCQ2lzzfIiniiHftZw8CyQa3E= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AbBfcj0E; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: mpypc4a3puntbk8bqomo1s3w8b84akjo X-Rspamd-Queue-Id: A856C14000C X-HE-Tag: 1661830398-241964 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 29, 2022 at 04:00:08PM -0700, Sidhartha Kumar wrote: > #define TESTHPAGEFLAG(uname, flname) \ > +static __always_inline \ > +int folio_test_hugetlb_##flname(struct folio *folio) \ One change I made was to have folio_test_foo() return bool instead of int. It helps the compiler really understand what's going on. Maybe some humans too ;-) > + { void **private = &folio->private; \ > + return test_bit(HPG_##flname, (void *)((unsigned long)private)); \ I've made this tricky for you by making folio->private a void * instead of the unsigned long in page. Would this look better as ... { \ void *private = &folio->private; \ return test_bit(HPG_##flname, private); \ perhaps?