From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95241C32789 for ; Sun, 21 Aug 2022 06:53:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A39AC8D0001; Sun, 21 Aug 2022 02:53:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E8EF6B0074; Sun, 21 Aug 2022 02:53:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D7BC8D0001; Sun, 21 Aug 2022 02:53:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7F00A6B0073 for ; Sun, 21 Aug 2022 02:53:55 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5BC81A0319 for ; Sun, 21 Aug 2022 06:53:55 +0000 (UTC) X-FDA: 79822684830.07.006AE59 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP id 47923140037 for ; Sun, 21 Aug 2022 06:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Y24frkjw92lHic4CzAKbZqlsYEtpR03qXcobos9r9E0=; b=Zc4OOGXgclsb2elQc+GGgtYuch XOrgWVeLrVlOMhXgzHaQNzFfnOEFU6Rje9fdHyXEDL7TNxBFyy3ClASkHKzPwxfkYbug92zSkvFPZ 5rUF1SDbdAznWhM1SiQr9ct3iklufFMW3ohAoEKIiYGXBSW7o1p+4whEGP2gg7EDhnGxCPJcGnwR8 jbjofXeZo6/dkyaXGlYaEtP7XF3qIl8XcsBkzXyU+L+LEQRYjPJpFsvXKVbutRqRzFpZXb1INu3Ld kI3PcZPsFReuKtD6n0eoVpstGs+c/U/Zp3OAJncTx87ssdqOp0z7c274KemdTHTrR97LOJIfzCqSr QJMhbB7Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPeqD-006ylG-3o; Sun, 21 Aug 2022 06:53:49 +0000 Date: Sat, 20 Aug 2022 23:53:49 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/11] mm/ioremap: change the return value of io[re|un]map_allowed and rename Message-ID: References: <20220820003125.353570-1-bhe@redhat.com> <20220820003125.353570-2-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220820003125.353570-2-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Zc4OOGXg; spf=none (imf09.hostedemail.com: domain of BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661064834; a=rsa-sha256; cv=none; b=ME9tq/hoM+LEcll76LHuwPIDFMHbCq+7MzQn+JgGB7Do+A4kem76jZgJI8RXgTU6KXXVmP vu+Mn5Uu0h6f+303W+siQx/Jc4KrVCgLtRYA/4RaCdAK/GSx1fTPpEE2opYA0SfFPBfVY+ kDyU8XA/vAubW5rfiC1oERtI5+0EfFA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661064834; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y24frkjw92lHic4CzAKbZqlsYEtpR03qXcobos9r9E0=; b=8QlX1Loc+447P/j7SKOqXTRsDBfcrOfqQhl4OCyMbxnpwAMpCuioe7J/pbf0zSt0jywntU t+yEdHzzgHfqZiGlWsyeJYLsciYLCN1j+XLtLKuMV9jjioZCJvigaybksGpMq5zblEfYn9 m7/JQ5SkGtkjFbf3+pY0xg7Zmj+NAHw= Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Zc4OOGXg; spf=none (imf09.hostedemail.com: domain of BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: ojrqxierb3pu84msnh7uwm7c714pdfos X-Rspamd-Queue-Id: 47923140037 X-HE-Tag: 1661064834-226869 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 20, 2022 at 08:31:15AM +0800, Baoquan He wrote: > +void __iomem *arch_ioremap(phys_addr_t phys_addr, size_t size, unsigned long prot); Please avoid the overly long lines. I also wonder if we just want a common definition with a __weak default instead of duplicating it in many arch headers. > + ioaddr = arch_ioremap(phys_addr, size, prot); > + if (IS_ERR(ioaddr)) > + return NULL; > + else if (ioaddr) > + return ioaddr; No need for the else here.