From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F55EC00140 for ; Sun, 21 Aug 2022 06:56:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C9FD6B0073; Sun, 21 Aug 2022 02:56:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7520F8D0001; Sun, 21 Aug 2022 02:56:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F2B66B0075; Sun, 21 Aug 2022 02:56:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4C9136B0073 for ; Sun, 21 Aug 2022 02:56:30 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 167421601EB for ; Sun, 21 Aug 2022 06:56:30 +0000 (UTC) X-FDA: 79822691340.06.8339FB4 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id D9211A00F1 for ; Sun, 21 Aug 2022 06:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nQM4oPZzphwSDtvEtGpl2bA0fG0oLY3le8thgzAQhNg=; b=JkBhF3nreFwoDyib/sG7ENabdx k1OH4BrKOFhNgvArnk8jflKPqMmepsbcKLRKbrMOzyefREECHQ+Z9RpxfesTxBwS3scFav+XbbCYa ziJLi8YLh1xEG6QcZ4PLKiBgzVAOxFEF/+nanDmU0sXUaKtUXEl1NnGhjeeGJuhYmTjrkjQzbgn+Z CbTu5OsA+o3IgGYU86+2J+G1apP3lg7jZzOEbk0929IeKT8vS07hIZLVQes2frPFBQ+NOx++uyQNO Q0APSZhun1pSiXyU+dgbDyg51DWXm6UAwduXkwpKVHNhJNkHkErgRCGCyWDsFBqWnO6mRLelWjckL k6zX/QtA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPerG-006zaX-KB; Sun, 21 Aug 2022 06:54:54 +0000 Date: Sat, 20 Aug 2022 23:54:54 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 02/11] mm: ioremap: fixup the physical address and page prot Message-ID: References: <20220820003125.353570-1-bhe@redhat.com> <20220820003125.353570-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220820003125.353570-3-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661064896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nQM4oPZzphwSDtvEtGpl2bA0fG0oLY3le8thgzAQhNg=; b=gE83R5aHeoQAPoGN4PLOZYol4Mydl6RDMTJcGozdSzXjwTqDj60O/7MdnEj//WbOUqIBzY 5s1We24Ge77dpYFDdkXQuQ1256XIz8RzVvbFdNlqkYBHmsHhEqEOfw9KPr1gXbWZLbNSPH R9EB/AGbJf2rR8SaRlp2HJ3IlMuNMvI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=JkBhF3nr; dmarc=none; spf=none (imf25.hostedemail.com: domain of BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661064896; a=rsa-sha256; cv=none; b=Y9Z8FbtOpTHouDgWIr85zVPN2bXEGO6bKJZvTn5aMcDN3xF8gWDNCOWh75s8zkMxOcZ2g3 smFyilNDSsLrVlseVRMVMMjDng8VDRhV7/LHjOC7n/4gXqUvTMFw09BlhJGYE3WbT6kI8D gMTMIke3+ksaSs86yXep7VV3cKilec8= X-Rspamd-Queue-Id: D9211A00F1 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=JkBhF3nr; dmarc=none; spf=none (imf25.hostedemail.com: domain of BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam04 X-Stat-Signature: fxe7d6eo9x1gstmqqpk6j7dfufn3o9t9 X-HE-Tag: 1661064896-883307 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -void __iomem *arch_ioremap(phys_addr_t phys_addr, size_t size, unsigned long prot); > +void __iomem * > +arch_ioremap(phys_addr_t *paddr, size_t size, unsigned long *prot_val); It seems a bit odd to do this in two steps vs just doing the entire change in the first patch. Any good reason for that?