From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 456EFC32789 for ; Sun, 21 Aug 2022 07:00:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC2896B0073; Sun, 21 Aug 2022 03:00:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B72786B0074; Sun, 21 Aug 2022 03:00:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A60C48D0001; Sun, 21 Aug 2022 03:00:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9367A6B0073 for ; Sun, 21 Aug 2022 03:00:13 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6928A80F87 for ; Sun, 21 Aug 2022 07:00:13 +0000 (UTC) X-FDA: 79822700706.01.4CABD6A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 244212002A for ; Sun, 21 Aug 2022 07:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6ySj9j9saW2yCa8c+yJi3tbjUYdMOCd4L5+lUeBFBlw=; b=CFKmVhJoVtkiach+yo+gcT08D1 laKEfLo/oILc9TSGonwru5FCVANzuvnFwQ/3crz8lAV/BpWfSnILYuE//AXjRNbmM8YrOQlJEupHS Gg8fYZxHLqsSTkyzOfq/EHNVynE+0A/ZdKOEdoNdxRiFyWN1/o9Uww9lfjerTMmvne5StBJhBMIaV 8WqTlefjPr0wdF/b287jk6bBPSMrzgTblxlXRYz4yoYNKXM/9Nu+Fn0dZVmthfQBTUengXF73Q1fg m0z9GnXcdPuIH8jU84zUdx2pguBjgU1Fwag/Z98gSY8N1BWQsn1OfHUp+IEUTmwLWqV+/AzQKZTsj zpBdgLuA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPewJ-0073Ye-1x; Sun, 21 Aug 2022 07:00:07 +0000 Date: Sun, 21 Aug 2022 00:00:07 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org, Brian Cain , linux-hexagon@vger.kernel.org Subject: Re: [PATCH v2 05/11] hexagon: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20220820003125.353570-1-bhe@redhat.com> <20220820003125.353570-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220820003125.353570-6-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=CFKmVhJo; spf=none (imf03.hostedemail.com: domain of BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661065213; a=rsa-sha256; cv=none; b=dtbFqszQnrkhprIPK4xY4V6UVqGAlTKU/h3usMWXXf6KZg+ww1RiiTE7sKsLoHWkih386x InoYNgVqmI1jB6yLCby8DVsXtErbc7Z+fE778CEWwK9a9KeVkmioMq9K1S4HCWkPfLgtZz 1Xep4dJgUVBxWWv2C1MJXUAuNVu8UPA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661065213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6ySj9j9saW2yCa8c+yJi3tbjUYdMOCd4L5+lUeBFBlw=; b=rYKcR/vnsxCBUTNfSVAT7HO4nrAc/gEIjzqLiC4mRwr5Fccv6Vsk2wNizaOR3jzLm43AJ3 HKZBvScZ4r93lnekG1gKVRsF2FOiZoRJwNSXR3ke8opAYEmJdZAO5uMdHrQ6LMXN5iXh+N m1hePyW9ANU0RQkJ0H4qAWOmTugDXPY= X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=CFKmVhJo; spf=none (imf03.hostedemail.com: domain of BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: gtz7bzb3tkfr8z1537pzhdaf51y7kiwr X-Rspamd-Queue-Id: 244212002A X-HE-Tag: 1661065212-736916 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 20, 2022 at 08:31:19AM +0800, Baoquan He wrote: > With it, the old ioremap() and iounmap() can be perfectly removed > since they are duplicated with the standard functions. Can you write a somewhat better commit message explaining that it switches to the generic code that has equivalent functionality? > +#define ioremap_uc(addr, size) ioremap((addr), (size)) This is wrong and hexagon should use the asm-generic version of ioremap_uc that returns NULL.