From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73725C3F6B0 for ; Sun, 21 Aug 2022 07:05:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1644A8D0002; Sun, 21 Aug 2022 03:05:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 114916B0074; Sun, 21 Aug 2022 03:05:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 003A78D0002; Sun, 21 Aug 2022 03:05:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E6FEF6B0073 for ; Sun, 21 Aug 2022 03:05:45 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C13C91C5F9A for ; Sun, 21 Aug 2022 07:05:45 +0000 (UTC) X-FDA: 79822714650.09.A8881FD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id 8473280025 for ; Sun, 21 Aug 2022 07:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=c/jrfAPZ5uKkxcDwWOy7Ka9+HHLqiSxehrttZm3hA/Y=; b=ybuNNkflPH7tbvDDltPJb+xko4 r5yfhRLO4SQw6ISzt0vZrQllqdGDNelLKvMenkvn28QaUnx9crNeUYM88rQHXtmQp0sBe15pfCLT6 R8a9y6Cnx0V8nDPSQP57/kSiQZpuOCdvFUTkrMQHqTUvcM0quxPaYKl5+zWfob7Rdv7nWvKm8TKAz nEabX3Khe4YjLusuoJjlT/0R3w2Q62E91ONDG+6BB53sTiUObyE40GdVIb6AJvjAPjVjQX3Yr+7fR dXGaZLjnYmUUPHS+65FUfdQz5FQQKcD0C5+ZTG4a+IoG+DCpDqa8OMHBVfnxkLWS9jpcYtijUepdx ZR3t3Tzw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPf1i-0077qS-9B; Sun, 21 Aug 2022 07:05:42 +0000 Date: Sun, 21 Aug 2022 00:05:42 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Subject: Re: [PATCH v2 09/11] s390: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20220820003125.353570-1-bhe@redhat.com> <20220820003125.353570-10-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220820003125.353570-10-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661065545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c/jrfAPZ5uKkxcDwWOy7Ka9+HHLqiSxehrttZm3hA/Y=; b=IqqnuzzIhfg+FiIV49MkuZ6sr1MRjhM1kLPPAeIoDfxu0DsOSZG21Zs5/2ueI13CRGGjtk WUT8v+ghCElA7GcSPVpqn7CfNc+FFE9qlt8tIy5SYsYrBfARDaAAo3XBFEMUyK24M7YL2m hJeUlTbEaKVBGZmqCjN3O2g/UNgtKrI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ybuNNkfl; spf=none (imf30.hostedemail.com: domain of BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661065545; a=rsa-sha256; cv=none; b=RGWLmzIy/Dar5Ett6j4iR5EX/H4t+i4nyAjrXG9DcBue0n3MyDQEEjzmuPb7pMnrWiRrdU ZFMubKF0fmDdbFFOJwGngs7+VxBMKpdFWnbtLAM8YhjEGc9LCaJ5KR5KHdclRzJP2lODSX NYoU2mCbiwISWM/An0FeFtBtlD8adiw= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ybuNNkfl; spf=none (imf30.hostedemail.com: domain of BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a2efb402714a86af2474+6937+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8473280025 X-Stat-Signature: t35bqn8n1fsq3cu1tmhuxw8cxxgd7ou5 X-Rspam-User: X-HE-Tag: 1661065545-319222 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +void __iomem * > +arch_ioremap(phys_addr_t *paddr, size_t size, unsigned long *prot_val) > { > if (!static_branch_unlikely(&have_mio)) > + return (void __iomem *) *paddr; > + return NULL; This logic isn't new in the patch, but it could really use a comment as it is rather non-obvious.