From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D6D4C32772 for ; Tue, 23 Aug 2022 13:25:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0B086B0073; Tue, 23 Aug 2022 09:25:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABA9C8D0002; Tue, 23 Aug 2022 09:25:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 982708D0001; Tue, 23 Aug 2022 09:25:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 87C3E6B0073 for ; Tue, 23 Aug 2022 09:25:43 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 506C8120320 for ; Tue, 23 Aug 2022 13:25:43 +0000 (UTC) X-FDA: 79830929766.26.B2A98DD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 05F62A0018 for ; Tue, 23 Aug 2022 13:25:41 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 13E2D61528; Tue, 23 Aug 2022 13:25:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84CF6C433C1; Tue, 23 Aug 2022 13:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661261140; bh=/4xhD7ELNjBZtgpSSVaLsvo9d58ZYqtV6ReDGw96m5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D3MRIp0X5ItLOQUwiZtdhZ0TmB2kzlIWU3Kw/M0a9bICSUz4b5UJFQb0AFkU0Msbc 2/jzI9dCTmVTL8M2tVkQ/Jr2EZ2FloyBnnuYVEffahexXdYyEkw4v74RY5xmZdIuPk 4+ROMQHgrVVABkvkS6/oX7NTbYbPTur0KJa4TqdmfFgo+o0LrsMjrI1ZyCoeFVJhB+ HLzbn0pU8+B64MQIOsX2gCN8ROURcpP9kLwsO875FlgnQ+73SAb9O9QYPQa8O9fuWM LypSYds//Lc99u3jTSHur4c6XLqnHAh5+xDwJQSV+bFon1kOGBTLJlRtKXo5HhFIQ/ qfG/6ezFh0Vjg== Date: Tue, 23 Aug 2022 16:25:24 +0300 From: Mike Rapoport To: Rebecca Mckeever Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Shaoqin Huang Subject: Re: [PATCH v2 1/8] memblock tests: update tests to check if memblock_alloc zeroed memory Message-ID: References: <669782f4f508c3dd60c5efd6d130d12a77573448.1660897732.git.remckee0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <669782f4f508c3dd60c5efd6d130d12a77573448.1660897732.git.remckee0@gmail.com> ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=D3MRIp0X; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661261142; a=rsa-sha256; cv=none; b=KogDgwPmDzpK1Z8ug4pc2awP/tJ2jiuD5WIpNKBHxu2UIFCv1PeFHz0tXF5pIc1yZi4sfs Xx6ml4g5miA4XZxzZ8PJ2w7lTUSRHxxbVOYxBTAe6cZ/YZ/HjTmTEUopUxXZ75V+n4+zrL 85/eufGQ5L70v1E5+ge0By6UZ0gc6Xk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661261142; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rFM3F5e+wRpYzlyOFf5Xm0wpDhZMgu2Xmu6dPZB8YmY=; b=BosTz0+0Ux3pet2z+VD7eA3F8/JhdeQivtke00+pBq8m+pZyBC2xcovHdFJ3CLPtG0b8JM UEZcfKt6UI+M2Dtb13sc5m0giT/E/aiZbz01GRlpvvhI8pPHchS/me3/+FbM7PUHdXNHev 9VzbvJ1dY0svAiC8seIZ11ZSOLXQpiw= Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=D3MRIp0X; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 05F62A0018 X-Stat-Signature: 5n5tctuoxf53j6suxttxxdrhcjj8ayn7 X-HE-Tag: 1661261141-826076 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 19, 2022 at 01:34:49AM -0700, Rebecca Mckeever wrote: > Add an assert in memblock_alloc() tests where allocation is expected to > occur. The assert checks whether the entire chunk of allocated memory is > cleared. > > The current memblock_alloc() tests do not check whether the allocated > memory was zeroed. memblock_alloc() should zero the allocated memory since > it is a wrapper for memblock_alloc_try_nid(). > > Reviewed-by: Shaoqin Huang > Signed-off-by: Rebecca Mckeever > --- > tools/testing/memblock/tests/alloc_api.c | 23 +++++++++++++++++++++++ > tools/testing/memblock/tests/common.c | 7 +++++++ > tools/testing/memblock/tests/common.h | 12 ++++++++++++ > 3 files changed, 42 insertions(+) > > diff --git a/tools/testing/memblock/tests/alloc_api.c b/tools/testing/memblock/tests/alloc_api.c > index a14f38eb8a89..aefb67557de9 100644 > --- a/tools/testing/memblock/tests/alloc_api.c > +++ b/tools/testing/memblock/tests/alloc_api.c > @@ -22,6 +22,8 @@ static int alloc_top_down_simple_check(void) > allocated_ptr = memblock_alloc(size, SMP_CACHE_BYTES); > > ASSERT_NE(allocated_ptr, NULL); > + ASSERT_MEM_EQ((char *)allocated_ptr, 0, size); > + Can we please hide the casting inside ASSERT_MEM_EQ()? Like if ASSERT_MEM_EQ() were a function its declaration would be bool ASSERT_MEM_EQ(void *mem, char val, size_t size); > ASSERT_EQ(rgn->size, size); > ASSERT_EQ(rgn->base, expected_start); > -- Sincerely yours, Mike.