From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96CA1C00140 for ; Wed, 24 Aug 2022 12:58:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 358BC940009; Wed, 24 Aug 2022 08:58:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 308B2940007; Wed, 24 Aug 2022 08:58:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F7FE940009; Wed, 24 Aug 2022 08:58:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1298F940007 for ; Wed, 24 Aug 2022 08:58:11 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E2DB940C22 for ; Wed, 24 Aug 2022 12:58:10 +0000 (UTC) X-FDA: 79834489140.06.E888974 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id A32E8C002D for ; Wed, 24 Aug 2022 12:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2VBvEifQjJ0B2yEyDwr1KfnpR0QVvoOJrb8XD2pI0T4=; b=VrXTD/1Gt1++tPqmEJJZcE06QC HuraL9RvVOD2Gr1Kg5a+FP38JYMFJ66udtbfysdVRDvBbiZwaLYqx54wnhn7/tjtZeu5r3qjKiwmX lSKIvV3wUmyUJBbgsGtuUzGOSf6vTOVLJBF/P2d3w9vEm1BXWeeLFl4dAFYDapASZML5uGKISvD1b TSpRMC9TabM+CWy7pZPhN5/2rhM1sD47YesIFjrDEeBviAPjXMnmoz3Gqf6e5DPiu7bhQ3dMkyjs4 VitTic6le3eAIuY8uB0Rlx40LnH6b5hi+OV3gusBZvIK4odFICYRXJHHFNLBmNkNYySW0Q3z0lfLy w3DaE+9g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQpxM-00GLHL-Qr; Wed, 24 Aug 2022 12:58:04 +0000 Date: Wed, 24 Aug 2022 13:58:04 +0100 From: Matthew Wilcox To: xu xin Cc: akpm@linux-foundation.org, corbet@lwn.net, bagasdotme@gmail.com, adobriyan@gmail.com, hughd@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, xu xin , Xiaokai Ran , Yang Yang Subject: Re: [PATCH v4 1/2] ksm: count allocated ksm rmap_items for each process Message-ID: References: <20220824124512.223103-1-xu.xin16@zte.com.cn> <20220824124615.223158-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220824124615.223158-1-xu.xin16@zte.com.cn> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661345890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2VBvEifQjJ0B2yEyDwr1KfnpR0QVvoOJrb8XD2pI0T4=; b=63kR3EQUD7SdMI+Cfui7fmT9abAXlBJuh/4EnFy+vUEWcSAbHJgbyZlKfx3HYHduF1xz7i +BYJ4zl1sfyHd9r+PmcWVIWbdsmyKQg8o5azcrjT4odPuIz0jpjI2ADilasLcjR8vVfNsG G78bucjwJKBTpvC/w69eBWn35xF/BCg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="VrXTD/1G"; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661345890; a=rsa-sha256; cv=none; b=pgh5y8gnO6SVsDHMU1Pw4+jy/aeRtpoZNIMurYsiEHe/4fzRm37OhIK32liTlG512qnQnM 9b+3/cokPQ+seV2Z1J2yBIaZinFuSivAHuhzorJVRxKd3gWSvGRVA64fY5V8nrz5BEvMaV LC/JwwjGUt5rsZvMuF22ZOpHCdgCWko= Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="VrXTD/1G"; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: X-Stat-Signature: 8h4z6f9irwm3ziwwxkaft94aazki479o X-Rspamd-Queue-Id: A32E8C002D X-Rspamd-Server: rspam10 X-HE-Tag: 1661345890-991376 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 24, 2022 at 12:46:15PM +0000, xu xin wrote: > #ifdef CONFIG_KSM > ONE("ksm_merging_pages", S_IRUSR, proc_pid_ksm_merging_pages), > + ONE("ksm_rmp_items", S_IRUSR, proc_pid_ksm_rmp_items), You misspelled "rmap" in the file name. > + /* > + * Represent how many pages are checked for ksm merging > + * including merged and not merged. > + */ > + unsigned long ksm_rmp_items; Also here.