Re: [PATCH v2 2/4] fs/proc/task_mmu: Implement IOCTL to get and clear soft dirty PTE bit

Greg KH
2022-08-25T07:21:26Z

On Thu, Aug 25, 2022 at 12:09:24PM +0500, Muhammad Usama Anjum wrote:
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index b7b56871029c..a7e48ba9457b 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -305,4 +305,17 @@ typedef int __bitwise __kernel_rwf_t;
> #define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT |\
> RWF_APPEND)
>
> +struct pagemap_sd_args {
> + void __user *start;
> + int len;

"int" is not a valid type to cross the user/kernel boundry, sorry.
Please be explicit here (__u64? __u32?)

> + loff_t __user *vec;
> + int vec_len;
> + int flags;

Same with these.

thanks,

greg k-h