From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53C60ECAAD5 for ; Sun, 28 Aug 2022 18:42:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 061FA6B0073; Sun, 28 Aug 2022 14:42:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 013136B0074; Sun, 28 Aug 2022 14:42:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1B44940007; Sun, 28 Aug 2022 14:42:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D0C106B0073 for ; Sun, 28 Aug 2022 14:42:04 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 94A851605A7 for ; Sun, 28 Aug 2022 18:42:04 +0000 (UTC) X-FDA: 79849870968.31.459095A Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf26.hostedemail.com (Postfix) with ESMTP id 5A63E140050 for ; Sun, 28 Aug 2022 18:42:04 +0000 (UTC) Received: by mail-wr1-f54.google.com with SMTP id m16so7692589wru.9 for ; Sun, 28 Aug 2022 11:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=nPeeJvcw+APlSjQr5GEfxQ1+CYvYngFa4Na2HCLoP7o=; b=LaihOXgWdYphgrrA7SBrJOIUhVNl3ESUJDgGPDUfngsClPDVDKzpQko70TrGPfL36F zf38+tv/rqp5oeiVGa+TEEOMuDZU3KT7cuYIqHTfS1JUaQLVNP3523BkxepBk1HXD7e5 okwFBPi/pXCcWC9gHBDusyz+XPhlomVuRkWO/z2vtgE8CEjtKqJUgYU/KKjBdUWeH2BR p0O2HeopYHek3fkBGn5PIwqw/v4N7317ur4o9iZHqkzAmB6BMT9eNAu4RP008KP89wD4 4kCva8i3Ly5Eg2WPnf7wy8foFcNWHhAy/GQhyvl6jB3SZtuOK9GHFG+FAHYokFhOwXIv GdaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=nPeeJvcw+APlSjQr5GEfxQ1+CYvYngFa4Na2HCLoP7o=; b=dR9MXBnFCOF+BXdsg8EIqmI/H63sSzzgHODy1j0xo9bOPFsSzTYFzvkeSMXhDYz7+Z 4uz9IgDyvajxw7xBj5KlA4Z/gZL8o/5rAVRixA9qUb5a0LfrPZjrXbQ4q8ZXvV38mKVK cBHDNMgLruHvBqU8aRRzk/hPdf2GNxWigMa7XhkdobVZrBM05/dZmrOACwNxJhVqBssW kusMWqlspa32KAzmGL3HOm6tFQjuewCjM6PLEERmVgsfJF6v6insQtq2bRx8lfvhhOrz c7XJ61B0e3jztkv7db+L99XpBz2SZB1QwUxNtQdIaNZjvg21HHHXiBpeES+Y6XAWWw2h 35sQ== X-Gm-Message-State: ACgBeo1b8+OOVqAP54nimNbUI4zy6A9HxaoFr023w36kXEIRXAhKzlt7 zaS0rGZaMImLwknzvieIfw== X-Google-Smtp-Source: AA6agR7ZQHVA++7orMaEY7LtCr7ATgaqFa5xAhWfk3pG0NldsIBx9iCH7CjFTtfP+gAErEpY1M+qFA== X-Received: by 2002:a05:6000:61e:b0:225:5119:94b with SMTP id bn30-20020a056000061e00b002255119094bmr4726937wrb.650.1661712122970; Sun, 28 Aug 2022 11:42:02 -0700 (PDT) Received: from localhost.localdomain ([46.53.248.164]) by smtp.gmail.com with ESMTPSA id w18-20020adfde92000000b00226d238be98sm4233967wrl.82.2022.08.28.11.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Aug 2022 11:42:02 -0700 (PDT) Date: Sun, 28 Aug 2022 21:42:00 +0300 From: Alexey Dobriyan To: xu xin Cc: akpm@linux-foundation.org, corbet@lwn.net, bagasdotme@gmail.com, willy@infradead.org, hughd@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, xu xin , Xiaokai Ran , Yang Yang Subject: Re: [PATCH v4 1/2] ksm: count allocated ksm rmap_items for each process Message-ID: References: <20220824124512.223103-1-xu.xin16@zte.com.cn> <20220824124615.223158-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220824124615.223158-1-xu.xin16@zte.com.cn> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661712124; a=rsa-sha256; cv=none; b=uFeozd0TqpyEBBkMUs0wIIkTOnU2nj0mm2Uw/+qrHMwd6S+UvQ89Z/CFyb7uu4nW/S1+5S CbZbEokZeHyPTDesHVnuuPAjoyDs0sjmQQ6xk/4b13tJYsSnNzWb8LG0JmP1dTkdLjQ2YB qNE0IXBbYODbv0eNcCVIzsfZF67tUko= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LaihOXgW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=adobriyan@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661712124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nPeeJvcw+APlSjQr5GEfxQ1+CYvYngFa4Na2HCLoP7o=; b=m6BxhboQ+qNC4RHbsrdmNr1VHuVj//nU1C8zfBNphIgmpscSzDOEOMMXqiCvdf0KoOqOo+ EBIkbObBQZhCtt/qW6fTAfzkBkRYZkDk9wKWZJEtNT+gFImmSh6x+1h8iWrtx2oXKaF6fk /ic4rtcuIuSYupHAj+n+OUfMPqSBae8= X-Rspamd-Queue-Id: 5A63E140050 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LaihOXgW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=adobriyan@gmail.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: gdj8nh19yto3cndouaks5u3y5erfkpcm X-HE-Tag: 1661712124-126923 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 24, 2022 at 12:46:15PM +0000, xu xin wrote: > +static int proc_pid_ksm_rmp_items(struct seq_file *m, struct pid_namespace *ns, > + struct pid *pid, struct task_struct *task) > +{ > + struct mm_struct *mm; > + > + mm = get_task_mm(task); > + if (mm) { > + seq_printf(m, "%lu\n", mm->ksm_rmp_items); > + mmput(mm); > + } > + > + return 0; > +} > #endif /* CONFIG_KSM */ > > #ifdef CONFIG_STACKLEAK_METRICS > @@ -3334,6 +3347,7 @@ static const struct pid_entry tgid_base_stuff[] = { > #endif > #ifdef CONFIG_KSM > ONE("ksm_merging_pages", S_IRUSR, proc_pid_ksm_merging_pages), > + ONE("ksm_rmp_items", S_IRUSR, proc_pid_ksm_rmp_items), > #endif Another tiny /proc/$pid/ file? Guys, this problem with "find /proc" instantiating megabytes is not getting better only worse. How did KSM didn't get its own /proc/*/ksm file with many values? Maybe add /proc/*/ksm and start filling it with stuff leaving /proc/*/ksm_merging_pages alone?