From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2978ECAAD4 for ; Mon, 29 Aug 2022 08:25:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76419940009; Mon, 29 Aug 2022 04:25:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ECA8940007; Mon, 29 Aug 2022 04:25:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58DE2940009; Mon, 29 Aug 2022 04:25:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 458EA940007 for ; Mon, 29 Aug 2022 04:25:15 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2068E14092F for ; Mon, 29 Aug 2022 08:25:15 +0000 (UTC) X-FDA: 79851945390.27.1C2A461 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id CAF02C0011 for ; Mon, 29 Aug 2022 08:25:14 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 736A6B80D88; Mon, 29 Aug 2022 08:25:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1B9EC433D6; Mon, 29 Aug 2022 08:25:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661761510; bh=hHALztWivQBNH4N4zzMDPUp5mHUfdWji+XMB1erl5G8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GlT+KGX8bp6SKLvI26qUDpHQAzdxTDNmnyx44XM/wkF9Vn/REfOGnDPnv5kO150Hj ak9KEGjqJRuTIaU1tSll5KYaBjCgFJlS7Ugd/ZV4i9fACmloDO8lRT46fOjJRls7Kd NzdIE5M0G0se8V+k+kDnWEea6XNApuqBw6tZvDMV0PWlvhriuU6ZQVBiywmdvz1sf0 t6G3kYkTIO3Z1lyKHu+pyFeGGSFkU1hZ9/F6rGC4psAqaoIS4tF22lbQ+2AqvM7JY9 hq5+aSq1gcwar8R1moAf9JkwL+jfk7xedTP2pv1DFGttT4KUE6A1zE+d0FYhDPaELu Qam41bd2GMDAQ== Date: Mon, 29 Aug 2022 11:24:56 +0300 From: Mike Rapoport To: Song Chen Cc: karolinadrobnik@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] tools/testing/memblock: define pr_warn_ratelimited Message-ID: References: <1661755140-3331-1-git-send-email-chensong_2000@189.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1661755140-3331-1-git-send-email-chensong_2000@189.cn> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661761514; a=rsa-sha256; cv=none; b=DPUCkGgFI8q0wvH6D8d/vX4vsKwCX1P9mjxMVz/vDGNwrfOPAPZurK8eXdkYm+nHU8yJh9 pFUzITPdC2b16zYusZSqF/maIxvEsrFNrlxq/jKvBJbAECh44NuOAwMiIjPEfh61TnbNxf uH9wg3Xpc4nYcY43Qig1dWGVqkrMyKM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GlT+KGX8; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661761514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sLAlaDketiZg5uUnd5JrOXZD0a1ab0TVbX/F0pa2oFc=; b=euhcgTCynYkQjFqFkyLRJtKs1VUtG4eQHbUdEnI9qlIEoVJgdnHVYqFonETRkwZGDMEar+ tX4KKqtqGUS658Xxe0L64jME2mJUdvLUycNTDL3nrRLsPMyBSHToQpmoCpARtRKasnTkG0 c3rKCLlpcVm6QD1m0jMu9aIRLl4htfw= X-Stat-Signature: rk3bzwnbket19pi8dpp8ex3zbsay3hwj X-Rspamd-Queue-Id: CAF02C0011 X-Rspam-User: X-Rspamd-Server: rspam01 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GlT+KGX8; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1661761514-968579 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 29, 2022 at 02:39:00PM +0800, Song Chen wrote: > Commit 14d9a675fd0d("mm: Ratelimited mirrored memory related warning > messages") introduced pr_warn_ratelimited in memblock.c, which breaks > tools/test/memblock, below is the message: > > /usr/bin/ld: memblock.o: in function `memblock_find_in_range.constprop.0': > memblock.c:(.text+0x4603): undefined reference to `pr_warn_ratelimited' > /usr/bin/ld: memblock.o: in function `memblock_alloc_range_nid': > memblock.c:(.text+0x786a): undefined reference to `pr_warn_ratelimited' > collect2: error: ld returned 1 exit status > > A fake pr_warn_ratelimited needs to be defined in printk.h like other > prink functions. This is fixed by commit 0a7e91528202 ("memblock tests: fix compilation errors") > Signed-off-by: Song Chen > --- -- Sincerely yours, Mike.