From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21BEDECAAD4 for ; Mon, 29 Aug 2022 08:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4957940008; Mon, 29 Aug 2022 04:24:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AAD0940007; Mon, 29 Aug 2022 04:24:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8245C940008; Mon, 29 Aug 2022 04:24:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6F287940007 for ; Mon, 29 Aug 2022 04:24:06 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 41D7380305 for ; Mon, 29 Aug 2022 08:24:06 +0000 (UTC) X-FDA: 79851942492.09.E458F35 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf19.hostedemail.com (Postfix) with ESMTP id B630F1A001D for ; Mon, 29 Aug 2022 08:24:05 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1C0A3B80D6A; Mon, 29 Aug 2022 08:24:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C5A7C433D6; Mon, 29 Aug 2022 08:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661761442; bh=xS+xHKp43eJ8JYjFC7VI8wrHD5W9fUJOHs3BwfjYs3o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OrAmrIWvV+DVdnADMcl7DZCfVEGWOqsPdJlgwo17uOSljVw3LQDw3aQnyfquQLhrL q+5jRhjzWKsj1rjEh1HwACmrTiLxzAAfH7FHM9OBHt/K4D7mCVTAJHxTeSj1vhO0Au zv+UePiMENViAS7Xt6itohgyCPU3rT1uVwxOdpkkzzdeU8W2MlSzAHIbSNNevkHDeW 6Su4R8a+BD3ilfkUW8cHlmuQxSROcmAn7o5kjtr/KQCZVa6cXse+R0LZ2YUpqJ/JHh TiMfR9upny50bCg00b0aT5gx3ngNzX5KlQ0KLOAUtI3SZyzloqF79crxIsa1UHQgp6 i6ywDZryU1SLA== Date: Mon, 29 Aug 2022 11:23:47 +0300 From: Mike Rapoport To: Song Chen Cc: karolinadrobnik@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] tools/libs/slab.c: fix compiling mistakes of uatomic_inc/uatomic_dec Message-ID: References: <1661755121-3286-1-git-send-email-chensong_2000@189.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1661755121-3286-1-git-send-email-chensong_2000@189.cn> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661761445; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YMzOs6+ABBxRDzo+BmUjNW4fkaVwOxGwgvTrx5r4rWQ=; b=VxXabvewKCrk3rGWnI1gBSwspV6mVPNQeMVDc/bB3B77T6QHpTx+pT+B97nWAN2l4qur8r 2vAU8CPY79UoHDxJoA6Ym0q2o/Kw95wtsCJpIV+7rLex44KbZrjAzbHqvfkCW3TkSO943g XG36Y+VA5O/WIqKtujyx1Y44VvaXO0k= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OrAmrIWv; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661761445; a=rsa-sha256; cv=none; b=Munizfhz22wCIYCZlfpHuhF/unW9/1F2FVbgqGTohHwy6dHka2hyBGw279o6oqHUaBhtlT +haUTw1svEwfRVfzNhk/TUCawpkd4UM3itdFM9OzdG6Z/dBEkL8fKCCqdski5HOcRBkvB7 TpXn70JOnG968VtI5fV4Zllw872WFUw= Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OrAmrIWv; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: o1qprnm7imguur7d7cmfzy77ggdwf1c9 X-Rspamd-Queue-Id: B630F1A001D X-HE-Tag: 1661761445-878184 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 29, 2022 at 02:38:41PM +0800, Song Chen wrote: > I tried to build tools/test/memblock and got such message: > > /usr/bin/ld: slab.o: in function `kmalloc': > slab.c:(.text+0x2b): undefined reference to `uatomic_inc' > /usr/bin/ld: slab.o: in function `kfree': > slab.c:(.text+0x97): undefined reference to `uatomic_dec' > collect2: error: ld returned 1 exit status > > I could find any definition or inplememtation of uatomic_inc/uatomic_dec > in anywhere of the code base. So I use atomic_inc/atomic_dec_and_test > to replace like other tests underneath tools/test, it works. They are defined in liburcu headers, in Debian they are found in liburcu-dev package. > Signed-off-by: Song Chen > --- -- Sincerely yours, Mike.