From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E944DECAAD2 for ; Mon, 29 Aug 2022 08:46:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F6B4940008; Mon, 29 Aug 2022 04:46:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A636940007; Mon, 29 Aug 2022 04:46:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56E22940008; Mon, 29 Aug 2022 04:46:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4739C940007 for ; Mon, 29 Aug 2022 04:46:09 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0ED5A80B17 for ; Mon, 29 Aug 2022 08:46:09 +0000 (UTC) X-FDA: 79851998058.20.D3D1165 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id 96E33140047 for ; Mon, 29 Aug 2022 08:46:08 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ECE55B80D8A; Mon, 29 Aug 2022 08:46:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 535DDC433C1; Mon, 29 Aug 2022 08:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661762765; bh=mgVwGZEizzRLcCal5uavQ7yEy2IwtS+YRh5v/25aCFI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eyrmGCYORjB9tZKKC0Lk2sakIdGI4zwO8nRBeqn3k+b1N+ygOuzRK0Sk3CIjp35Af iCUXDAhVYJIlO6G2jzbcicjSyGUcjP3pn4MBKTeCOKUwwbXohB0WRHoynmTQN6H5uu QRv7tDsVEqMZ18dW54OFLs6pZaIXalBlW2UVHW4TJMXNRu4Nyvml3pwjExR3U2h/JH var9HyNFHSQR8AWW4YtirdZ2XaB+C/E+9+skWl+D+V5UT7Re1C0/7yuaTXN8DW4+f4 eKaEFl+irOrkThS0qSkDD98tQESPDN+77+uVguVaDfShy67EMLxo/TSDoltAHQUi37 diQ3liJLUYArw== Date: Mon, 29 Aug 2022 11:45:50 +0300 From: Mike Rapoport To: Song Chen Cc: karolinadrobnik@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] tools/testing/memblock: define pr_warn_ratelimited Message-ID: References: <1661755140-3331-1-git-send-email-chensong_2000@189.cn> <520fb512-8d2f-15e1-fd00-a7343e136d1c@189.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <520fb512-8d2f-15e1-fd00-a7343e136d1c@189.cn> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661762768; a=rsa-sha256; cv=none; b=QU1BcBTv0evV2KyfNfapHQj4PhDa+Yu98pk/HaNBRh6KYOdL28GauE8s6sQw3GPP/YkEX5 nka0JptIWaEDzNvSo1MYRSZXA9QvvEdld5k1pZJ1sACVLh/3F2OU8TAIiD9jX8fKsqhNiV ZyMM+ML3PqPZ7mPUkHQPmH1fWNqiiPc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eyrmGCYO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661762768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bFE3XyfDLr7C1BiSJmD2bIy/KVQH+0sQKPqwSumeppM=; b=YpDTCa5tLZNzzQ4Ah974DztoShhPewPyGjLIMksgdRQV3FpvguCg3LzhuzqwW6AGAmwWMk WCeko54vLiV3D35I/lVed5rFQXZiq8+wbX34qm9M3PQXWsyoYQAY+sVSkampqkkvAsjeK9 7/iOxhB+XR21Gw702ZG4VC8nz5lStzI= X-Stat-Signature: 9e7igmz1spcio4u7ywwaz3on97taixtd Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eyrmGCYO; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 96E33140047 X-Rspam-User: X-HE-Tag: 1661762768-936364 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 29, 2022 at 04:32:47PM +0800, Song Chen wrote: > Hi, > > > 在 2022/8/29 16:24, Mike Rapoport 写道: > > On Mon, Aug 29, 2022 at 02:39:00PM +0800, Song Chen wrote: > > > Commit 14d9a675fd0d("mm: Ratelimited mirrored memory related warning > > > messages") introduced pr_warn_ratelimited in memblock.c, which breaks > > > tools/test/memblock, below is the message: > > > > > > /usr/bin/ld: memblock.o: in function `memblock_find_in_range.constprop.0': > > > memblock.c:(.text+0x4603): undefined reference to `pr_warn_ratelimited' > > > /usr/bin/ld: memblock.o: in function `memblock_alloc_range_nid': > > > memblock.c:(.text+0x786a): undefined reference to `pr_warn_ratelimited' > > > collect2: error: ld returned 1 exit status > > > > > > A fake pr_warn_ratelimited needs to be defined in printk.h like other > > > prink functions. > > > > This is fixed by commit 0a7e91528202 ("memblock tests: fix compilation errors") > > Is there a commit taking care of 902c2d91582c(mirrored_kernelcore) ? it > brakes memblock test too. If not, i have fixed it and will send a patch > soon. Yes, the same commit that fixed pr_warn_ratelimited() issue. Please work with recent version of the kernel tree to avoid work duplication. > Song > -- Sincerely yours, Mike.