From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFB0ECAAD4 for ; Mon, 29 Aug 2022 08:01:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84590940008; Mon, 29 Aug 2022 04:01:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CE16940007; Mon, 29 Aug 2022 04:01:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62050940008; Mon, 29 Aug 2022 04:01:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4BA66940007 for ; Mon, 29 Aug 2022 04:01:51 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 24C4112118A for ; Mon, 29 Aug 2022 08:01:51 +0000 (UTC) X-FDA: 79851886422.19.8B6FBE3 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf26.hostedemail.com (Postfix) with ESMTP id 37486140057 for ; Mon, 29 Aug 2022 08:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661760110; x=1693296110; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=1lyOOaLC9ecSAhqtUTvnLeWAKAd844PF0w6j9+fgJ10=; b=JGVc/MkgvlaHPrRWgAsKmmpVtljneOV3Rgd2r67oFGAECN794dxlfsvg Hf4I2ZOVeRNHxwSPu8PJINmNLOpCdskL8gMWlR6WH9dc7b6O1yKec7MOq kLvgSNytsu9IxiYPHTYPOD154T1RQfywybD0VV3IObFt6CeCb9eRyCddG ckt0oPJJz5tIpNR/Elr6Rxg02SYh2HJPac3ZSWL8otLPWqND74Y6tE5N5 4zOgb0biJvdWjeQ2tgRMVMgBnEt0ha6d1Wg9jD06Gjn+iGm4HtfdKBIQ8 TeMI/w9RVqA4Wkm1A3OEi/wL8ZNwmPRgg/lRhdhq+j5bJX58rIaQb16dd Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10453"; a="293581541" X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="293581541" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 01:01:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="588074054" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 29 Aug 2022 01:01:19 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 01:01:19 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 29 Aug 2022 01:01:19 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 29 Aug 2022 01:01:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EQoGme0IeLonQutt5WJRPZ0jEWhAmPZs/78WAROYA1ltlPAcQV4Sqf4HSfhly0shun6kIGyvOMYUmcNTM4Lxiui+wr7tYejxgbMXkC5ZLeHGCGOs1KrjnENT3F1QDxQcAR490MzA8bg4Z6Pm+OtHd18F6fzM8Nm/rUtKPWxka6T0DwWwFrQvAUlzwJIvwUYok8AkyQOw/shTbg1wzxbSuPI27v4eQ51DLC4HO8zeT+y50cV8MxJoD45hDGkl/qvw5crFunL/S1U8hqgKFLckR6gea2j2HWwudeegRzuicpnwENqLyDT7fSrFMWvd8MxCU1GhRq7c96I1A+rhghwWxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N2QtYF7cKmqH2gY0EsSQ6f2W8ANNmMdwhSx+6XDsabU=; b=dXiW1DRyfizGN4syvxDP75TeN9p107uGAsxQRqV93G2Ob+Ll0+mnxMZ9Mp/WMI6trRSBwCWuMDIRSLLvm50lovCrIgZ2bQkWcv6o8bvY7t6mI4wHYFtsMxFFXKE33TRh8eb7wdWsxZ1DBYHFZr6o6R8ccT/NhSJ4PX7EI6LUziEvmsD5gspNqWRwFfsV7M09IbyV189sM/9JwkDh6rThkijzwFv9b4hkLPzAu+tejUwcOMHvyEzhMxrkBa8su5tSo7YOGwtshv4AhWFwUvlzvEaRLkOsRfcIEPvoSQD8JLZlNU5hknKi7UixzBBiBzQif1VTwRhPpqsvM1cA5wNyjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) by CH2PR11MB4327.namprd11.prod.outlook.com (2603:10b6:610:43::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Mon, 29 Aug 2022 08:01:16 +0000 Received: from MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::d446:1cb8:3071:f4e8]) by MN0PR11MB6304.namprd11.prod.outlook.com ([fe80::d446:1cb8:3071:f4e8%5]) with mapi id 15.20.5566.021; Mon, 29 Aug 2022 08:01:16 +0000 Date: Mon, 29 Aug 2022 16:00:41 +0800 From: Feng Tang To: Shakeel Butt CC: Michal Hocko , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] mm: deduplicate cacheline padding code Message-ID: References: <20220826230642.566725-1-shakeelb@google.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220826230642.566725-1-shakeelb@google.com> X-ClientProxiedBy: SG2PR02CA0089.apcprd02.prod.outlook.com (2603:1096:4:90::29) To MN0PR11MB6304.namprd11.prod.outlook.com (2603:10b6:208:3c0::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 70d15240-7903-4e4e-27fe-08da8994a644 X-MS-TrafficTypeDiagnostic: CH2PR11MB4327:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3wjJgQmtR54Z4cNsF0gsGOsHEA6z4Z4mBNti6kq7HbhB04t9K6M6jJvRrFNGkjKpIRBe97kpiRXEH5V5zjhWEH5MpeVmrgfhrZ3tBLxDeWUntFX8qAcJkhcnuccPu2REBHYAYmCRFkz24Tn4gO+J1Zf1FIsteH2vgllSeuqR8vvvr59tgTNdlv2jIRC+4YcgM1CHcACUhK78mTxz4yAkpcgSyL+lmySDnHo1uz4a2CSRCqRPtpxWeYnQEz1Ve86gEu0YgO2ojqBK6uk8JULdR64jPvfR5Yb5gmQM5r4X7wWQ9YSpIlyQ9TMOmSk3T78lrVrfVQ5HgsGiIkCjRUzANY/Tdu9+Tf0GUqLRtExR6N+7c9JzpLNRPO3UAVWpW6u0uTHidudiySyfI/WXQ12hlQ9caXaIv1rszgIT97l68js9v2G0gRmxgng+qM/JqbSewle/7SBhs8TOWPY+rWMlDxIKNmsTSbHyMWMS2qDF835hPsZEsOFdY8OWkjhioCk+J/kJBoxcxcOX5RitRhSdBl7p6+JLp4c80aQqw4m3JbeRNVzp9amzRL1Kl5REyyKxLxqUWYASUy1/lcQh4Zn3c0qZMLSg4NNHUlxD0wXWa4PL5OZOwU5hhQspMKvbuFq6plU+cZa/csDGk+0gtPgC6mlf24OFWqZHxG0mJbYqI1NvSlmea2ekOFzYP4xhFoEhLQgplHqc4+SmsUNHCWZHHg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6304.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(366004)(39860400002)(396003)(136003)(376002)(346002)(4744005)(2906002)(6666004)(33716001)(44832011)(6506007)(9686003)(26005)(6512007)(83380400001)(316002)(186003)(66946007)(4326008)(66476007)(8676002)(66556008)(54906003)(478600001)(6916009)(6486002)(8936002)(5660300002)(38100700002)(86362001)(82960400001)(41300700001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wd9w4XnL/qOqMy7Ngv5nLenVrsCMNX0k+y8wglJfZbZwIiQAoR6BO181R+BU?= =?us-ascii?Q?+La9QTp/2BSEZOLLV11vUXMWpBfJUsXQhCkmk0TtJw3pHvSvOYkHh5OPdBmU?= =?us-ascii?Q?80zGFd6IpHVsmkOGQdT1T6+axldPS49fjPjUNu3bIyF9jbyCgejIgO10SYii?= =?us-ascii?Q?JcKrVEa7gfoA+5ddTlWwVsBga3SwdPF4hxsnhhRk70ExNINcCPxH5FGS0Gfv?= =?us-ascii?Q?D8UEmO3nAav/tz+FCET9uTntMtqDImiSpp2qHm0k52QRkdAvkCWiT75gDSeA?= =?us-ascii?Q?OMsH4HYxWuAjdjFR+hG79D/IHNl2zfoBH2xtiTj5Ob+3j9xwS3WyAZzLZsyI?= =?us-ascii?Q?CDAW+E7Xc8CAt8P5+GCPRYvuDg5oeYMaymeZsV2J7ptNkTKsIr0dLvhSK/4C?= =?us-ascii?Q?LWrG5dNRutNhSFKnTgtksGUxHon+HnBW1T8urUzqIqLv8ELo16+WyK4Szecz?= =?us-ascii?Q?H3QNRaKhNSzOegb92/uLVebmcOH10Ne3hbjLZjYhZQRkZ5pChYnKK8g46FLu?= =?us-ascii?Q?vDfkyHtkcF8785QHkRVU+pojMzpvydlHlNoo7lBnZk94sYNWK7pfrOoTfQAW?= =?us-ascii?Q?hFvfLzlhAxdv+uX8EKxxK3H0GcjYlRPDNOxJEf7A1e7sOl9l2lX/PW24US5Z?= =?us-ascii?Q?JCvOb40arwsb4tTmoX9VsSm7OWIXZBYcVoCAjzekUlYebFyMLuUCmGogv7wK?= =?us-ascii?Q?nfsvQ2zwbm92UKODyuRdxpm5n+9u41sTxy7QwV7fNuKP+KJccQKmuNvIcuyJ?= =?us-ascii?Q?Flc0gnChQ5dbAlZbByYjhe7IJuqXMI+VnumWmcpL8apiM60mCaJQUFasWki1?= =?us-ascii?Q?FwL0NZQcg0nWzj3RqyutjcodB4cMaDmMeiGilfEZ4L4IM3c1PRDafZ4l/EW9?= =?us-ascii?Q?JY3NOuq0Dgkh9fh8fL20fb9/OKeHiucQBLLux0eWefp30UdyLRNjCD1poz+W?= =?us-ascii?Q?HKTwuWtEMBbdxvlL0+uQ8j3s5v27oHYhYtn1Y2i45VZGHg4KVTmBiAardqtJ?= =?us-ascii?Q?aXxULNH2OgARGhNlL6stNQqJ5NcZdA0kHKC/H8eGeg8PxeIoGM88cAWpcH91?= =?us-ascii?Q?dyczOeMazWb14loHhIGQu0z0Ok5dB30rOanore2UEMOykSC8Js+VlUWIu6hz?= =?us-ascii?Q?4sYSF3U/EtHLw+jLXqHBVxdGdvuPezGKTb3W7cPpxcKznkW8prOdZWuyUOON?= =?us-ascii?Q?8eZZpawOW8NHQ6ixwg1u7QuHmOaOJblmPwZ9cFfUMCIKzOmNdeyTPz8oG+AN?= =?us-ascii?Q?nn6xNH1cJ8LHF/STscuNh45mDDhzzCUu2HaaOuIoZSsRDsYv4UM06zbC7kbO?= =?us-ascii?Q?CBRN8cDOt8J0lbahQsYqxAxbZKRQVNOG5N1rEVh8t3hm71djeqzYh8cPT11D?= =?us-ascii?Q?y/n+/lhXyeWceDg40T3cYn5VbrfHhvZtN3a5+BuRj3m+u79K0mavmoyvvwkT?= =?us-ascii?Q?J5yEYFuhoo+X3ZeXUkZLGEMxD62nAp2rrD0bfTAUpWNQJO+1ER6WsTaSIZuU?= =?us-ascii?Q?CnUt6ZKENi/eferumCt3FZ+HGeeaZDITFxseq6TwECNpr1h27aa2CrMdBouZ?= =?us-ascii?Q?Hxz1P7lvAYE38CNN/4LTQ4gJ412ssEVq7hPREb6X?= X-MS-Exchange-CrossTenant-Network-Message-Id: 70d15240-7903-4e4e-27fe-08da8994a644 X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2022 08:01:16.4933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: daz8dmqbltcwAdtj23OlFhGlUwxVEv79Pi1jmibdu4tVyxxYjFES5/N3L0GpHX9WQNXLYo5pya6Vbvbw7RXJLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4327 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1661760110; a=rsa-sha256; cv=fail; b=1L63vjU1mO7w3r3FyN5JdttEAPjgZo1llTJlwpIpuqeMUlilMI16KYNK+bqlp+FoOqI29U 27/tVINuiTUs8D/I8dT3z75xAD8mNyETPwt0V/lTksMw8OoBof1AuzBWf4e38Ohxe4FPwn NiA6lzoSCsrXPZuQPXohA2JTFeBDGUA= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="JGVc/Mkg"; spf=pass (imf26.hostedemail.com: domain of feng.tang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=feng.tang@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661760110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N2QtYF7cKmqH2gY0EsSQ6f2W8ANNmMdwhSx+6XDsabU=; b=wcRHKWPxXwinEg0rk3k7ApRLPUsFTkKI2slZ1psLfIbr4y+wTqFkWCmtRWtRrsWed73sP0 rYoQfFnsgm0Qg5Pa+Aghxp6agq5ERiJUFucDNUrle116c4VzRt+/Znuvl7JvdOwz3UmZO8 RbNPt8tr4ZPlZMXZRIn4eaJofjBTOxw= X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="JGVc/Mkg"; spf=pass (imf26.hostedemail.com: domain of feng.tang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=feng.tang@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") X-Rspamd-Server: rspam08 X-Stat-Signature: dzkiyb9tft47cpc3e91m4r7rzdzbai84 X-Rspamd-Queue-Id: 37486140057 X-HE-Tag: 1661760110-209734 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 27, 2022 at 07:06:42AM +0800, Shakeel Butt wrote: > There are three users (mmzone.h, memcontrol.h, page_counter.h) using > similar code for forcing cacheline padding between fields of different > structures. Dedup that code. > > Signed-off-by: Shakeel Butt > Suggested-by: Feng Tang Reviewed-by: Feng Tang Thanks, Feng > --- > Changes since v1: > - add semicolons in mmzone.h > > include/linux/cache.h | 13 +++++++++++++ > include/linux/memcontrol.h | 13 ++----------- > include/linux/mmzone.h | 24 +++++------------------- > include/linux/page_counter.h | 13 ++----------- > 4 files changed, 22 insertions(+), 41 deletions(-) [...]