From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B5DECAAD3 for ; Sun, 11 Sep 2022 16:08:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBBEB80014; Sun, 11 Sep 2022 12:08:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E443380008; Sun, 11 Sep 2022 12:08:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE4E880014; Sun, 11 Sep 2022 12:08:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B819180008 for ; Sun, 11 Sep 2022 12:08:54 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 74405808B2 for ; Sun, 11 Sep 2022 16:08:54 +0000 (UTC) X-FDA: 79900288188.29.750CD5A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id BBFD31400B4 for ; Sun, 11 Sep 2022 16:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OXqvDfMO3yo4jyLaEpdKmbXpj6kJzDaw7s0LNfWous0=; b=lMrN9+3wyfjxun3GCFnAAivwQ0 lDnXt4umgwhm0yW4JX+yRLJ1jaM26SZmJZ4XztpXr6hp45ajPs3tD30aHV8Q2g2pH1tdFTBWuJeEl KKAshW0GzHEiOecsKR4wyDseSBJCByvXszz7IyevSAdHG+5Z/SJNJZv5mAQVxwAM8i49TNd+ZJwoL Qa49blWO8g+OOUSS+ot0tFb9OKg3xZHUv0JLhKW9atYcYEeYqm+k9xzXHLA4XCjWN9vRiO6EIXGbd ETJXuIWvzg3F7cEdcioGDE3JtZJg3aqEXT/+n1TcdIGFmqJvSA8PHGdgiVLOwtjhMnyVtMbL47KBy lanGTTEA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXPVq-00FB0o-Kr; Sun, 11 Sep 2022 16:08:50 +0000 Date: Sun, 11 Sep 2022 17:08:50 +0100 From: Matthew Wilcox To: Pasha Tatashin Cc: akpm@linux-foundation.org, corbet@lwn.net, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, rick.p.edgecombe@intel.com Subject: Re: [PATCH 2/3] mm/page_table_check: Do WARN_ON instead of BUG_ON by default Message-ID: References: <20220911095923.3614387-1-pasha.tatashin@soleen.com> <20220911095923.3614387-3-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220911095923.3614387-3-pasha.tatashin@soleen.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662912534; a=rsa-sha256; cv=none; b=ZHttRxITRfVLowGfLpJ1Z4oIMh5O2ZQLfTNwSx9pPyW5EDHPSGukfKhVem/OIvv24UIEdt LlfSO++qYTIMntzz4u2Mz/bO/AnqbjsrpmJv2QJobVx4TaZJMeKD4yjhRaqhrJUUfSHiK+ i6tBnMO/RtFzJV80rWdP8qkZvaHRL+k= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lMrN9+3w; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662912534; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OXqvDfMO3yo4jyLaEpdKmbXpj6kJzDaw7s0LNfWous0=; b=kZ6qvS2Z4PePMaT9TeJQaVeurmiGnDAacIn1wmusxLfdHGPXSgFvWvbEp7Wkuy1f89bZvU OXQ1o9iABOxCHpS/o4dR+JNidrJu75/vq5TEWmLp3MQcyxRRhSA7WMem4SHRaQ8uIIkFlV 7AkTs80QP70jIqvGT3fqtniNGECxRjU= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BBFD31400B4 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lMrN9+3w; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: s5di835banuq97ocnxcy3fnrrsmf6x4q X-Rspam-User: X-HE-Tag: 1662912533-771559 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Sep 11, 2022 at 09:59:22AM +0000, Pasha Tatashin wrote: > Currently, page_table_check when detects errors panics kernel. Instead, > print a warning, and panic only when specifically requested via kernel > parameter: > > page_table_check=panic Why are the page table checks so special that they deserve their own command line parameter? Why shouldn't this be controlled by the usual panic_on_warn option?