From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68F77ECAAD5 for ; Fri, 2 Sep 2022 15:13:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85942800D6; Fri, 2 Sep 2022 11:13:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 808B98D001B; Fri, 2 Sep 2022 11:13:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D01B800D6; Fri, 2 Sep 2022 11:13:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 59F0A8D001B for ; Fri, 2 Sep 2022 11:13:35 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 29694140BAD for ; Fri, 2 Sep 2022 15:13:35 +0000 (UTC) X-FDA: 79867489590.14.2C606D0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id B4648140072 for ; Fri, 2 Sep 2022 15:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LWi1NrY2/7cJMZdtMXH/O4pRfZOaLxdRq+GMfQXVvRQ=; b=Xv3sPjQRmqKS1aW/0flFzEXOKF YeFzZj81isOzd57n7rr1POEqSH4mN90s7zgHGD8EUU//0PYExrjy8v7tJTN9obAgKv5WHTMOsUlcL eqrJspMGV6DHYIBHP+F5i0Gz7ToByvO/rFL3+NypQJaLUH/+XL3LdU/mQGj7GcuR3plhfbxFnR3Tc ZD5FQ15unahGX7PWrxBvJ8tG6rOogtRN1KT8DgO2uuVLUNX3jqgHAxxGMiHMrbsZw2fowHy06zPPB ApupSFMb/0IN4VaAjY+dBM+GpgbTNYooKyq7vxT+qRHn3L+leIVOBYvPHASIA2ztDCBkMMtaK6q6b p4MlMVSw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oU8Lq-0077ZP-UO; Fri, 02 Sep 2022 15:12:59 +0000 Date: Fri, 2 Sep 2022 16:12:58 +0100 From: Matthew Wilcox To: Yury Norov Cc: linux-kernel@vger.kernel.org, Andrew Morton , Andy Shevchenko , David Howells , Ingo Molnar , Geert Uytterhoeven , Jonathan Corbet , "Kirill A . Shutemov" , NeilBrown , Rasmus Villemoes , Russell King , Vlastimil Babka , William Kucharski , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 08/10] headers/deps: mm: Split out of Message-ID: References: <20220706174253.4175492-1-yury.norov@gmail.com> <20220706174253.4175492-9-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662131614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LWi1NrY2/7cJMZdtMXH/O4pRfZOaLxdRq+GMfQXVvRQ=; b=vFdrR5fFfF/HtqdeESGmaF7eiOBQTW9JijhU9cymIX3pE3RgRYuOZ+TiT9KIfcUCgZehPK q9/EELi+IV1Q+EISDFEY7mZdYQlfdTmJ2K4mmTOot3WExpRZGNnVeqKTeLXu5ipQP5MLrX OaAWXxqsW5T1y0k764CZsEcnQbqhIdw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Xv3sPjQR; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662131614; a=rsa-sha256; cv=none; b=pO+o7NP+TNvLNFofWULVRvIfaHPebWYKX0ZJikolZUHoUS0ZGNqLT/Fl5pILl99oWCF2pQ F+ReIBLqnvU6lO4FZjgGXkk0H+mNgF8JlHoXXzoRFfO33nsJs6zx3TmmOrAIlMPwe8s56Y HbFga7Ds3vSMwwaCL1IWT94tq4Y84kY= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Xv3sPjQR; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam08 X-Stat-Signature: bktpa1dr46psc3oecjxkn9br84qddei9 X-Rspamd-Queue-Id: B4648140072 X-Rspam-User: X-HE-Tag: 1662131611-300443 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 01, 2022 at 07:10:09PM -0700, Yury Norov wrote: > On Thu, Sep 01, 2022 at 09:43:13PM +0100, Matthew Wilcox wrote: > > On Wed, Jul 06, 2022 at 10:42:51AM -0700, Yury Norov wrote: > > > From: Ingo Molnar > > > > > > This is a much smaller header. > > > > > > Signed-off-by: Ingo Molnar > > > Signed-off-by: Yury Norov > > > --- > > > include/linux/gfp.h | 345 +------------------------------------ > > > include/linux/gfp_types.h | 348 ++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 350 insertions(+), 343 deletions(-) > > > > You move a lot of kernel-doc. Where do you change the rst files? > > Ingo - nowhere. So I did it in the next patch: > > 7343f2b0db4961d ("headers/deps: mm: align MANITAINERS and Docs with new > gfp.h structure") That's not the right way to do it. Don't merge a patch with bugs and then fix it up in the next patch. Just fix the patch. This is covered in Documentation/process/.