From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A16C7C6FA8C for ; Tue, 6 Sep 2022 06:36:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C27880251; Tue, 6 Sep 2022 02:36:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04B4380224; Tue, 6 Sep 2022 02:36:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2E3280251; Tue, 6 Sep 2022 02:36:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D039F80224 for ; Tue, 6 Sep 2022 02:36:26 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9B3ED12016C for ; Tue, 6 Sep 2022 06:36:26 +0000 (UTC) X-FDA: 79880701572.04.BFBADA5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id 6B18B400B0 for ; Tue, 6 Sep 2022 06:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kFNZmmVwOhX3BjOPJ3tln3iTlg4hrSY3aWoS1Dwfdhg=; b=yGw6sWaI79F1sxKkVQaLBqfkMn ciPMa49hRCEsXC2e6QaC54/IVuW1x7URn7p9FAd8AYvAjhg/l+1gdoUkyxzOIxNQSBREX9xh7Ddi7 q2c0xDaqVAW+qvoITRmcqt4ZgncEoEdCsyZ+if/g0K63wSpNDe759gtusSOfiypyV3ckYrrwNjqKy fw+hMWUso0tMaAGn4D5npZ88RTr1mhqS1sde0A6s/XS2WYHo+CKamVL67MufxQdIBBU7Cql8EAIJ8 2S3PpJWk6hCoYJk1DgBfZbJROPvkE3hHk70QgGadjMpxViBoTBeQ/LLfjrtGr9lkOg7brY3tIdMCT o3mXVCUA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVSBm-00AS9k-Lz; Tue, 06 Sep 2022 06:36:02 +0000 Date: Mon, 5 Sep 2022 23:36:02 -0700 From: Christoph Hellwig To: John Hubbard Cc: Andrew Morton , Jens Axboe , Alexander Viro , Miklos Szeredi , Christoph Hellwig , "Darrick J . Wong" , Trond Myklebust , Anna Schumaker , Jan Kara , David Hildenbrand , Logan Gunthorpe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v2 0/7] convert most filesystems to pin_user_pages_fast() Message-ID: References: <20220831041843.973026-1-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220831041843.973026-1-jhubbard@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662446186; a=rsa-sha256; cv=none; b=CTvtXmnMJoNQvS7KwW5rQyASjh9lDmlI4QIwTdHLcbSxjG6GJN9IPRLBLI8JXT9/dVLCPP oWhw7HOS3qWZZhYx2nCEo5UGJAqTAfa3oF8uVbM6oxnc8U9xhZSVZOQ2jKm4kTIAIiRFUY A21dS7z4wy3/PAj3hUkbsg72pKS52Os= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=yGw6sWaI; spf=none (imf27.hostedemail.com: domain of BATV+3c9dadc9e27e1b9c7a6f+6953+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c9dadc9e27e1b9c7a6f+6953+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662446186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kFNZmmVwOhX3BjOPJ3tln3iTlg4hrSY3aWoS1Dwfdhg=; b=eo8HBTQaG27+7TOe7IhYCtWZkISxnXvs/LaioqqDSbo803ZB1VQfNSjUOwEkpfbKbab625 GHgA70k23TW+20VCVbAow1O88jj1afaV0aJWe2zoe/sAFHJj9B7GVnMgBdPAbVyaqEcBv+ PKX83Vy6EGX6UpI166MwIjjNwtjbLo8= Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=yGw6sWaI; spf=none (imf27.hostedemail.com: domain of BATV+3c9dadc9e27e1b9c7a6f+6953+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3c9dadc9e27e1b9c7a6f+6953+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6B18B400B0 X-Stat-Signature: ti5xosu5r6zuaof5ax1hh3sjofskufew X-Rspam-User: X-HE-Tag: 1662446185-521837 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 30, 2022 at 09:18:36PM -0700, John Hubbard wrote: > The conversion is temporarily guarded by > CONFIG_BLK_USE_PIN_USER_PAGES_FOR_DIO. In the future (not part of this > series), when we are certain that all filesystems have converted their > Direct IO paths to FOLL_PIN, then we can do the final step, which is to > get rid of CONFIG_BLK_USE_PIN_USER_PAGES_FOR_DIO and search-and-replace > the dio_w_*() functions with their final names (see bvec.h changes). What is the the point of these wrappers? We should be able to convert one caller at a time in an entirely safe way.