From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10FDEC54EE9 for ; Thu, 8 Sep 2022 20:34:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 794A86B0072; Thu, 8 Sep 2022 16:34:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71C0D8D0002; Thu, 8 Sep 2022 16:34:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 595A76B0074; Thu, 8 Sep 2022 16:34:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 49E8F6B0072 for ; Thu, 8 Sep 2022 16:34:17 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1F780160439 for ; Thu, 8 Sep 2022 20:34:17 +0000 (UTC) X-FDA: 79890070554.19.D1FF7E7 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf22.hostedemail.com (Postfix) with ESMTP id 9BF08C009C for ; Thu, 8 Sep 2022 20:34:16 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B0046B82246; Thu, 8 Sep 2022 20:34:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED387C433D7; Thu, 8 Sep 2022 20:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662669253; bh=xznb1RKBZH/nj2qdZlu+dotoTsJWwyQbwBXQt70aXfQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aV+WCP9SeYQN9/uvhmG0jzovy09Muqg0xuGb1GoH0fy5inl2zw+gC/19rPaudjVTv Qo4D2iAs145mScERTpLbx1ipWCp42F1k/TmKYdEy0zVX8N2TouAtODomu711xjWyyD r9zQKKZ27c8aU4m3/zaqB9d16l6a5SYVEuT/4IV/FCkJUxcUY0YgLo8BJCuW6f9VQX SB8uDzPG7QdXAZeSI7QoeSMtFbkxk8pQEpN/3ZBzrva2lAA61x0+Ohiq6EBiMBLKOe nujTj0rT4LvIcE38NM7aHZJ+TkhKsXHyavZoABrPJK+f/GAXRulwXDrepG26zyYclo zR1K6o6wyldXw== Date: Thu, 8 Sep 2022 23:34:07 +0300 From: Jarkko Sakkinen To: Sean Christopherson Cc: Harald Hoyer , ashish.kalra@amd.com, ak@linux.intel.com, alpergun@google.com, ardb@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, dgilbert@redhat.com, dovmurik@linux.ibm.com, hpa@zytor.com, jmattson@google.com, jroedel@suse.de, kirill@shutemov.name, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, marcorr@google.com, michael.roth@amd.com, mingo@redhat.com, pbonzini@redhat.com, peterz@infradead.org, pgonda@google.com, rientjes@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, slp@redhat.com, srinivas.pandruvada@linux.intel.com, tglx@linutronix.de, thomas.lendacky@amd.com, tobin@ibm.com, tony.luck@intel.com, vbabka@suse.cz, vkuznets@redhat.com, x86@kernel.org Subject: Re: [[PATCH for v6]] KVM: SEV: fix snp_launch_finish Message-ID: References: <6a513cf79bf71c479dbd72165faf1d804d77b3af.1655761627.git.ashish.kalra@amd.com> <20220908145557.1912158-1-harald@profian.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aV+WCP9S; spf=pass (imf22.hostedemail.com: domain of jarkko@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662669256; a=rsa-sha256; cv=none; b=wTqCKpsDdp4hOwSkn5UtY+jnLrJsZjozTI+pRG76iKsWkiKZywamzgpdaVUXWZKqryjngE a33bIAbX9b1koN/DyLEPC0cvz+SoFLxI5k5C39nXatbR3SdjNAQnHHJ/gOWi4/SX8JqZJl 2DA9BP6sMqvjDwmaxnYbIQiKVSUbQNQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662669256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EkmENdDsgtQ5hm8Fh05fzVYqt9HZRa2z6s00QOTGVWo=; b=bIRb3tTL2wb+Xz+S6ml45igpPefz1EWGLz0iACRYkQiVUamPOU/RAGi0dLAM3bpAYpYl0p Yx7vp1K5aBk6hlBXSXxqUpvaZGj/u79SFZORHp7w2dlRHHDp/FX0pkAZe71lcgSROBJuYt 4qcwNED26RCsCi1oeYrEESgVLcrqtIA= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9BF08C009C Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aV+WCP9S; spf=pass (imf22.hostedemail.com: domain of jarkko@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: ddinxkf5foiwrt8n9sd8om7i9oh8ijjh X-Rspam-User: X-HE-Tag: 1662669256-743560 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 08, 2022 at 03:11:30PM +0000, Sean Christopherson wrote: > On Thu, Sep 08, 2022, Harald Hoyer wrote: > > The `params.auth_key_en` indicator does _not_ specify, whether an > > ID_AUTH struct should be sent or not, but, wheter the ID_AUTH struct > > contains an author key or not. The firmware always expects an ID_AUTH block. > > > > Link: https://lore.kernel.org/all/cover.1655761627.git.ashish.kalra@amd.com/ > > Please provide feedback by directly responding to whatever patch/email is buggy. > Or if that's too complicated for some reason (unlikely in this case), provide the > fixup patch to the author *off-list*. I'd guess that'd be: https://lore.kernel.org/all/6a513cf79bf71c479dbd72165faf1d804d77b3af.1655761627.git.ashish.kalra@amd.com/ BR, Jarkko