From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B9FFECAAD3 for ; Fri, 9 Sep 2022 19:37:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD2BD8D0002; Fri, 9 Sep 2022 15:37:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A82298D0001; Fri, 9 Sep 2022 15:37:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97E628D0002; Fri, 9 Sep 2022 15:37:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 894768D0001 for ; Fri, 9 Sep 2022 15:37:37 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5806180461 for ; Fri, 9 Sep 2022 19:37:37 +0000 (UTC) X-FDA: 79893556554.10.85C9FB0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 43D4620083 for ; Fri, 9 Sep 2022 19:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kpoKyQoV4q4nCI29fW8HhVgzf02UIWYkeQLeEr7DdCc=; b=nwfYVX1GzyoWxH8Fna2Ws7mr26 5B4gbZ5Z45mgPdt8mUSRmXvcKite7R6kmdjRcT7RwYuft+HvZEc9HGCxZB1KU3iGWi30+jK+v4Gd1 BgRajWnmLpL5+HlPGIOFrBtQIhGvfcLaNdPTbWo8lYkA8tRdCIVu8h2i0M/sGuk+M08dCYAgHaE2S kJ68VVJrBkTA5/86h8LFh+sOeteYXduocPK5IGHoMDexELGF62bNJJKKRadmXgAvwJsSu3pjnc1uD mQwM5Jof8mXtuHXtAMesy5J75dO7bCiHx7bXTxnKaDqUFns2xXZRqFwL8QyPit/z7VkMWAyhWnfqQ +E490VfQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWjod-00DVvN-8Y; Fri, 09 Sep 2022 19:37:27 +0000 Date: Fri, 9 Sep 2022 20:37:27 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, david@redhat.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/16] mm: remove obsolete macro NR_PCP_ORDER_MASK Message-ID: References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-4-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909092451.24883-4-linmiaohe@huawei.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662752257; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kpoKyQoV4q4nCI29fW8HhVgzf02UIWYkeQLeEr7DdCc=; b=EUNFn3WZUexvpIrlYVxcc5ZrXvsIl8Re8jf3nZ5k1i/NVT+0SkuvMtgGEG38Ykkdo9R6UA 4tyVeRhlF6SnJHGfj+KWM056YOwKV56qP/ZS1P3RkPGEp79dDYdb8MdkZXaE+58K02ZZaE xJ9wO5hkvwOeFIJkhTg7PR61PxSdEaA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nwfYVX1G; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662752257; a=rsa-sha256; cv=none; b=kvx8HZxNB3licKRC2CElN4mIAacpeEy8rCF2TC/4V8zqabUJtASedzmy9XUwdwGuBSeYm2 re8QAcpiG7T0ce5fSolYPmRrPfBJB00y+tjkJfNjw31QPv9t27/9O+Iqu1FQUg+mwnCo/H vl63HAxMqFNUqzMCPJvAXySzgGj6lb0= X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nwfYVX1G; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam06 X-Stat-Signature: 1rosbkih81z7j3ujzqhimjbc5tinez3u X-Rspamd-Queue-Id: 43D4620083 X-HE-Tag: 1662752256-944716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 09, 2022 at 05:24:38PM +0800, Miaohe Lin wrote: > Since commit 8b10b465d0e1 ("mm/page_alloc: free pages in a single pass > during bulk free"), it's not used anymore. Remove it. Yes, but this patch needs to go further. The comment is no longer true (after the patch you mention), so need to also delete these lines: -/* - * Shift to encode migratetype and order in the same integer, with order - * in the least significant bits. - */ -#define NR_PCP_ORDER_WIDTH 8 and the line: - BUILD_BUG_ON(MAX_ORDER >= (1<