From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22E41ECAAD8 for ; Wed, 14 Sep 2022 07:35:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADD4F6B0071; Wed, 14 Sep 2022 03:35:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8BB26B0073; Wed, 14 Sep 2022 03:35:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97A768D0001; Wed, 14 Sep 2022 03:35:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 881E76B0071 for ; Wed, 14 Sep 2022 03:35:51 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4213680930 for ; Wed, 14 Sep 2022 07:35:49 +0000 (UTC) X-FDA: 79909881618.28.0A87D5C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 2B17A1000A9 for ; Wed, 14 Sep 2022 07:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AhzMBhpxQIZGzblSGXJmT/FAJ97HThQ7oI5AhNR6LBA=; b=vz/ydC4NUg3N/inWnCZZctr8BL 32yXu7cj0sdBK0ASYgQBmfeVlIDmIY2a/snafAqAM/BegoJgmMuq+a5wZ+MxSUqowSPx3kAUm8X8X kTosJJ//e1HTAFzap9kGN6tgkPNkBbXaM+WtNrHBIMyPljRtrFUS/5io4SNzyAHuRDmu8vBUGEjzk Gdgd39DQXxJalyDDpJEWcr4NVrLrUI4sS6PVa+E2jnjgBtr2sf7Xp4NZ0a3Oc3JnEcazcce8605xm DsEqicg4aWMehheYgkkuU8Yxao4bWgK/KhZJgeDsVkJs9tCLexX9/J4K2ZPJoU/xSSzRZDnhU319z ivpKtKcA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYMvo-00HZr5-SM; Wed, 14 Sep 2022 07:35:36 +0000 Date: Wed, 14 Sep 2022 08:35:36 +0100 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , Catalin Marinas , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [PATCH 1/2] mm: fix logic error of page_expected_state Message-ID: References: <1663126621-26926-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1663126621-26926-1-git-send-email-zhaoyang.huang@unisoc.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663140949; a=rsa-sha256; cv=none; b=qes2PBBJDR/kUFaUEDwgEqHaOiny4VnEbCDZ4W6N6YSNYOCwLCH/kw/s3t4UBdnPDY8bAv h7U/DLY/AyuhVmzMKXTmbbsgzsIfcjyoJ/NhSGNoehRgy0AINw1uTpS/Cuh1LBavo9MKkf nrM9bxYnDoxr0FVaM8OUI8KY7l9RB7I= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="vz/ydC4N"; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663140949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AhzMBhpxQIZGzblSGXJmT/FAJ97HThQ7oI5AhNR6LBA=; b=N/bkZJsm3WtYrizzJYoGeF9oXOt12rSXyxEvLh1tuaDKwZXu4EUm8cnm3vmikUfP4bGrb6 ZrwlyavRPDc2sXdltelJdaOfOmzVnaDb2ApsIkZa5SozL/roWZ64+RuzcXLpljrPaD0mRH gnEKAHTrIURiSbkyd/aox60ffh2qHKM= X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="vz/ydC4N"; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam11 X-Stat-Signature: 7dyn6i9x7fa49ctmrswu7w1sbfu73k8e X-Rspamd-Queue-Id: 2B17A1000A9 X-HE-Tag: 1663140948-79952 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 14, 2022 at 11:37:00AM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > The page with special page type will be deemed as bad page wrongly since > type share the same address with mapcount. That's not wrongly. You didn't clear the bit. I told you you would need to do that in the first version of the patch you sent.