From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BAB2ECAAA1 for ; Thu, 15 Sep 2022 04:24:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55B466B0071; Thu, 15 Sep 2022 00:24:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50AA66B0073; Thu, 15 Sep 2022 00:24:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D25D8D0001; Thu, 15 Sep 2022 00:24:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2E3926B0071 for ; Thu, 15 Sep 2022 00:24:46 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 09FC780C41 for ; Thu, 15 Sep 2022 04:24:46 +0000 (UTC) X-FDA: 79913028972.25.3EBD64B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf25.hostedemail.com (Postfix) with ESMTP id 93135A00CB for ; Thu, 15 Sep 2022 04:24:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1F43D34234; Thu, 15 Sep 2022 04:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663215884; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rp2hb7jsVkIpo1uaIkf2AqZV7igkV0nPtVBey4vQ3iA=; b=heSGgyWHzuf3rMoxxqD2XF0OwMvMrOesmZZaVvvPtZ3cxmqQQMI3AHyJ65Sk5SdK9iPLka zZ2V85Ei9YcD44YLDVhzdz0JN7ixC0FS4ov5fdk8PInEo4rOqZG0SjZZKhuio317HI/Bzh ts9TyxzYSVnBjMyvLuvIx7bdIl6QYRE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663215884; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rp2hb7jsVkIpo1uaIkf2AqZV7igkV0nPtVBey4vQ3iA=; b=V7JIYzWAv7lP7/23sPcdYKdxyOxAIlqEZGrIoKT4zXukt6sMBBsM/mQ1b6xzjCAb7QNopS HfxwHUoFtxyIeHAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A248D139C8; Thu, 15 Sep 2022 04:24:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HVX4JAupImMkJgAAMHmgww (envelope-from ); Thu, 15 Sep 2022 04:24:43 +0000 Date: Thu, 15 Sep 2022 06:24:41 +0200 From: Oscar Salvador To: Doug Berger Cc: Mike Kravetz , Muchun Song , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm/hugetlb: correct demote page offset logic Message-ID: References: <20220914190917.3517663-1-opendmb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220914190917.3517663-1-opendmb@gmail.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663215885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rp2hb7jsVkIpo1uaIkf2AqZV7igkV0nPtVBey4vQ3iA=; b=65dxavDXPUD9PKUYbyUK0VciDMCu39SRIin12rPJ665MdwlCXhg6jf/Lk653jGRt4u2Tf3 E6YRlbQCbEfPCMFmH++xhpjOHFLwON9OJTK88goiVQtipx9+RI9bc8e+oGjB4RttNDeIzs qcRyo5zYw+FslWz0wXdgfnv3POCXJGY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=heSGgyWH; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=V7JIYzWA; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663215885; a=rsa-sha256; cv=none; b=gFqKB6CAM7RPSibZxIJlyaaMr9oe9kSWEaRKHqzn3aJj1yga/s0nAX8Cj7Kw8dAQuIypAf TI8rj3kjh1GtvCryjrkRf3E8XN9HI0Yixkm4tYEOftFchdFqAPNBP/33bD8cvYq2Ii2zTU /9DOwx5dRAvm+XgAL7ZA2JH0v1K1Bpo= Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=heSGgyWH; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=V7JIYzWA; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: fdsfwdf5hiczwr7y7dhzs3aukdisdctn X-Rspamd-Queue-Id: 93135A00CB X-HE-Tag: 1663215885-43855 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 14, 2022 at 12:09:17PM -0700, Doug Berger wrote: > With gigantic pages it may not be true that struct page structures > are contiguous across the entire gigantic page. The nth_page macro > is used here in place of direct pointer arithmetic to correct for > this. > > Fixes: 8531fc6f52f5 ("hugetlb: add hugetlb demote page support") > Signed-off-by: Doug Berger > Cc: Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs