From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 917CEECAAD3 for ; Thu, 15 Sep 2022 04:53:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20B768D0002; Thu, 15 Sep 2022 00:53:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BAE98D0001; Thu, 15 Sep 2022 00:53:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 082DB8D0002; Thu, 15 Sep 2022 00:53:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E93F58D0001 for ; Thu, 15 Sep 2022 00:53:18 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BFFCC120652 for ; Thu, 15 Sep 2022 04:53:18 +0000 (UTC) X-FDA: 79913100876.26.5A395FA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf12.hostedemail.com (Postfix) with ESMTP id 5FD9B400B9 for ; Thu, 15 Sep 2022 04:53:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 49B1C1FA8D; Thu, 15 Sep 2022 04:53:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663217597; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yp5m+Hr4qr576DrNyvsj++WSaXFTSF+h11ngNHuL2BQ=; b=U9tQsEykO643mz8CIF4D/QKjHaYSxvUbY7HdEx2WcICL35fHPsC7EAXDYeqK4xLbSGB1yE kAeSIUby5ut42I2vD3cCaihSrFQQj8mom0gIug9q3Avvyvu33dbSp9fyBJkYBaDn+VPLAw uge1cXgJrJpnSpJfT4qTTVDAZsULxE0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663217597; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yp5m+Hr4qr576DrNyvsj++WSaXFTSF+h11ngNHuL2BQ=; b=4dgn8pcX5wftxBjmHtDN0caGySjEY6HnCta3HnPGzfxRParnxyd+WK0s0NiHAhmTy/2FHv tafEOTCmjkmi27Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E720E139B3; Thu, 15 Sep 2022 04:53:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dlKwNbyvImN5LQAAMHmgww (envelope-from ); Thu, 15 Sep 2022 04:53:16 +0000 Date: Thu, 15 Sep 2022 06:53:15 +0200 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/16] mm/page_alloc: fix freeing static percpu memory Message-ID: References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-7-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909092451.24883-7-linmiaohe@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663217598; a=rsa-sha256; cv=none; b=L8gzPEziiEexWkwmDlz5sOgWAiIgf3svAOGzHb7C5gjh05wtN1EPk+AjCu9gTVhm6RaGFb nDPHASHNOAaR9y8fQQnHpxKJ6xq9g+cgCYHZGYZQy0u9EFwiDRpDwCYf24Bl1SocEHsqCV +2mC2MoFtO1sUndSiW2/iQuTCVMgq/M= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=U9tQsEyk; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4dgn8pcX; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663217598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yp5m+Hr4qr576DrNyvsj++WSaXFTSF+h11ngNHuL2BQ=; b=52f9aeqzUB0mVydj/qJY4N11SrHlTE9RBjhOk9+f3PC1laoXuNnDzS+zCCTPdD+jTkEyQC wFKmIM1mFXQturMumsfBxCKOESYJFkF+1rRpCTGoGh5hkHtI7Crsc0dtRx10WLB4mZrMBr MQTlutvn7TZyQe7Qs7aQRorUe4MrpjQ= X-Stat-Signature: 5sgtmmkakt15kim1pfsgoumt7i3syto1 X-Rspamd-Queue-Id: 5FD9B400B9 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=U9tQsEyk; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4dgn8pcX; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspamd-Server: rspam02 X-HE-Tag: 1663217598-998773 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 09, 2022 at 05:24:41PM +0800, Miaohe Lin wrote: > The size of struct per_cpu_zonestat can be 0 on !SMP && !NUMA. In that > case, zone->per_cpu_zonestats will always equal to boot_zonestats. But > in zone_pcp_reset(), zone->per_cpu_zonestats is freed via free_percpu() > directly without checking against boot_zonestats first. boot_zonestats > will be released by free_percpu() unexpectedly. > > Fixes: 28f836b6777b ("mm/page_alloc: split per cpu page lists and zone stats") > Signed-off-by: Miaohe Lin Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs