* Re: [PATCH] mm/filemap: Make folio_put_wait_locked static
[not found] <20220914015836.3193197-1-sunke@kylinos.cn>
@ 2022-09-15 0:45 ` Ke Sun
2022-09-15 7:30 ` Matthew Wilcox
0 siblings, 1 reply; 4+ messages in thread
From: Ke Sun @ 2022-09-15 0:45 UTC (permalink / raw)
To: Matthew Wilcox, Andrew Morton; +Cc: linux-mm, linux-kernel, k2ci, linux-fsdevel
Ping.
On 2022/9/14 09:58, Ke Sun wrote:
> It's only used in mm/filemap.c, since commit <ffa65753c431>
> ("mm/migrate.c: rework migration_entry_wait() to not take a pageref").
>
> Make it static.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Ke Sun <sunke@kylinos.cn>
> ---
> include/linux/pagemap.h | 1 -
> mm/filemap.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index 0178b2040ea3..82880993dd1a 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -1042,7 +1042,6 @@ static inline int
> wait_on_page_locked_killable(struct page *page)
> return folio_wait_locked_killable(page_folio(page));
> }
> -int folio_put_wait_locked(struct folio *folio, int state);
> void wait_on_page_writeback(struct page *page);
> void folio_wait_writeback(struct folio *folio);
> int folio_wait_writeback_killable(struct folio *folio);
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 15800334147b..ade9b7bfe7fc 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -1467,7 +1467,7 @@ EXPORT_SYMBOL(folio_wait_bit_killable);
> *
> * Return: 0 if the folio was unlocked or -EINTR if interrupted by a
> signal.
> */
> -int folio_put_wait_locked(struct folio *folio, int state)
> +static int folio_put_wait_locked(struct folio *folio, int state)
> {
> return folio_wait_bit_common(folio, PG_locked, state, DROP);
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm/filemap: Make folio_put_wait_locked static
2022-09-15 0:45 ` [PATCH] mm/filemap: Make folio_put_wait_locked static Ke Sun
@ 2022-09-15 7:30 ` Matthew Wilcox
2022-09-15 8:59 ` Ke Sun
0 siblings, 1 reply; 4+ messages in thread
From: Matthew Wilcox @ 2022-09-15 7:30 UTC (permalink / raw)
To: Ke Sun; +Cc: Andrew Morton, linux-mm, linux-kernel, k2ci, linux-fsdevel
On Thu, Sep 15, 2022 at 08:45:33AM +0800, Ke Sun wrote:
> Ping.
Don't be rude. I'm at a conference this week and on holiday next week.
This is hardly an urgent patch.
> On 2022/9/14 09:58, Ke Sun wrote:
> > It's only used in mm/filemap.c, since commit <ffa65753c431>
> > ("mm/migrate.c: rework migration_entry_wait() to not take a pageref").
> >
> > Make it static.
> >
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: linux-mm@kvack.org
> > Cc: linux-kernel@vger.kernel.org
> > Reported-by: k2ci <kernel-bot@kylinos.cn>
> > Signed-off-by: Ke Sun <sunke@kylinos.cn>
> > ---
> > include/linux/pagemap.h | 1 -
> > mm/filemap.c | 2 +-
> > 2 files changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> > index 0178b2040ea3..82880993dd1a 100644
> > --- a/include/linux/pagemap.h
> > +++ b/include/linux/pagemap.h
> > @@ -1042,7 +1042,6 @@ static inline int
> > wait_on_page_locked_killable(struct page *page)
> > return folio_wait_locked_killable(page_folio(page));
> > }
> > -int folio_put_wait_locked(struct folio *folio, int state);
> > void wait_on_page_writeback(struct page *page);
> > void folio_wait_writeback(struct folio *folio);
> > int folio_wait_writeback_killable(struct folio *folio);
> > diff --git a/mm/filemap.c b/mm/filemap.c
> > index 15800334147b..ade9b7bfe7fc 100644
> > --- a/mm/filemap.c
> > +++ b/mm/filemap.c
> > @@ -1467,7 +1467,7 @@ EXPORT_SYMBOL(folio_wait_bit_killable);
> > *
> > * Return: 0 if the folio was unlocked or -EINTR if interrupted by a
> > signal.
> > */
> > -int folio_put_wait_locked(struct folio *folio, int state)
> > +static int folio_put_wait_locked(struct folio *folio, int state)
> > {
> > return folio_wait_bit_common(folio, PG_locked, state, DROP);
> > }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm/filemap: Make folio_put_wait_locked static
2022-09-15 7:30 ` Matthew Wilcox
@ 2022-09-15 8:59 ` Ke Sun
0 siblings, 0 replies; 4+ messages in thread
From: Ke Sun @ 2022-09-15 8:59 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: Andrew Morton, linux-mm, linux-kernel, k2ci, linux-fsdevel
On 2022/9/15 15:30, Matthew Wilcox wrote:
> On Thu, Sep 15, 2022 at 08:45:33AM +0800, Ke Sun wrote:
>> Ping.
> Don't be rude. I'm at a conference this week and on holiday next week.
> This is hardly an urgent patch.
So sorry to bother you. Some duplicate emails were sent due to issues
with mailbox app settings.
>> On 2022/9/14 09:58, Ke Sun wrote:
>>> It's only used in mm/filemap.c, since commit <ffa65753c431>
>>> ("mm/migrate.c: rework migration_entry_wait() to not take a pageref").
>>>
>>> Make it static.
>>>
>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>> Cc: linux-mm@kvack.org
>>> Cc: linux-kernel@vger.kernel.org
>>> Reported-by: k2ci <kernel-bot@kylinos.cn>
>>> Signed-off-by: Ke Sun <sunke@kylinos.cn>
>>> ---
>>> include/linux/pagemap.h | 1 -
>>> mm/filemap.c | 2 +-
>>> 2 files changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
>>> index 0178b2040ea3..82880993dd1a 100644
>>> --- a/include/linux/pagemap.h
>>> +++ b/include/linux/pagemap.h
>>> @@ -1042,7 +1042,6 @@ static inline int
>>> wait_on_page_locked_killable(struct page *page)
>>> return folio_wait_locked_killable(page_folio(page));
>>> }
>>> -int folio_put_wait_locked(struct folio *folio, int state);
>>> void wait_on_page_writeback(struct page *page);
>>> void folio_wait_writeback(struct folio *folio);
>>> int folio_wait_writeback_killable(struct folio *folio);
>>> diff --git a/mm/filemap.c b/mm/filemap.c
>>> index 15800334147b..ade9b7bfe7fc 100644
>>> --- a/mm/filemap.c
>>> +++ b/mm/filemap.c
>>> @@ -1467,7 +1467,7 @@ EXPORT_SYMBOL(folio_wait_bit_killable);
>>> *
>>> * Return: 0 if the folio was unlocked or -EINTR if interrupted by a
>>> signal.
>>> */
>>> -int folio_put_wait_locked(struct folio *folio, int state)
>>> +static int folio_put_wait_locked(struct folio *folio, int state)
>>> {
>>> return folio_wait_bit_common(folio, PG_locked, state, DROP);
>>> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mm/filemap: Make folio_put_wait_locked static
@ 2022-09-14 2:17 Ke Sun
0 siblings, 0 replies; 4+ messages in thread
From: Ke Sun @ 2022-09-14 2:17 UTC (permalink / raw)
To: Matthew Wilcox, Andrew Morton; +Cc: Ke Sun, linux-mm, linux-kernel, k2ci
It's only used in mm/filemap.c, since commit <ffa65753c431>
("mm/migrate.c: rework migration_entry_wait() to not take a pageref").
Make it static.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: Ke Sun <sunke@kylinos.cn>
---
include/linux/pagemap.h | 1 -
mm/filemap.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index 0178b2040ea3..82880993dd1a 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -1042,7 +1042,6 @@ static inline int wait_on_page_locked_killable(struct page *page)
return folio_wait_locked_killable(page_folio(page));
}
-int folio_put_wait_locked(struct folio *folio, int state);
void wait_on_page_writeback(struct page *page);
void folio_wait_writeback(struct folio *folio);
int folio_wait_writeback_killable(struct folio *folio);
diff --git a/mm/filemap.c b/mm/filemap.c
index 15800334147b..ade9b7bfe7fc 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1467,7 +1467,7 @@ EXPORT_SYMBOL(folio_wait_bit_killable);
*
* Return: 0 if the folio was unlocked or -EINTR if interrupted by a signal.
*/
-int folio_put_wait_locked(struct folio *folio, int state)
+static int folio_put_wait_locked(struct folio *folio, int state)
{
return folio_wait_bit_common(folio, PG_locked, state, DROP);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-15 8:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220914015836.3193197-1-sunke@kylinos.cn>
2022-09-15 0:45 ` [PATCH] mm/filemap: Make folio_put_wait_locked static Ke Sun
2022-09-15 7:30 ` Matthew Wilcox
2022-09-15 8:59 ` Ke Sun
2022-09-14 2:17 Ke Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).