From: Oscar Salvador <osalvador@suse.de>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/16] mm, memory_hotplug: remove obsolete generic_free_nodedata()
Date: Thu, 15 Sep 2022 09:37:20 +0200 [thread overview]
Message-ID: <YyLWMDetsofyz6Y+@localhost.localdomain> (raw)
In-Reply-To: <20220909092451.24883-11-linmiaohe@huawei.com>
On Fri, Sep 09, 2022 at 05:24:45PM +0800, Miaohe Lin wrote:
> Commit 390511e1476e ("mm, memory_hotplug: drop arch_free_nodedata")
> drops the last caller of generic_free_nodedata(). Remove it too.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
> ---
> include/linux/memory_hotplug.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
> index 51052969dbfe..9fcbf5706595 100644
> --- a/include/linux/memory_hotplug.h
> +++ b/include/linux/memory_hotplug.h
> @@ -43,11 +43,6 @@ extern void arch_refresh_nodedata(int nid, pg_data_t *pgdat);
> ({ \
> memblock_alloc(sizeof(*pgdat), SMP_CACHE_BYTES); \
> })
> -/*
> - * This definition is just for error path in node hotadd.
> - * For node hotremove, we have to replace this.
> - */
> -#define generic_free_nodedata(pgdat) kfree(pgdat)
>
> extern pg_data_t *node_data[];
> static inline void arch_refresh_nodedata(int nid, pg_data_t *pgdat)
> @@ -63,9 +58,6 @@ static inline pg_data_t *generic_alloc_nodedata(int nid)
> BUG();
> return NULL;
> }
> -static inline void generic_free_nodedata(pg_data_t *pgdat)
> -{
> -}
> static inline void arch_refresh_nodedata(int nid, pg_data_t *pgdat)
> {
> }
> --
> 2.23.0
>
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2022-09-15 7:37 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 9:24 [PATCH 00/16] A few cleanup patches for mm Miaohe Lin
2022-09-09 9:24 ` [PATCH 01/16] mm/page_alloc: ensure kswapd doesn't accidentally go to sleep Miaohe Lin
2022-09-09 11:39 ` David Hildenbrand
2022-09-13 7:02 ` Anshuman Khandual
2022-09-13 7:58 ` Matthew Wilcox
2022-09-13 11:23 ` Anshuman Khandual
2022-09-15 4:34 ` Oscar Salvador
2022-09-09 9:24 ` [PATCH 02/16] mm/page_alloc: make zone_pcp_update() static Miaohe Lin
2022-09-09 11:26 ` David Hildenbrand
2022-09-13 7:58 ` Anshuman Khandual
2022-09-15 4:41 ` Oscar Salvador
2022-09-09 9:24 ` [PATCH 03/16] mm: remove obsolete macro NR_PCP_ORDER_MASK Miaohe Lin
2022-09-09 11:26 ` David Hildenbrand
2022-09-09 19:37 ` Matthew Wilcox
2022-09-13 3:14 ` Miaohe Lin
2022-09-13 8:03 ` Anshuman Khandual
2022-09-15 4:44 ` Oscar Salvador
2022-09-09 9:24 ` [PATCH 04/16] mm/page_alloc: remove obsolete comment in zone_statistics() Miaohe Lin
2022-09-09 11:27 ` David Hildenbrand
2022-09-13 8:15 ` Anshuman Khandual
2022-09-15 4:47 ` Oscar Salvador
2022-09-09 9:24 ` [PATCH 05/16] mm/page_alloc: add __init annotations to init_mem_debugging_and_hardening() Miaohe Lin
2022-09-09 11:27 ` David Hildenbrand
2022-09-13 8:20 ` Anshuman Khandual
2022-09-15 4:49 ` Oscar Salvador
2022-09-09 9:24 ` [PATCH 06/16] mm/page_alloc: fix freeing static percpu memory Miaohe Lin
2022-09-09 11:28 ` David Hildenbrand
2022-09-15 4:53 ` Oscar Salvador
2022-09-09 9:24 ` [PATCH 07/16] mm: remove obsolete pgdat_is_empty() Miaohe Lin
2022-09-09 11:28 ` David Hildenbrand
2022-09-13 8:43 ` Anshuman Khandual
2022-09-15 4:55 ` Oscar Salvador
2022-09-09 9:24 ` [PATCH 08/16] mm/page_alloc: add missing is_migrate_isolate() check in set_page_guard() Miaohe Lin
2022-09-09 11:31 ` David Hildenbrand
2022-09-13 6:51 ` Miaohe Lin
2022-09-15 7:26 ` Oscar Salvador
2022-09-15 8:11 ` Miaohe Lin
2022-09-09 9:24 ` [PATCH 09/16] mm/page_alloc: use local variable zone_idx directly Miaohe Lin
2022-09-09 11:31 ` David Hildenbrand
2022-09-13 8:49 ` Anshuman Khandual
2022-09-15 7:36 ` Oscar Salvador
2022-09-15 8:06 ` Miaohe Lin
2022-09-09 9:24 ` [PATCH 10/16] mm, memory_hotplug: remove obsolete generic_free_nodedata() Miaohe Lin
2022-09-09 11:32 ` David Hildenbrand
2022-09-13 8:57 ` Anshuman Khandual
2022-09-15 7:37 ` Oscar Salvador [this message]
2022-09-09 9:24 ` [PATCH 11/16] mm/page_alloc: make boot_nodestats static Miaohe Lin
2022-09-09 11:32 ` David Hildenbrand
2022-09-13 9:00 ` Anshuman Khandual
2022-09-15 7:38 ` Oscar Salvador
2022-09-09 9:24 ` [PATCH 12/16] mm/page_alloc: use helper macro SZ_1{K,M} Miaohe Lin
2022-09-09 11:34 ` David Hildenbrand
2022-09-09 19:44 ` Matthew Wilcox
2022-09-13 7:04 ` Miaohe Lin
2022-09-09 9:24 ` [PATCH 13/16] mm/page_alloc: init local variable buddy_pfn Miaohe Lin
2022-09-09 11:36 ` David Hildenbrand
2022-09-13 9:06 ` Anshuman Khandual
2022-09-15 7:42 ` Oscar Salvador
2022-09-09 9:24 ` [PATCH 14/16] mm/page_alloc: use costly_order in WARN_ON_ONCE_GFP() Miaohe Lin
2022-09-09 11:37 ` David Hildenbrand
2022-09-13 9:08 ` Anshuman Khandual
2022-09-15 7:45 ` Oscar Salvador
2022-09-09 9:24 ` [PATCH 15/16] mm/page_alloc: remove obsolete gfpflags_normal_context() Miaohe Lin
2022-09-09 11:37 ` David Hildenbrand
2022-09-13 11:12 ` Anshuman Khandual
2022-09-13 11:13 ` Anshuman Khandual
2022-09-15 7:48 ` Oscar Salvador
2022-09-09 9:24 ` [PATCH 16/16] mm/page_alloc: fix obsolete comment in deferred_pfn_valid() Miaohe Lin
2022-09-09 11:25 ` David Hildenbrand
2022-09-13 11:17 ` Anshuman Khandual
2022-09-15 7:50 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyLWMDetsofyz6Y+@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).