From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64CC1ECAAD3 for ; Thu, 15 Sep 2022 07:37:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E56836B0071; Thu, 15 Sep 2022 03:37:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E062A8D0002; Thu, 15 Sep 2022 03:37:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCF048D0001; Thu, 15 Sep 2022 03:37:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BF16E6B0071 for ; Thu, 15 Sep 2022 03:37:23 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9B54BAA6DF for ; Thu, 15 Sep 2022 07:37:23 +0000 (UTC) X-FDA: 79913514366.29.27C3BBD Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id 2DDB4400A4 for ; Thu, 15 Sep 2022 07:37:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 24FC55CE7D; Thu, 15 Sep 2022 07:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663227442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Cck5aBNQb2HmTYWLTPEzJu3AnzbBNC8yc9w8Epo2kqs=; b=zGypcOTPxg8BXInKkII5AlBxd5gie0n5BVsH/6mjIp4Cl2yqxIhgK0wvy9ktguIeifIVE3 iVeS8C7Jh3I6WpxBk69qT9MxkxjMgJBtz10td6aWcxIU9NWHJw6dQ+bELJVjFYjkFxQkbd ffpRmdJ7v9Kv2zkGRRDOWeOuA983XCA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663227442; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Cck5aBNQb2HmTYWLTPEzJu3AnzbBNC8yc9w8Epo2kqs=; b=SqYiZwAhWSJl8lgozLelF3kW3xTF1wBs0g063z8lxcGVYkl+JlsZVftM98pq025qvUqnQF Cs9lpdLKkOKVf1Ag== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C3993133A7; Thu, 15 Sep 2022 07:37:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qH8KLTHWImPDZQAAMHmgww (envelope-from ); Thu, 15 Sep 2022 07:37:21 +0000 Date: Thu, 15 Sep 2022 09:37:20 +0200 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/16] mm, memory_hotplug: remove obsolete generic_free_nodedata() Message-ID: References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-11-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909092451.24883-11-linmiaohe@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663227443; a=rsa-sha256; cv=none; b=e5TeSXyuBtoSGxH+l+1ukstcF/Y1/bfag4jbYslp9hkdHw30DlNfUaDaBbDQjbczFXC9T7 c4QQjj8j/m68lc2B1U4G4bUzUMOIp6+r2be/ERmH5NTII8mPC+s2rolaHL6KgZt/zEWZpi j/6C8V1TQt59UBpU9AitdqI54P97wxI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zGypcOTP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SqYiZwAh; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663227443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cck5aBNQb2HmTYWLTPEzJu3AnzbBNC8yc9w8Epo2kqs=; b=V90MDe8XodAu3xw20X+g6d/lKJrDYgEKnpsvZ6QA3QjSYLt2W1V6bpjyuKe2ijpc4y8Ya7 Vz6pQmLxrNDkAbU0l3otxJ4Zs6fF3lPrxPKY3y/IAitPk6Qgo2MxeGDyyHdpV4eUzsE4X7 zwaCRJgLlZGwVcvUQLrsMq5tI+THoJs= Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=zGypcOTP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SqYiZwAh; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2DDB4400A4 X-Stat-Signature: jt9guoir9if63zp9fypxmy8xxfe8cdf4 X-Rspam-User: X-HE-Tag: 1663227443-95225 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 09, 2022 at 05:24:45PM +0800, Miaohe Lin wrote: > Commit 390511e1476e ("mm, memory_hotplug: drop arch_free_nodedata") > drops the last caller of generic_free_nodedata(). Remove it too. > > Signed-off-by: Miaohe Lin Reviewed-by: Oscar Salvador > --- > include/linux/memory_hotplug.h | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index 51052969dbfe..9fcbf5706595 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -43,11 +43,6 @@ extern void arch_refresh_nodedata(int nid, pg_data_t *pgdat); > ({ \ > memblock_alloc(sizeof(*pgdat), SMP_CACHE_BYTES); \ > }) > -/* > - * This definition is just for error path in node hotadd. > - * For node hotremove, we have to replace this. > - */ > -#define generic_free_nodedata(pgdat) kfree(pgdat) > > extern pg_data_t *node_data[]; > static inline void arch_refresh_nodedata(int nid, pg_data_t *pgdat) > @@ -63,9 +58,6 @@ static inline pg_data_t *generic_alloc_nodedata(int nid) > BUG(); > return NULL; > } > -static inline void generic_free_nodedata(pg_data_t *pgdat) > -{ > -} > static inline void arch_refresh_nodedata(int nid, pg_data_t *pgdat) > { > } > -- > 2.23.0 > -- Oscar Salvador SUSE Labs