From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB0EECAAD8 for ; Tue, 20 Sep 2022 14:04:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FA68940009; Tue, 20 Sep 2022 10:04:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8831C940008; Tue, 20 Sep 2022 10:04:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FC6A940009; Tue, 20 Sep 2022 10:04:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 63075940008 for ; Tue, 20 Sep 2022 10:04:18 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2259F1A0D18 for ; Tue, 20 Sep 2022 14:04:18 +0000 (UTC) X-FDA: 79932633396.13.8DB3C5B Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf30.hostedemail.com (Postfix) with ESMTP id 90ABD80018 for ; Tue, 20 Sep 2022 14:04:11 +0000 (UTC) Received: from zn.tnic (p200300ea9733e791329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e791:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 42A471EC00F4; Tue, 20 Sep 2022 16:04:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1663682644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=UxdIT3N09KsqckiSbe/NvyvNSdoIMMBwrOEJCizvJpo=; b=OG8msomfvFRFV9h3zLBfUDcULQo18fC9SQfmUXStEGVHnVEZfxdSTH1x+T966I7DiYxTNI zqviVHAhV/iBK8leiTrSHyB1VB7J+QX88UY2i3mug6eBVVaSVnM1xzd9XIwgSSFLkOQomr 6qM4pMYQXH7yq+Z49OOoOIov0lQVJYA= Date: Tue, 20 Sep 2022 16:04:00 +0200 From: Borislav Petkov To: "Kalra, Ashish" Cc: "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "linux-mm@kvack.org" , "linux-crypto@vger.kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "jroedel@suse.de" , "Lendacky, Thomas" , "hpa@zytor.com" , "ardb@kernel.org" , "pbonzini@redhat.com" , "seanjc@google.com" , "vkuznets@redhat.com" , "jmattson@google.com" , "luto@kernel.org" , "dave.hansen@linux.intel.com" , "slp@redhat.com" , "pgonda@google.com" , "peterz@infradead.org" , "srinivas.pandruvada@linux.intel.com" , "rientjes@google.com" , "dovmurik@linux.ibm.com" , "tobin@ibm.com" , "Roth, Michael" , "vbabka@suse.cz" , "kirill@shutemov.name" , "ak@linux.intel.com" , "tony.luck@intel.com" , "marcorr@google.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "alpergun@google.com" , "dgilbert@redhat.com" , "jarkko@kernel.org" Subject: Re: [PATCH Part2 v6 11/49] crypto:ccp: Define the SEV-SNP commands Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663682656; a=rsa-sha256; cv=none; b=4z0yAd15ci/RLwT15Tgi2dCkMf51iCNTX4SMscEl+o+AVZtKxLdCmWec27p1zPQzRZ45qt Iq/mI9v3sa4ow5M3SQJOm5trvp9UkRyqhVVFMKQo3mgnyZCF67SZTy5WPR2v9DmtNgT4Dg ZkNwjL9Fey7HBuiWJH8bnRTVh63RQLM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=OG8msomf; spf=temperror (imf30.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="SPF/DKIM temp error" header.from=alien8.de (policy=temperror) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663682656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UxdIT3N09KsqckiSbe/NvyvNSdoIMMBwrOEJCizvJpo=; b=j/Y7+iVaiDW6/CjDOd8xP5KU5wuskwp9I4fnRVos238h38xizdFJ2H37U8coN9JI9A19AJ hrs7QGJ/n/BiIFpx38lRFR0Pm3QxxxZw/rkxVNWnwBBl2TxG7UFd0LeiHAjFwaTNxJM9ZZ 5BrYn2un6Wr0DJ/skGfLXl6GgXKNrQQ= X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: 7wqjxo611a1fos157yw7utude7mcgp3w X-Rspamd-Queue-Id: 90ABD80018 Authentication-Results: imf30.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=OG8msomf; spf=temperror (imf30.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="SPF/DKIM temp error" header.from=alien8.de (policy=temperror) X-HE-Tag: 1663682651-327315 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 20, 2022 at 01:46:25PM +0000, Kalra, Ashish wrote: > These are structure definitions as per SNP Firmware API > specifications, and they match the SNP Firmware commands and required > arguments. Yes, I have the spec. > Isn't it better to have 1:1 mapping between specification and > structure definitions here ? Why would it be better if you can have a single struct serving multiple purposes and thus less code to stare at and deal with? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette