From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C61DC433F5 for ; Fri, 7 Oct 2022 01:40:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E26776B0072; Thu, 6 Oct 2022 21:40:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAEA26B0073; Thu, 6 Oct 2022 21:40:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C28C66B0074; Thu, 6 Oct 2022 21:40:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AE3656B0072 for ; Thu, 6 Oct 2022 21:40:55 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 62856A0545 for ; Fri, 7 Oct 2022 01:40:55 +0000 (UTC) X-FDA: 79992449670.15.F37F2AA Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf02.hostedemail.com (Postfix) with ESMTP id 143C98000F for ; Fri, 7 Oct 2022 01:40:54 +0000 (UTC) Received: by mail-pl1-f169.google.com with SMTP id z20so3257670plb.10 for ; Thu, 06 Oct 2022 18:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=psA+UjfPNNFZ4z+eBeZEC7iWY14Pqcje4PonnYU9M7M=; b=tbuceVX/H+PzhuayDzo0ykHHjxLNbJsg4T19hxiQSsdfkU48qf8ZZuz3sLTXWQfdEL pcIHj5O2ie5l4RAXMHP0YrRbHFrCm5I24YXoi/vX0aZEpHPPiQ7sCQzhTe0gFsYDpDb4 F8LwHS1381/FWww8nQ+Q/fFcHFdgpHKbpFKOftwPMmDsntEFh6VyKkhDS1+yMh1yPZJU /UJzsMGPOEaFevtotpvmhcA2umPoHMAjyfeYeJ0HhaN62ca25GBn7pLZLLWS/ZOHhClY Wk6B/yi3nLhM/R6Fy8CT+sQ7VM4xOf4bcQot4+mpwfLyecUdlqKV/KoGkg33BpjLuZrm OdQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=psA+UjfPNNFZ4z+eBeZEC7iWY14Pqcje4PonnYU9M7M=; b=k7q/fa2HZ0eo4WnX6oxD7VTVLbLUj0DNgknBs9jJSnzbABGOfmIBc5VsdzlVaLqC1u 1XXZY3eCaF9oMhKu4/+h09dvdd4jJBeCTpcUM2o4qELTEHYVcXWnxoXHR8d4cq1YTtEv WzG/1AjKaRmM6l8afNaVkdLN55tki0kU9RMbjY+MBTKPHZUEtx6EEmcksc5NZbPTf6nw cpy5a+3KwFS+DvtmzqFyuJEYVajNk52kPN2fKm9Zvoc/8ziCr0AvzLc/D5gMCt3KKY7N ejFb55NHp0o4yT/3Gr4d+Dn8bDtMouk6hOdpq/dnvWGxQI4BvbOJt2hSy5B0iK6+9wCF mIDQ== X-Gm-Message-State: ACrzQf2vW7EUnFJ+V43opFpiKrGjv1smW47Jvm0+IRDd9NVQaEnp3Nn8 +9SUwDqGMKAoTAaHyIuU2sOHsg== X-Google-Smtp-Source: AMsMyM5jX+Gww3bP73OzQcH0vIQiFVHxId96yushgKidEcYGmx9RGQXlWH1eBEQeVkoI06GpeM0sIQ== X-Received: by 2002:a17:902:b692:b0:176:d346:b56f with SMTP id c18-20020a170902b69200b00176d346b56fmr2222567pls.140.1665106854044; Thu, 06 Oct 2022 18:40:54 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id g26-20020aa796ba000000b0056188850950sm270985pfk.180.2022.10.06.18.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 18:40:53 -0700 (PDT) Date: Fri, 7 Oct 2022 01:40:49 +0000 From: Sean Christopherson To: Peter Xu Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, David Hildenbrand , Andrew Morton , Andrea Arcangeli , Paolo Bonzini , "Dr . David Alan Gilbert" , Linux MM Mailing List , John Hubbard Subject: Re: [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals Message-ID: References: <20220817003614.58900-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665106855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=psA+UjfPNNFZ4z+eBeZEC7iWY14Pqcje4PonnYU9M7M=; b=Ewmn+MMef2IAyQrO/f0H70MCHq3p4k0u/RU6LReDsQZGlxH0LGxuUliQrmuwsNpTWJejwc WXcIds/9bD3/bbCPas23zIC3RkzwM+Yf1AP8b7cHi/FHRZEc7BHxAiJBXEojlBY45T4kYk 8FGw6Z+BFQdzszYslRoVxkNmYBDOTKg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="tbuceVX/"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of seanjc@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=seanjc@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665106855; a=rsa-sha256; cv=none; b=4YrAXobKXh6FP1f2ROlDOk+hF1zFdBlz2y9cMC17UZ0qZL9Np8WQXIjGnAfwQ8AsNTys56 uK+6QuLByD96sBiMAye/0qUmsvhoqRoM9Uu53I3ES2bstj0kQD6i7XNZOsAIfsQFy+/yOc 2n0XRNC+iTmv6b5FrQOOpoypM0Srcbs= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 143C98000F X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="tbuceVX/"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of seanjc@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=seanjc@google.com X-Stat-Signature: d3p3u9t89eqgft4zw9zppq8q8ds7cit3 X-HE-Tag: 1665106854-7472 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000283, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 06, 2022, Peter Xu wrote: > On Tue, Aug 16, 2022 at 08:36:11PM -0400, Peter Xu wrote: > > v3: > > - Patch 1 > > - Added r-b for DavidH > > - Added support for hugetlbfs > > - Patch 2 & 3 > > - Comment fixes [Sean] > > - Move introduction of "interruptible" parameter into patch 2 [Sean] > > - Move sigpending handling into kvm_handle_bad_page [Sean] > > - Renamed kvm_handle_bad_page() to kvm_handle_error_pfn() [Sean, DavidM] > > - Use kvm_handle_signal_exit() [Sean] > > Any further comments from kvm side? Thanks, Code looks good, patch 2 just needs to be split up to better isolate the three changes in there.