From: Peter Xu <peterx@redhat.com>
To: Axel Rasmussen <axelrasmussen@google.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH 1/4] selftests/vm: Use memfd for hugetlb tests
Date: Wed, 5 Oct 2022 10:43:55 -0400 [thread overview]
Message-ID: <Yz2YK83Vejc+QIez@x1n> (raw)
In-Reply-To: <CAJHvVchRHhQDug1Zf6ygdnz96Dn4tBkPpB5fO3g2EDpxFcwP+A@mail.gmail.com>
On Tue, Oct 04, 2022 at 03:04:23PM -0700, Axel Rasmussen wrote:
> We should also update the examples / help text near the top of the
> file, since we're changing what arguments this accepts.
Definitely, I missed that.
>
> It might also be better to squash the changes to test arguments in
> run_vmtests.sh into each patch, so if we're bisecting we'll have a
> matching / working test + run_vmtests.sh combo at each commit.
I can do that, but may not be required - note that I did the first three
patches just to make sure they're still compatible with the old cmdlines,
by ignoring the extra params.
[...]
> This is a nice simplification! Thanks for doing it. Besides the
> comments above, the rest of the code here looks correct to me. Feel
> free to take:
>
> Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>
Thanks!
--
Peter Xu
next prev parent reply other threads:[~2022-10-05 14:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 21:41 [PATCH 0/4] selftests/vm: Drop hugetlb mntpoint in run_vmtests.sh Peter Xu
2022-10-04 21:41 ` [PATCH 1/4] selftests/vm: Use memfd for hugetlb tests Peter Xu
2022-10-04 22:04 ` Axel Rasmussen
2022-10-05 14:43 ` Peter Xu [this message]
2022-10-05 17:32 ` Axel Rasmussen
2022-10-04 21:41 ` [PATCH 2/4] selftests/vm: Use memfd for hugetlb-madvise test Peter Xu
2022-10-04 21:43 ` [PATCH 3/4] selftests/vm: Use memfd for hugepage-mremap test Peter Xu
2022-10-04 21:43 ` [PATCH 4/4] selftests/vm: Drop mnt point for hugetlb in run_vmtests.sh Peter Xu
2022-10-04 22:04 ` Axel Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz2YK83Vejc+QIez@x1n \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).