From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93EA1C433F5 for ; Wed, 5 Oct 2022 20:42:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DBF66B0071; Wed, 5 Oct 2022 16:42:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18CF96B0073; Wed, 5 Oct 2022 16:42:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02C898E0001; Wed, 5 Oct 2022 16:42:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E70496B0071 for ; Wed, 5 Oct 2022 16:42:13 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BBE331C5BE8 for ; Wed, 5 Oct 2022 20:42:13 +0000 (UTC) X-FDA: 79988068146.30.69A5D1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 605CE140017 for ; Wed, 5 Oct 2022 20:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665002532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KHrx4ZNF6Q9JTs4QbO6KR9zUQ7s8TQSOd7bK/WolviI=; b=jWxmja4FpWO3E0zc9cu2NK4ZOlk1QDHxCKPCap54yuqB0XvEAtCuPQIGaDEOc66T0kwov6 +kPk2D49VDwMyWVdXIN+xyxPMLJV7nqD/kWN7QtEI1SJhmBo1JOWtUk0cbL/IrvXK1hNVf AF8LEQ+ZfduWk08oGFkY1ji2HFtX7jA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-353-Po-DCOo2MMOZRQhLzg59lg-1; Wed, 05 Oct 2022 16:42:11 -0400 X-MC-Unique: Po-DCOo2MMOZRQhLzg59lg-1 Received: by mail-qv1-f69.google.com with SMTP id kr13-20020a0562142b8d00b004b1d5953a2cso7687qvb.3 for ; Wed, 05 Oct 2022 13:42:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=KHrx4ZNF6Q9JTs4QbO6KR9zUQ7s8TQSOd7bK/WolviI=; b=OIkTjtvOdmrNECthNIVlFSLlzI9gjpA9M5CIZF6CACKliuGA1DL6LT8h2BkXBWnqzB QuVcWZMUtBg6yiiNugH5xgYIsiqdoDyMyJHeB/GJ4K3YU6vleyCrP06f5vFM9YDFEcqr DlIfjbqxu+2EMww3S7brSJJxuHOPFw5orV4gKC846I0WOPpmeiLZFVCR1FjLh1vO2/ia YBVAKRRtdFnOkHNdaOZzVggpL0jMcPC5pMrYJZ/Wj1GVE391UGxtYQghY6M9TU3uUG4v qVEubrhNhiFubK+iENLFl4P7TtV8AeiOxC56siTmSzAmqV/gUHL9op/GFddcu5dwLpiM Bs1w== X-Gm-Message-State: ACrzQf0WZUVy0yNApGmLHvSccBfU+aj7qtha8UvZKAI52Ueb6AqQko6C WzyIVlJamqoLALLoC4ajwX7XQpEexdwdN/3AF5MmOTpMaye0jrktSmrcoBtXelBwifkOrpJuBYI lrzJjC7lmzyU= X-Received: by 2002:a05:622a:1248:b0:35b:b5fa:5e25 with SMTP id z8-20020a05622a124800b0035bb5fa5e25mr1041838qtx.215.1665002531453; Wed, 05 Oct 2022 13:42:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7VIUcXTqhgXvpzJkX75ZmoU7Lo+ixxEfdl/3WdVWfbQmY8WVE4OWUXjeUt4C2zlipy5Q6F5A== X-Received: by 2002:a05:622a:1248:b0:35b:b5fa:5e25 with SMTP id z8-20020a05622a124800b0035bb5fa5e25mr1041822qtx.215.1665002531239; Wed, 05 Oct 2022 13:42:11 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id i10-20020ac8764a000000b0031f41ea94easm15639632qtr.28.2022.10.05.13.42.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 13:42:10 -0700 (PDT) Date: Wed, 5 Oct 2022 16:42:09 -0400 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Andrew Morton , Shuah Khan , Hugh Dickins , Vlastimil Babka , Andrea Arcangeli , "Matthew Wilcox (Oracle)" , Jason Gunthorpe , John Hubbard Subject: Re: [PATCH v1 5/7] mm/pagewalk: add walk_page_range_vma() Message-ID: References: <20220930141931.174362-1-david@redhat.com> <20220930141931.174362-6-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20220930141931.174362-6-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665002533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KHrx4ZNF6Q9JTs4QbO6KR9zUQ7s8TQSOd7bK/WolviI=; b=vlhWvAhHnHir5qdl23heD2TGLOC+MpXOgMaRzdz7HRzHS8BHcaTHK4cruWD3Pyjjqv1H01 yxX1cYwnmhDfv8b4NlpgT807WA/6ucKJ4dLq5r5/RKP9noJ5OFSC0rexpn/wtGnT1hD/V+ D+DsLVFvUXMSgIXWk8Mj/GexdIMmgJY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jWxmja4F; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665002533; a=rsa-sha256; cv=none; b=VMhoMFiJBXpBrp3E6sj0T0FZ9UzMp6MONCWiaXJl4FQ6h4uAiFmqXOYAvDravNWtchlsUv H3ZhttBKomd09O5TJZ2Hy7ZwA6fmJffZe5aMFBWnOjNcXjt64c7F3opfHcNQBfMzxq3l75 5Z9yehOTzoXB9vL7YfxYjBPHE+agxYo= X-Rspamd-Queue-Id: 605CE140017 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jWxmja4F; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Stat-Signature: z8qts47k1epi36snocgihs3e9idstko9 X-HE-Tag: 1665002533-801941 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 30, 2022 at 04:19:29PM +0200, David Hildenbrand wrote: > +int walk_page_range_vma(struct vm_area_struct *vma, unsigned long start, > + unsigned long end, const struct mm_walk_ops *ops, > + void *private) > +{ > + struct mm_walk walk = { > + .ops = ops, > + .mm = vma->vm_mm, > + .vma = vma, > + .private = private, > + }; > + int err; > + > + if (start >= end || !walk.mm) > + return -EINVAL; > + if (start < vma->vm_start || end > vma->vm_end) > + return -EINVAL; > + > + mmap_assert_locked(walk.mm); > + > + err = walk_page_test(start, end, &walk); According to test_walk(): * @test_walk: caller specific callback function to determine whether * we walk over the current vma or not. Returning 0 means * "do page table walk over the current vma", returning * a negative value means "abort current page table walk * right now" and returning 1 means "skip the current vma" Since this helper has vma passed in, not sure whether this is needed at all? walk_page_vma_range() sounds slightly better to me as it does look more like an extension of walk_page_vma(), rather than sister version of walk_page_range_novma() (which works for "no backing VMA" case). But no strong opinion. -- Peter Xu