From: Jarkko Sakkinen <jarkko@kernel.org>
To: Thomas Tai <thomas.tai@oracle.com>
Cc: "tony.luck@intel.com" <tony.luck@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"reinette.chatre@intel.co" <reinette.chatre@intel.co>,
"naoya.horiguchi@nec.com" <naoya.horiguchi@nec.com>,
"linmiaohe@huawei.com" <linmiaohe@huawei.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/1] x86/sgx: Add code to inject hwpoison into SGX memory
Date: Wed, 5 Oct 2022 01:12:25 +0300 [thread overview]
Message-ID: <Yzyvya4wdfovw2eh@kernel.org> (raw)
In-Reply-To: <SJ0PR10MB462307B1EA3097E1E725309DFD589@SJ0PR10MB4623.namprd10.prod.outlook.com>
On Sun, Oct 02, 2022 at 02:51:22PM +0000, Thomas Tai wrote:
>
> > -----Original Message-----
> > From: Jarkko Sakkinen <jarkko@kernel.org>
> > Sent: September 30, 2022 5:51 PM
> > To: Thomas Tai <thomas.tai@oracle.com>
> > Cc: tony.luck@intel.com; dave.hansen@linux.intel.com;
> > reinette.chatre@intel.co; naoya.horiguchi@nec.com; linmiaohe@huawei.com;
> > akpm@linux-foundation.org; linux-mm@kvack.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH V2 1/1] x86/sgx: Add code to inject hwpoison into SGX
> > memory
> >
> > On Wed, Sep 28, 2022 at 11:38:32AM -0400, Thomas Tai wrote:
> > > Inspired by commit c6acb1e7bf46 (x86/sgx: Add hook to error injection
> > > address validation), add a similar code in hwpoison_inject function to
> > > check if the address is located in SGX Memory. The error will then be
> > > handled by the arch_memory_failure function in the SGX driver.
> > >
> > > Signed-off-by: Thomas Tai <thomas.tai@oracle.com>
> > > ---
> > > Documentation/mm/hwpoison.rst | 44
> > +++++++++++++++++++++++++++++++++++
> > > mm/hwpoison-inject.c | 4 ++++
> > > 2 files changed, 48 insertions(+)
> >
> > Hmm.. no change log.
> >
> > What was the change in-between v1 and v2?
>
> Hi Jarkko,
> I put the change log in [PATCH V2 0/1]. Following is the details, hope you find it useful.
>
> Changes since v1:
> - Add a comment in hwpoison_inject as suggested by Miaohe
> - v1: Reviewed-by: Tony Luck <tony.luck@intel.com>
> - v1: Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
>
> Thanks,
> Thomas
Also,
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
next prev parent reply other threads:[~2022-10-04 22:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 15:38 [PATCH V2 0/1] x86/sgx: Add code to inject hwpoison into SGX memory Thomas Tai
2022-09-28 15:38 ` [PATCH V2 1/1] " Thomas Tai
2022-09-30 21:50 ` Jarkko Sakkinen
2022-10-02 14:51 ` Thomas Tai
2022-10-04 22:12 ` Jarkko Sakkinen [this message]
2022-10-07 6:33 ` HORIGUCHI NAOYA(堀口 直也)
2022-10-11 12:50 ` Thomas Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzyvya4wdfovw2eh@kernel.org \
--to=jarkko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=reinette.chatre@intel.co \
--cc=thomas.tai@oracle.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).