From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF9FC433F5 for ; Tue, 4 Oct 2022 22:12:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1872B6B0071; Tue, 4 Oct 2022 18:12:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1384D6B0073; Tue, 4 Oct 2022 18:12:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1B3E8E0001; Tue, 4 Oct 2022 18:12:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D9F956B0071 for ; Tue, 4 Oct 2022 18:12:33 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A5479C0EED for ; Tue, 4 Oct 2022 22:12:33 +0000 (UTC) X-FDA: 79984666986.30.1510DDF Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id 27B20100013 for ; Tue, 4 Oct 2022 22:12:31 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 35F41B81B47; Tue, 4 Oct 2022 22:12:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A1D6C433D6; Tue, 4 Oct 2022 22:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664921549; bh=zh+aJF7Mze9nAzC2hFiXb657t0HuludcQqubAGJzx1Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ePgr+8PlYXm1YhS0pZYsmNTS30xPSrNVlb4d/Kyf96URa9aJo1OOw7U35FVyACJlr jlyzReOfsV1VOLAhTdRaGXUf3GqogQvxaNyHC6AkJwsP6fidjMOjt/9xEriPX+SBUR 1QH1AAfrN9mBFUywfeOW8ceT2OMNkj8dxeu49LehumVT+1yDqkMDoLDhFsVo1Uukgc SbIkQ2ys/Ysn8kat2aOfs8SjB92jwRyV8q/3Lvqk2OblPMiRI2b7RcvLJV0XIueGYd /mjq7/ljyxYmPMEtfGcrGUTbv29fWDXJ5S9thLOi6F7+guUn9++67MtgTIfgcseXRk kX9wN4e0eS6GQ== Date: Wed, 5 Oct 2022 01:12:25 +0300 From: Jarkko Sakkinen To: Thomas Tai Cc: "tony.luck@intel.com" , "dave.hansen@linux.intel.com" , "reinette.chatre@intel.co" , "naoya.horiguchi@nec.com" , "linmiaohe@huawei.com" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2 1/1] x86/sgx: Add code to inject hwpoison into SGX memory Message-ID: References: <20220928153832.1032566-1-thomas.tai@oracle.com> <20220928153832.1032566-2-thomas.tai@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664921552; a=rsa-sha256; cv=none; b=1c0XIaozZSS3Mq6WK2VDdkCpnMpjYcEOYFZnUvaXns615+J0ONTUjQgpHYyhIYfhI0Y+HJ 3xVlD/dWhWaXFVb+c1ibPVkJR2kTPE8UewtauKYay+tx220YznukXmgn3JV4irS+v3LTnJ 6ufUuEOtN1IYnZ/csEEmeGeTAgBuKz4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ePgr+8Pl; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of jarkko@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jarkko@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664921552; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+q3W+tNtfqitqsyjoQ28dgo4QKlAP2rS3DKt8NDdgjE=; b=UWWZzJMDDEZnlfv/Ct8OKQt1er1yx59o0DEPXpgyjj3r4OitRNDmQqH558zBRAJMdfu/U4 4SESIUB4LCO/04tLBwBvO1WQ0gSvJbkV2kavhrrhXy0dKViHijZXmg+YI2sKMRmVymvA+G qUq1nDNecE/SDXMuJQ23az3E2Bw0dic= X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ePgr+8Pl; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of jarkko@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jarkko@kernel.org X-Stat-Signature: jp9e5cxufwyxzb6szo9z5u5ermz7mm1s X-Rspamd-Queue-Id: 27B20100013 X-Rspamd-Server: rspam09 X-HE-Tag: 1664921551-736942 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 02, 2022 at 02:51:22PM +0000, Thomas Tai wrote: > > > -----Original Message----- > > From: Jarkko Sakkinen > > Sent: September 30, 2022 5:51 PM > > To: Thomas Tai > > Cc: tony.luck@intel.com; dave.hansen@linux.intel.com; > > reinette.chatre@intel.co; naoya.horiguchi@nec.com; linmiaohe@huawei.com; > > akpm@linux-foundation.org; linux-mm@kvack.org; linux- > > kernel@vger.kernel.org > > Subject: Re: [PATCH V2 1/1] x86/sgx: Add code to inject hwpoison into SGX > > memory > > > > On Wed, Sep 28, 2022 at 11:38:32AM -0400, Thomas Tai wrote: > > > Inspired by commit c6acb1e7bf46 (x86/sgx: Add hook to error injection > > > address validation), add a similar code in hwpoison_inject function to > > > check if the address is located in SGX Memory. The error will then be > > > handled by the arch_memory_failure function in the SGX driver. > > > > > > Signed-off-by: Thomas Tai > > > --- > > > Documentation/mm/hwpoison.rst | 44 > > +++++++++++++++++++++++++++++++++++ > > > mm/hwpoison-inject.c | 4 ++++ > > > 2 files changed, 48 insertions(+) > > > > Hmm.. no change log. > > > > What was the change in-between v1 and v2? > > Hi Jarkko, > I put the change log in [PATCH V2 0/1]. Following is the details, hope you find it useful. > > Changes since v1: > - Add a comment in hwpoison_inject as suggested by Miaohe > - v1: Reviewed-by: Tony Luck > - v1: Reviewed-by: Miaohe Lin > > Thanks, > Thomas Also, Reviewed-by: Jarkko Sakkinen BR, Jarkko