From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFAD7C28B20 for ; Wed, 2 Apr 2025 11:40:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FBAE28000B; Wed, 2 Apr 2025 07:40:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D0B4280001; Wed, 2 Apr 2025 07:40:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37D7928000B; Wed, 2 Apr 2025 07:40:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0DECD280001 for ; Wed, 2 Apr 2025 07:40:16 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C286BBAEAA for ; Wed, 2 Apr 2025 11:40:16 +0000 (UTC) X-FDA: 83288910432.27.25D2E13 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf14.hostedemail.com (Postfix) with ESMTP id 81A6C100008 for ; Wed, 2 Apr 2025 11:40:14 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=breno.debian@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743594014; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tSSWaoMXMmk+VTJYv0+HS9ERfp+r5KyIMWvtCnRk7bU=; b=0wcNMdJ6hOek8tGSgRnaP3GdYETdfzDSgXPP9SZE4vbLgTHH7/85whpWextoOvbQxMDzyf Cemi5GgCvHyBlj0eQNyP2ID1z/4DRnPhVZrriAkzLuWe6NydW2JVC4PsYeeMk3MEMDwRnX ATPNdYKUzE8Fkl00cNCtQ1YPYw8wWa0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of breno.debian@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=breno.debian@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743594014; a=rsa-sha256; cv=none; b=tOjxD/LOzH8CqMRmDyrnEC3Lv2tTiqbPgoDC03QnYdf9iUB2Tsvjj3AE2TPFkoOVC1MBnn kDt2meOAFVZnLy9rElzYvAw/j96RWPkxcyavp270NOTqbBa/LRYwCZ+dxxWmUZtQ6lV6cg nhC9mIXyrLFP7EGWhFqq6tXNK+xo/5A= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5efe8d9eb12so4679742a12.1 for ; Wed, 02 Apr 2025 04:40:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743594013; x=1744198813; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tSSWaoMXMmk+VTJYv0+HS9ERfp+r5KyIMWvtCnRk7bU=; b=exJKqcOR7NMyMTGLjbVu4IND1w2+s4YmPpXnejUC4XQg9Qn6Hbt8k0YJCWKODqgB9j qnyjKtiGQyTnywF5n1SThUKoKif2ioHw3Tl2V0ewVer9K9MeGBrtP+d3znS3LtX/q/zb NebmmFlrOPV1eizmPPQ0DqD+tFQ707IqEp8D9hjTOeE6xcirqMOHfx/RuCq0hwICDAtD j5d7DeqHjICYooCmjCqsmLD//u69TjEMIEMmel0aqEEgujkMKiY2ASTCHSsLEDFBlsgn uhqqHmcQzDEoLufDkjtbyFZUZQHJ9GrluGOpTw4TBBL5tj/BYyAflrvDFnwvxl0sLBi0 Ljqw== X-Forwarded-Encrypted: i=1; AJvYcCXR/BFKquXJ/pWjWPHVSLGhixuK+zRHPBwimZofo/BQ6K8hHAC0gMEQCZN78PqFtTJm/Q676wIjTA==@kvack.org X-Gm-Message-State: AOJu0YwXkh5vaY3g1FyJqys4ihN0JoyKJ/6qI1vYFyJKcUbSGuOi/S8T S3FGLEFPqbtmhCeYzNt0UE1NB/Xnlmo63WZ9WmmqO0M6XrgDCfSE X-Gm-Gg: ASbGncuGQ9guuwM+E9B8zP8jjtbOfnWu0IYPl/4oB2b1Unrvgr5cdZ1vvjlEdSD65e+ vwA9AcgiKhHEWYa3CGGZiQLk1itzKJ9fJeH/5uFZ7hG1wjVA3/PoLJhLAstdWyK7VZK/HFYsLWR pTl6o7qeicP9TSnyZRDIAJ/wScxRvBd41sw7TkGXvnsAUQTcVIx69bdA+rd9ZQAEM+A43zJjvpj gTy0PCsDgBx2bnJnxP5Le1k/f9JxEjaez2BtLo69tfCp2OQ4hK5JovswYRe0nVF/pfT9/m+SqyN yLUJPIsfF0rcYstbLV18hpkyxpAqiy0ARo4= X-Google-Smtp-Source: AGHT+IFQLH/RY5eSKHMwG8QPzd/pGuQxEByK/QxO7h0JajNZEC/MZd9G7lfaEypghJ/7q6CENDuuMg== X-Received: by 2002:a17:907:86a2:b0:abf:641a:5727 with SMTP id a640c23a62f3a-ac738a1646dmr1718880466b.7.1743594012742; Wed, 02 Apr 2025 04:40:12 -0700 (PDT) Received: from gmail.com ([2a03:2880:30ff:9::]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac71961f9e5sm895428266b.117.2025.04.02.04.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Apr 2025 04:40:12 -0700 (PDT) Date: Wed, 2 Apr 2025 04:40:09 -0700 From: Breno Leitao To: Shakeel Butt Cc: Tejun Heo , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team , Jakub Kicinski , Venkat Rao Bagalkote Subject: Re: [PATCH] cgroup: rstat: call cgroup_rstat_updated_list with cgroup_rstat_lock Message-ID: References: <20250401170912.2161953-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250401170912.2161953-1-shakeel.butt@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 81A6C100008 X-Stat-Signature: ywb1y1ob73pyj3nkweobiyf5x6dc1cju X-HE-Tag: 1743594014-72967 X-HE-Meta: U2FsdGVkX19tCSOuj/2KUcFvbJ0J0rVAlhzg6oc8GcicNyfH95TFpeCz1wxnJlgtITJpM1dsgfVFuYa4FduEKC3U4WUVO3o6nIax1BmOT4m783crYpSYtrwbVW5LCcMX+zuDhiDO6AelmtvtEfniUkyRGR3mUEL8i+vcFt2zVl+6Cp9vq1+D5y7PFyHsG9tiF+HwWlfsxdRbXme9CsIrZKZEWnXlRdEglLc7GAOR0z2EJ6MSzz9bmczf1+/ykJaCJcfe2f0siVKfZ1URnuSOTHWxef/Jngxuv5//j0Kq4zWrVxz+Q4F3fHmahMRLcf8neBsD20xyxxGxOAWxQsAlKFACtskwvkvpVEvV8zLovAB4Oo2VTyqD9l/5oij+GqpfRLRkcnsKhn1vzEA+yGcsq/uFVs9iQj416Ps9klNt1XUe+Iflk5VQkl+cl5IjBCPgiF0iDn1pAiQnY20cF44dFh3TcjgFx9/QmtCGyeIkpPMod7d78H/ghu5r7NYYJVCRNQ+crfLpTm8pzmykShA48ztVLNIKRXqgmiAzlHwd0NuA+6Yhq1hBnsm8QaBDjVY+txDyBDjepzy5VvzmOpo2RZlwyyOZxi4klbrK5Y5ledt+xsvrJOMd8sTAi7OTlJR67pqh2XQHY47pKvPkAuXMh1r3y1bySvcbnOgWY1B90zReWXistsamt13gvWOnKoh6sBNBvvHLI5VuyBNblMH7s6LoDQhNHZAVGuMvyo6An2vYT0iESO8lEUO4iO9gGCJlkdv+luMkqqmqH0FrEbTXmTd1NBrsxuIfnOBsmO4KBYZ+f9GQcTEKSrRKc/jYwmh+Zw9/iK6T4cZvk94mqtFQQtWjonmvnP50or6QjnglHu3/qju7Zcru+To4E2/yKtrBePYtd9+Rma1joMaUMOUjKhgY5G15CRigjacgzNPRq4ZIkEtZGBwcgTIPtRbR5UGFfK19nG271gLVHU6+gi4 DKyIiXlP yn8/jVcQrnF/cgQ8Xr+fmJJTuqEhyNKns1FP4ra95UnnfOxZHXW0457sTf7UeoQaITe14/Hau4oV9jNMcUaufV6qwKe93J1G2VQpoP1gR0NF/Q0bTy6zK99JRkLtcWS9h3xaz4eBGPV3HR4gWjE748gRI+Vh+8+j+XlIqe0uIyPza2KXul8s78jX3O0q+D5euUsXRowi39ZwxeTBhP5ArZwMm4jKfngV0p/u+z71tC+MGYxd7cVM8VEYcrZqtdz7ezWHP8CLeLht5CSs23WL18cLSdWxk/bk87oOACMmMxuHw+j25scVq5HEoa6RwDo27vuxvbEisNRcDblSLN3GQPvKDrpF18rCDBCa+96UawyhGYSQdnMU+0Q7V3S+vAAM7lKz8wXvLoxd5KZARoG2zV53LPF1C3RbM95RhLb5J1jte4PEHb56lkBd/Uc5IyeZ8NoZvePnLELo+7LNGUN4yqbtS4sojP5khopZ2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 01, 2025 at 10:09:12AM -0700, Shakeel Butt wrote: > The commit 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and > locking") during cleanup accidentally changed the code to call > cgroup_rstat_updated_list() without cgroup_rstat_lock which is required. > Fix it. > > Fixes: 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and locking") > Reported-by: Jakub Kicinski > Reported-by: Breno Leitao > Reported-by: Venkat Rao Bagalkote > Closes: https://lore.kernel.org/all/6564c3d6-9372-4352-9847-1eb3aea07ca4@linux.ibm.com/ > Signed-off-by: Shakeel Butt Tested-by: Breno Leitao