From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A95E8C36010 for ; Fri, 4 Apr 2025 08:26:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B8776B0006; Fri, 4 Apr 2025 04:26:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 468786B0007; Fri, 4 Apr 2025 04:26:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32E9D6B0008; Fri, 4 Apr 2025 04:26:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 15F0B6B0006 for ; Fri, 4 Apr 2025 04:26:32 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 69B3F58DB6 for ; Fri, 4 Apr 2025 08:26:33 +0000 (UTC) X-FDA: 83295679866.08.32BECE7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf15.hostedemail.com (Postfix) with ESMTP id 6C512A0006 for ; Fri, 4 Apr 2025 08:26:30 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=tqgQ+ZAI; spf=none (imf15.hostedemail.com: domain of BATV+b7d9887153177e9f403b+7894+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b7d9887153177e9f403b+7894+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743755191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oraxD8aMa5Ju/0vnsP/hcRb2KGBRetYjxu8XH5KcdDM=; b=3vOip/Rulhuw0Fi7DTxOVHNm/4rMxJ4VtwxkRywLZEm1TAGehH88+pXivuEX4Zy7dZqkFs 180bbN+jr3GkouvQr/VbBEsqqKL6h2GKCqpl2c2TWGGFGwlpNGGJIGlCR4H2+yPGQ4Lyfj CAYM2Nl9vno9WB9PqxAG8QcK42KA+0k= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=tqgQ+ZAI; spf=none (imf15.hostedemail.com: domain of BATV+b7d9887153177e9f403b+7894+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b7d9887153177e9f403b+7894+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743755191; a=rsa-sha256; cv=none; b=4eePvmgKXDhDwjU26Op+RDRDN3icOAM/sQxePhFbjTKRivFqIYlzUQjNJHt1Z+/Db+m1ak ys4CAHCESJ6CKgAJ1NS2Y/Dc1QNmdFz7MbZGUhcieX5wvsDUL54iLp2VoGQkkq556SUDXO xKS7XEQ+maizCvWaWC1alWaom7Sv5Ng= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oraxD8aMa5Ju/0vnsP/hcRb2KGBRetYjxu8XH5KcdDM=; b=tqgQ+ZAI13WIHA+fNSs8NHoX3s z8IJ44dv8nuoiw+jyiPTGW3Z5EeB6WUPInEoTrNeMSTCbxHdIZna/wHMGBZNaDzpo+HpdqXgJJK/5 aciJdw8KAQLtbNDnRLOM8jWoWXhSQnynFWRdspyjR/pLUt5h1D0eym8qq1VLb+wFuubsrKmuemtaH QuMQ7YALe7p0d+SyyVrg+0SpKbTx7D5p5WxzNabWNKf5g/DqNyoq8Y3GpYGrIpHcXpBHaMYsjkki3 JVkGvBXTOKb4dGnk0nnRhs//xR5ZcFPTyvm5wBMl7+pPavcxeTEKVnpUvgMRO2oofwedE2ul/zqKS jDCzOKHw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0cNh-0000000B8KM-1Xm2; Fri, 04 Apr 2025 08:26:29 +0000 Date: Fri, 4 Apr 2025 01:26:29 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 6/9] i915: Use writeback_iter() Message-ID: References: <20250402150005.2309458-1-willy@infradead.org> <20250402150005.2309458-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250402150005.2309458-7-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 6C512A0006 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: 7z13fsuqqd3abtdyi6oo4s4ff5u9pzqs X-HE-Tag: 1743755190-913772 X-HE-Meta: U2FsdGVkX1/e8F7lr6EUmI01dIaMjHCsOHZNx3cvMePtFaKPWws4IOuKnJOH825Ngy2fJoNbckRecL56xP2gqZhvVxBu5WzUIUlPLVXAVKptnTyDXvt2gnIcCdXWNbVYOANOw349Ud+PlkSewCxt4R2E6lOFWwBFtS9J9wdnM0UcXYPkKRVVpC0bLj8FisI7Oyh3MvszYQxJfHlGUdU/BwzJPwUr/PfW9AKx/oZfxvZIsURYpc5ZIHhO59t+GWePEPUlS8Ks1h9/06Mhcp67dA0FWNF6SQEyA8bsypoTBPMFIFJY8xfdr7lmc+n9YhFajQDnXehShxVvGuf/UjiwGWWX86aTVW18mnOVJHnvt/yFUfrq5uwVfGIzYGtpjvJbTdZfvG2+i9LVA0YCtdfJ6AysKoXdXwNK7zWIiUw2s64Jhz6NsV0gXPvzB/PbzyFzWLp0+kwVqBrha/sGAytAd5ga9QZyEoww9RvD61u0aPKXRM20cjj4S4xpqbdfAN2cfMhB/p0vP0Ag5Q+kWz/sXGky10KXtYhk3xFUfjBl9nUjUlnV3OamrDhbtEVJPWukcGdUfDi5N3jjLMIzUjUkHAFzaPKCJJH+xhGKpw/srGYhM/FnmsjKPUt9yARwAJuSxfziKX7+/IGtUXSVjE1dkDuetL9vSRjHwuNCpC1kxpPXnHzenm0j9flSnn6BAtkjfcTpMN9wIC2ico+k8oy1A+v0ax2jOY1JQ14QTwnTELnSXcQ2nf63F7D7GESGaGbTT05pbgUoHfN6AKahr+N4tSTSRPJSXG6siwJHPepfRCMJmweouDOeXWXwMyAuO2bvSVVv05SCuPXB8IIX4tBe6LGGL59pp6LcxXa7nEuUc2I9i76QSlzNJ5G7YvKMJJJpLu+i9doOQ7BSSEVxYvSqWLz1ZgdPXBuC4EsB8S1BEZviL1G7oYWjAdHoHW7WmrRjyB0B5Z+ux6ihfTtyzhu BzPxii12 WoS2u4+pznann/p1MoOBunQy5hZRijKDqKPEx1/lFp8gcstDesASCdC2Wil0yxkI3xzgfxKgma+wZ55/NtkbCHpB1gFl8D/J3WyB9EcuLrsNJDR+QmsmcyIssFUyl9PZHWbB6lgaZ4ZW2lYceY0W+ZsyoQk3WvMzhrcHAijfyhnmDZvcTvrCyzN8o0y7Z02V4h8r3eKZsBXKjmln+ireyiBm6342QoE7pg/G7xhgPsifjLYu+IOOVmT2ba8c5voBMznF56sDje1HhMrRcuOt3mKBtC2cvSi3xD/4sAi99JmiONn0fdX0kL8YsOdPY5OyFWz7axH7rj4VNyQ/I8WbnXZQnX0pyDhCwTIqUV8PuggmRMIJO5wspoxdvwoeQO/J0/m9a/uYINVNz1CZVqyHzHUFu/M91N3TBKmsuZiKjy6DXjL62I4WKNxqWvtABoAFTstM+y/yH5jVs0R/zM/xCp442jq8nnIkJ5zDuJwS5xgEUzp/3xmBWExaX2F2dmSIGgOyKJ0Noeeo5gYBMB+XxVPfDSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 04:00:00PM +0100, Matthew Wilcox (Oracle) wrote: > Convert from an inefficient loop to the standard writeback iterator. Not for this patch but a follow on: we really need to improve the abstraction for using shmem for driver a bit. Drivers implementing their own writeback_iter based loop is a bad idea. Instead the code here in __shmem_writeback and the similar version in ttm need to be consolidated into a nicely abstracted highlevel API in shmem.c. Similarly for the mess these drivers cause by calling into the write_begin and write_end aops.