From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF2EEC3601E for ; Fri, 4 Apr 2025 08:43:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30EB46B0006; Fri, 4 Apr 2025 04:43:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2961B6B0007; Fri, 4 Apr 2025 04:43:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1358B6B0008; Fri, 4 Apr 2025 04:43:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E97EF6B0006 for ; Fri, 4 Apr 2025 04:43:23 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8C9A1C17F7 for ; Fri, 4 Apr 2025 08:43:25 +0000 (UTC) X-FDA: 83295722370.14.6C19BEB Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf28.hostedemail.com (Postfix) with ESMTP id 5DB8DC000D for ; Fri, 4 Apr 2025 08:43:23 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=POTkSHk0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cn32Yqx+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ED9O2Vx0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=69FstQe9; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743756203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OrZgIzLm3PyWeKUSNlcKFVAqLYDLMpRNMU+d2NZfOsE=; b=rx4S8KV/vZFi72QLFhL+pmJDidPHJ0/rfv3JaM7F3VDMrL289XZQxbPRUJzUyw8rdeY2o3 Yz2N7Gp1QqJtbrF9AETHavr9jlpt1efuorFpPy4tA3vv+w9Q1oxEl8TNErYIhAjh7CK7W2 D9HWao4xVqsEaGDX0ZGB6pD3kcsnWC4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743756203; a=rsa-sha256; cv=none; b=VTTQMYm5fSTHnGqwlprQ5xXuKu5T/T8iMZdMMMVIEz7Lheru48xfm6RpxfFBqHQMuSIlTj 0SCuQ5cdT38yohbwr8QQDilr5h2Jp23Pv4ipCpEllHLV4oa6BBjPgCu5XARlu9ZPJzrV5A VM+OqsPTPYyJ79XRkvx8oG+KvhsM0J8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=POTkSHk0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=cn32Yqx+; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ED9O2Vx0; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=69FstQe9; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ACF401F385; Fri, 4 Apr 2025 08:43:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743756201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OrZgIzLm3PyWeKUSNlcKFVAqLYDLMpRNMU+d2NZfOsE=; b=POTkSHk0i8Pb4qfwOG3XpgMZMazbhvYt2nQi00ULHevtqUgSyvJthWeCQg1JsmVNX2nHpt L2q4gstO5+dB57+gZyH+Te7LpuQNzcz7Bv6nCkO8+sFNGVaq6K/IgpDO3rnaoNKAOUH5TT x+XbG4PnT/mEeFftxF8GvYyw/PGYOMU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743756201; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OrZgIzLm3PyWeKUSNlcKFVAqLYDLMpRNMU+d2NZfOsE=; b=cn32Yqx+3rr4MqtGfBzfHXiFyrBsZF9h82Facd3KMo2ojv3Y0cnltjhQXFe86ZolzrtfoI GzY0Fl/TD5HxI4Bw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743756200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OrZgIzLm3PyWeKUSNlcKFVAqLYDLMpRNMU+d2NZfOsE=; b=ED9O2Vx0E8yHxc7oS7PQlGnuI6L4rcC+V3IAK0rajq+1rZdW5Br7OcjuUNQY4EINXgRmjM dla+CUwyuy87W/p1XEYXrQi4oDc3uj3L2q3dKXIbuxOaJw5R34G2d5SIVQdxHBLdR0bJSO k9+GPuDJxmbEDMFJR2ELVF9A2zXGFsY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743756200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OrZgIzLm3PyWeKUSNlcKFVAqLYDLMpRNMU+d2NZfOsE=; b=69FstQe9GZGgTWIuTDFf4ZPVfR9uLJDZLTAAWcyoZcP3ogXeCUSxs2aRlfyplPFUqY0bcF 0oaqhW32i3osceCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DDCFA13691; Fri, 4 Apr 2025 08:43:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gCVpM6eb72fofAAAD6G6ig (envelope-from ); Fri, 04 Apr 2025 08:43:19 +0000 Date: Fri, 4 Apr 2025 10:43:18 +0200 From: Oscar Salvador To: Rakie Kim Cc: akpm@linux-foundation.org, gourry@gourry.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v6 3/3] mm/mempolicy: Support memory hotplug in weighted interleave Message-ID: References: <20250404074623.1179-1-rakie.kim@sk.com> <20250404074623.1179-4-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250404074623.1179-4-rakie.kim@sk.com> X-Rspamd-Action: no action X-Stat-Signature: uxbbbgoiqm7q46ix86m9gpeg4i97scnz X-Rspam-User: X-Rspamd-Queue-Id: 5DB8DC000D X-Rspamd-Server: rspam08 X-HE-Tag: 1743756203-8030 X-HE-Meta: U2FsdGVkX1/7HmMLXOn4/pfzX9mEbsOSXDjgc1HwQlss6DJWzlPwVBwlq8lBWJyL/WhopbFZDRnAEsXrE9HuVR6N4CyA6n2SrB/VhPxrZACnOG+faAGfpzluzRjg+loA3hIAZPKVK2y/LDHBg7e9m/Oz/VN0s28I15iMa76LrTUkFR7z1Pi9IOW9y6mYodR7kYxk7hrdAfmvyqd4eC8pLBUioUxlM1u+5PM7YQIKOGwRbHH8R+CzWDXDiKhiRulIk4uzGaHTEDK3zX9T3Fnd8GZMtPk3KlD1g0GflnHbZIlNjq3xBfLryNOWa8jLo7k/UGGRmTDpsyPz/7jMg1o4Pl+8dSFsU2Znu7u1Xyqk1BG6XlOJoIgumDxtLp/rtyNz2pueH5GHsgs3geF4U9isX2dsybYvDtzya/4QtgFvTfd8oNoL/hpM7Mkjl9A1+UUXC8kfM+stE48yXMt1hdlCSICimzqEX0x6odvgTwIdi2f+AjhmF4M5j6gK0dSVQSChxDFZrcd1xeVcQs1lXwlSpmcZ38EcskyL1ws+2S1NaiJssRoAf2w96nYvwjjEJZ7bYKh+MEL2YSElX166KIPu7UVE+eFqofy5w2B/3mJ4Nio5gHvc3r9oecAMxeIvZzE5WacSkfb0qYQcRMnqn4llQsW+6HdX9RVX8ZwlDU5t5uEB8qXDxf4t2i4IEkipmJen+xnVWrHUW9/DjKaZAApzJ5FOErM4xzFdjbSK3omPu3QFXRFJ6ULRNfm2SSy9ktPnuOenConK3CkWIlhu6ISGtJYjLHgX5SeVOFnyqyrWRnMfDkhvEredc3r1+B7uW3yZKSRJFS/iQ91gD5/b6jtKQ0EHAju/ltr40wSVukt29AGsz9Mvg6aqowRuWU9DqDvtFeXm5cx1pVRmX5TQaLI8fUyFP7/pJg2QZb8LDfaOdanPE8H9ugRj8C90npClhcB5ykLwjfF+C4qX+gFYAnW 5Mmr4Z/7 S1wpxBSvCoX/lfCDGCDxYjg3kBsn92qB88aHJePyH8t4vNa5TRcQLb7mCiMszilAe7QVXkqZ0qNZVKSuwQkWYFLeHdKylqbMOPlT383YKeHcSyCExChsFbxxvcipenZxX92QVX2WjcloSG+eDTtAyevyCZAZiZHkIX/CNF6JcmD0Kc+d4E3/N8kfAzmFu7tmN+O7QxaCL506MlgO6S4su57po2lbeaFCEszUCqGvr3xdYShxnyRByfxb8NPFHzhtC68GO9ODTItbWlvcskozIAI4AaIXMItfIHFiZT0N/360tSA91shofBPyn0os4getrxckKD15RG/q+cCszvocGaD/wu2oJNIu8ObclqnwnJOtEmshu8hxH+ceLDlmJvmTN/5t8MH6KESHkcnU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 04, 2025 at 04:46:21PM +0900, Rakie Kim wrote: > The weighted interleave policy distributes page allocations across multiple > NUMA nodes based on their performance weight, thereby improving memory > bandwidth utilization. The weight values for each node are configured > through sysfs. > > Previously, sysfs entries for configuring weighted interleave were created > for all possible nodes (N_POSSIBLE) at initialization, including nodes that > might not have memory. However, not all nodes in N_POSSIBLE are usable at > runtime, as some may remain memoryless or offline. > This led to sysfs entries being created for unusable nodes, causing > potential misconfiguration issues. > > To address this issue, this patch modifies the sysfs creation logic to: > 1) Limit sysfs entries to nodes that are online and have memory, avoiding > the creation of sysfs entries for nodes that cannot be used. > 2) Support memory hotplug by dynamically adding and removing sysfs entries > based on whether a node transitions into or out of the N_MEMORY state. > > Additionally, the patch ensures that sysfs attributes are properly managed > when nodes go offline, preventing stale or redundant entries from persisting > in the system. > > By making these changes, the weighted interleave policy now manages its > sysfs entries more efficiently, ensuring that only relevant nodes are > considered for interleaving, and dynamically adapting to memory hotplug > events. > > Signed-off-by: Rakie Kim > Signed-off-by: Honggyu Kim > Signed-off-by: Yunjeong Mun For the memory-hotplug bits: Reviewed-by: Oscar Salvador