From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9FBEC28B20 for ; Wed, 2 Apr 2025 12:46:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41902280003; Wed, 2 Apr 2025 08:46:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C86D280001; Wed, 2 Apr 2025 08:46:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B7DC280003; Wed, 2 Apr 2025 08:46:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0D353280001 for ; Wed, 2 Apr 2025 08:46:50 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 43D2CC1905 for ; Wed, 2 Apr 2025 12:46:50 +0000 (UTC) X-FDA: 83289078180.26.0AB87A3 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id 899BB140008 for ; Wed, 2 Apr 2025 12:46:48 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aUgtls2H; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743598008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=49Qvi05Zf+3SgolskD4QfMI62h0RprmZKn6FasC4Et4=; b=vM8+uHp1S1Mh0FZf3fbYUGn3kp+TDclybUz+PoPfiHVd+xWMyNG9dqUWQ1A4T5GA/Ztz36 n6EjI7bex+5isVdx8CXgtAV3PVO6vgz0s0zTsL1NNaEo5g1Kd9ngllpHdvP6UeCByw6mzY cAU+4TkOu+LoIfKTWPmwT1rrWQGF+xg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743598008; a=rsa-sha256; cv=none; b=UhvHU4HRLwCgUsG46ZIIX8r41yMlyH5GMwI69xUHzEoTzgWibysIGaigS+FZndD0dj6iIE iFm/X1FPnM6RDls6AcYjaEZv4gRLghbpM6CC1KUDvMflBDZrVuf2yf6UsVrbLtU9rwNdUx 58QslAG0P9l2ZBFB+2fUmzlhZFMc6kI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aUgtls2H; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id CF2CCA44535; Wed, 2 Apr 2025 12:41:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10F69C4CEDD; Wed, 2 Apr 2025 12:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743598007; bh=fuDw+v9E63a/aSleIffar11221krG7wOgWHTJ1Q3/68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aUgtls2HhODVEH5+qLIKQLomvMF7ELxBw2MKKL+6p9VihJy6d4ilR7aZw4VM6bG22 zDUpLBwkinARXAebf2dC5uy5D27Sf/uK9zqZ+B49O6LNTG0nTIxRRy+6zHt6uiHuw7 5boShg/yXA5K3U142BUMUiz436tWHj7ha92cEpTGGgLBqz/uaRfxU/SobFsCzamk+8 MRnsgcyxYuQPHtOHzvmlrpD/jnUXZMC+dmrLYm6NsqGgAmSGJcY2+AWKZYdyihL0Pw MkhiMnL7XaCGdAeekj/PX+fUOfk5PZyZhgr3fkpy2FJwN+zM/a5KhPh4b6M1nvbjWq /VGfAQG+QNTyA== Date: Wed, 2 Apr 2025 15:46:37 +0300 From: Mike Rapoport To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Andrew Morton , Dave Hansen , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , "David S. Miller" , Geert Uytterhoeven , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, Naresh Kamboju , lkft-triage@lists.linaro.org, Linux Regressions Subject: Re: [PATCH v2 10/13] arch, mm: set high_memory in free_area_init() Message-ID: References: <20250313135003.836600-1-rppt@kernel.org> <20250313135003.836600-11-rppt@kernel.org> <20250402140521-bf9b3743-094e-4097-a189-10cdf1db9255@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250402140521-bf9b3743-094e-4097-a189-10cdf1db9255@linutronix.de> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 899BB140008 X-Stat-Signature: remmobeh9cncrz163hj369c46nnquees X-HE-Tag: 1743598008-124440 X-HE-Meta: U2FsdGVkX18xVBEYp4ZqLODJ3YImlIXCg3E6LO+4JcRjG7Tu79JBpT7aBVcI6akY+QNFB4lIChPnF8jeAy5YZE0YEx3s6DncD+uJlpz/WQ77rIebkRtD7Y6Rnsk+DEwqpvJ/HDn3wpWI6uVEDdczGGj83l2Zb/zMeTlxBLkKACwdcRX4H/aFkKuudVPbG52VNQZpgm0Wcuoyd7sWZkYPKOXk4ieOYcgfVBIqTkUq7jgW3sU+A7v0elQHw+0ffOPYFwnEP/NuQA/Vy/4GSKxvSJKZRclSoTrdX25UsB9CpFYbOi9JSHqvETXXJVNHQ3NlgfBf4rccVez0EKkrPawGo61RPzo59Wh5G3s3PKEW+97T/WmqiaH0M/EfNTNjhY2ImOvqULVzqZSwasR3xwyzYEpnEnbKEVsU/6SYE6f3wIirKcmXhLmQb+L2HqFL+tWbGWVG1YlBihtK5OKM2G3uGJoqRrhbCfGpqfgQ7/QCBYuxlM0FXI1Tukd98Ynx05qjiI7REDCjYZp6x5HQ2ASKy3tZGYtC8VPQiByzCgjJKIcNCVCigSfxaSt+xD1wfFcvDLCpLc7e6F5FtwRk71Pg1uooFq98FG69ZvnKUkFen3X9km3Utrtt1SisVab+eYgXcEnTZO0txGdc47EnHI12VXYdL4Bz+MY4y36Dixc9bfMIzwIEUkke6cotpBYN59gDo8Rdklbw93l2MJJyi+txmx7kyvhW6DPaOHNaowOkCStmo/Swhtn8n2fn5o+aJNB3SIgWbTgWF6YPnX/CeHwDPWQIFDGcL7O4HqLQ4ig9tJjmVqzyjQH4+gYX2QEXxKWdeGLNYHhBqhHlAzbCMjyNOXwC3pedfF+a5+Go9WTsuyKpy26AKR8V9Ooux0P/1vtHQxMCF8YcCn5U7+Vbtcgu3kz++3y65zFTyXsLClAN1qIJv3kWjVwzLtZVf5oSPKo7n3u5WANzNlqR3MzJa3J +PQuQ6TV 0aZBR9lebL6gNYN8KXnNOlxFSifBzVfO97rkTO8CZ0SLR9Ug8+HovL0oy2pVWRQlD5O+xccbDz6tj2ZFyymqYA59e3C5GrNfHa0QYuVibyAxo4VQKe1Pp+8qtHU371N2IPYNAlJ5xuI/yrn2nC54FEOMDQkL4Zyba23mmhFhTQ4enylEUxHo3ZySp5y63AQHN0v6jTmJ8rvP2/fsZL8/aHqXNq1zNxfjn7UyehXMh8HU9+rFYgHeeC/tC2cMjzfORap9A8ToRE/BAUNsrxMlZGvKNgT/Aiy0MOXPoiu9VdOP3X4KTDYeXMY2O87m3Yohb6Bm9AXwOuzGky11+P7b9O4PcKI/u3NGaxq/YuyGl28jT59s2oTmO+tTQOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 02:19:01PM +0200, Thomas Weißschuh wrote: > (drop all the non-x86 and non-mm recipients) > > Hi, > > On Thu, Mar 13, 2025 at 03:50:00PM +0200, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" > > > > high_memory defines upper bound on the directly mapped memory. > > This bound is defined by the beginning of ZONE_HIGHMEM when a system has > > high memory and by the end of memory otherwise. > > > > All this is known to generic memory management initialization code that > > can set high_memory while initializing core mm structures. > > > > Add a generic calculation of high_memory to free_area_init() and remove > > per-architecture calculation except for the architectures that set and > > use high_memory earlier than that. > > This change (in mainline as commit e120d1bc12da ("arch, mm: set high_memory in free_area_init()") > breaks booting i386 on QEMU for me (and others [0]). > The boot just hangs without output. > > It's easily reproducible with kunit: > ./tools/testing/kunit/kunit.py run --arch i386 > > See below for the specific problematic hunk. > > [0] https://lore.kernel.org/lkml/CA+G9fYtdXHVuirs3v6at3UoKNH5keuq0tpcvpz0tJFT4toLG4g@mail.gmail.com/ > > > > diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c > > index 6d2f8cb9451e..801b659ead0c 100644 > > --- a/arch/x86/mm/init_32.c > > +++ b/arch/x86/mm/init_32.c > > @@ -643,9 +643,6 @@ void __init initmem_init(void) > > highstart_pfn = max_low_pfn; > > printk(KERN_NOTICE "%ldMB HIGHMEM available.\n", > > pages_to_mb(highend_pfn - highstart_pfn)); > > - high_memory = (void *) __va(highstart_pfn * PAGE_SIZE - 1) + 1; > > -#else > > - high_memory = (void *) __va(max_low_pfn * PAGE_SIZE - 1) + 1; > > #endif > > Reverting this hunk fixes the issue for me. This is already done by d893aca973c3 ("x86/mm: restore early initialization of high_memory for 32-bits"). > > memblock_set_node(0, PHYS_ADDR_MAX, &memblock.memory, 0); -- Sincerely yours, Mike.