Re: [PATCH 0/2] Implement numa node notifier

Oscar Salvador
2025-04-02T17:03:24Z

On Wed, Apr 02, 2025 at 06:06:51PM +0200, Vlastimil Babka wrote:
> What if we had two chains:
>
> register_node_notifier()
> register_node_normal_notifier()
>
> I think they could have shared the state #defines and struct node_notify
> would have just one nid and be always >= 0.
>
> Or would it add too much extra boilerplate and only slab cares?

We could indeed go on that direction to try to decouple
status_change_nid from status_change_nid_normal.

Although as you said, slub is the only user of status_change_nid_normal
for the time beign, so I am not sure of adding a second chain for only
one user.

Might look cleaner though, and the advantatge is that slub would not get
notified for nodes adquiring only ZONE_MOVABLE.

Let us see what David thinks about it.

thanks for the suggestion ;-)

--
Oscar Salvador
SUSE Labs