From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88188C3600C for ; Thu, 3 Apr 2025 03:46:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48761280003; Wed, 2 Apr 2025 23:46:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40ED5280001; Wed, 2 Apr 2025 23:46:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AEF6280003; Wed, 2 Apr 2025 23:46:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0B034280001 for ; Wed, 2 Apr 2025 23:46:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C3170121334 for ; Thu, 3 Apr 2025 03:46:40 +0000 (UTC) X-FDA: 83291345760.02.44BE976 Received: from submarine.notk.org (submarine.notk.org [62.210.214.84]) by imf08.hostedemail.com (Postfix) with ESMTP id B351F160003 for ; Thu, 3 Apr 2025 03:46:38 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=codewreck.org header.s=2 header.b=0HBoscdF; spf=pass (imf08.hostedemail.com: domain of asmadeus@codewreck.org designates 62.210.214.84 as permitted sender) smtp.mailfrom=asmadeus@codewreck.org; dmarc=pass (policy=none) header.from=codewreck.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743651999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ITcMLIFP5tKAjz41ehoKWCF5eQQiDYMOb1fN5yVdzj8=; b=XvKfUJfKEwlWplceRWg94J9T0Dn7/+vLOl5MPZlRyqe6wDMhZTchXjvK62evhCBtSI0qbG E8uZ/j6+7fya+2pfgYEaxDabcwVR70jNOw2u8p8MB/YClWJ8ZYWmedDvfunKUi5dAES7u5 L9MeuSB2CCiTokzAoT04rAR87DWvzlg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=codewreck.org header.s=2 header.b=0HBoscdF; spf=pass (imf08.hostedemail.com: domain of asmadeus@codewreck.org designates 62.210.214.84 as permitted sender) smtp.mailfrom=asmadeus@codewreck.org; dmarc=pass (policy=none) header.from=codewreck.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743651999; a=rsa-sha256; cv=none; b=I3Jid6a7xTfa4AFFbutq1jWTJ1rfP7C3PzwlTYPMPVXeugMOHpp87lYfPTwn9+NR42vILd eDTjVc0UalLYPGbm2HsOSH7xk94glTKzjnh2CHAM1udjiqD5MOXP2J1Vx8yRmMqgZkrr0T NRveLim2XpX7SsWX8B15UnFcBYLyMQY= Received: from gaia.codewreck.org (localhost [127.0.0.1]) by submarine.notk.org (Postfix) with ESMTPS id 67B0E14C2DB; Thu, 3 Apr 2025 05:46:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codewreck.org; s=2; t=1743651996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ITcMLIFP5tKAjz41ehoKWCF5eQQiDYMOb1fN5yVdzj8=; b=0HBoscdFpgxuQgZl92opSENbMA9Pk+zXKbOYbpRJnb2fOIuhEQ1bwZ5rGPvmlYb+8wVHw8 wHc2273ChihnbkPMTZ1/DAooFHD2hJ+0yffsGhHC9Cy9veCKiE8j7cW1KdfmCPrBKGxCoy Qn3m8QJ0MYx70hWGhV57dz2ZTADFzPnA6CZqQO0W6iJCwIBiDSjDSOwrvW/d4+WTVhVAcH g6HcnkJSY+HEZzS8B0uR8bH0QBVA+A0ZU2VyhxlEvsqXe3FXAMaHh6g4yHfkceyrco8IVL 7ipXZTHnksTxDqR7U3ceJDpBoPzzk84gVw3dN7X3aD3CMOZtc1b/HQqenuVM/Q== Received: from localhost (gaia.codewreck.org [local]) by gaia.codewreck.org (OpenSMTPD) with ESMTPA id 72519fa4; Thu, 3 Apr 2025 03:46:32 +0000 (UTC) Date: Thu, 3 Apr 2025 12:46:17 +0900 From: Dominique Martinet To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org, stable@vger.kernel.org, David Howells , v9fs@lists.linux.dev Subject: Re: [PATCH v2 1/9] 9p: Add a migrate_folio method Message-ID: References: <20250402150005.2309458-1-willy@infradead.org> <20250402150005.2309458-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250402150005.2309458-2-willy@infradead.org> X-Rspamd-Queue-Id: B351F160003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: p7obi15wwy99h3d8ei9me187787hgkfw X-HE-Tag: 1743651998-381695 X-HE-Meta: U2FsdGVkX197CdoIVIwHjqCikGTQi836u+cM1tKlQ8jSCuSs+fbzZsLgckh6bR38prd4efxTBYahrwxctUe9EK10T1wC8u4ljx0EfIBR2tR42th2wlJj7aboaa/nO6sfL/ToRxk7V6NfbOO1OPvIYlubhyg98KC3AwwLr0O7FyvYIROxAX2JiaNYYCs+7Y3JB4Y229mbHRb0KLlVGEJi7PdvQAcWJcbV0YNWmHauyiS3Io3V0nOVvq5sIQETvqnVIvtMrptB8Fs7nMRjF+yTxwQmns+v5vH7GoJC4xrmDW3/UMNa6pzs4gUg6EDGpxLny24GEnx86xqm11nKwum+CcNRs/lH5l7VqSt3cMq7H1sf5qjvB5nb3ULCrGh3D1hCDcBYW9oF8f2Neqjs3SIRQjSan9JK6MoXS1OlwUddnwhIz5hPkomUuSSbZFGZJVO3dKDkjS4clqE0jAXHKCVLFSHqmbtCN1NomCDvlVYRsFLtdLA8RICpnl0jQS6jRuVeQB09Cwe8Izq3gBZQRzY91mLf5P/F44iv2JyVxnfqwzbJMHfNsfsb93sj5aFjECWLO0x5LhOX/ko6P75jZZvt7L5l/Bzj1LVf+HbDzNMzbzyPATPtLyDU8rUlGwRp79mFe2CiiSLfCsHymeBmCwPX7u+rl/YN5Bi6X6xbXO+iSFaQ/aCWx0SdhsmV5P6zvz3odzEWiK5/5KVERQRRanCBZkjv7XFuI0fB3H/CkpAfsttvbvmNnQuUozQZTGPGtznZON6DeyUMjkqItvKa1LbMS1haKS3vUhpApb8e5DF0Fo7IQ3SNLDNcxpdxTA/P9XppXg/31csorICBPj/aif5Dnc4a+f+WWEqiiPgrPQU0B3DRxoX8NOGQIWV87DXC95MPt6qd+vfjkO7xGXWSTMujmkA3HQcUw6aJRKuGSlMlWPz0stIhSi7BbVeC/oDR7bAaB9VdFz2VT0EQIDNXzDH umiw5BcG kIgWFJtl/8xRUjnv/Cjv+hywXw6k1fxroCc/M+qxa1ouBx97t0/BA5YAeLdq+uDTSQHD4FcPlREwntkJBhj3f6D91cO2HkpVYNvKFL2ZPFoacK8xtPq3DHiMDPmhf78WrYKGObynoe0SXOaHkhKK9vlWjt0NWadSVA11XlzLTfFCSZ1YBiauviYnGgcuTKnXQoMpl5LfkEStVLjcvn31GD1dmPLv0JDxct30jDqZc6IJGGUKQ8LoaDxhI9GxsgBqs/f1ZfrwzPVTbnW+rZng6X2fPH+821HQyhyTWnuqtP9woWrrdtYNQ5hD07lrdLe1txnGqrgXCUPJfNNne6s0zJQvnDhnFCcfl4uxZsBPSvVeXVeBNnQi32f0567RYVL3pRTwqh142q1ZfNK4oKmkT9fhAviH8Q6hrO2RgcDRN5b3qP521gynCxySBC5Guqd7N+b9GJg08eP64TexfbnW+vG/pnCZmUEBqT9oz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Matthew Wilcox (Oracle) wrote on Wed, Apr 02, 2025 at 03:59:55PM +0100: > The migration code used to be able to migrate dirty 9p folios by writing > them back using writepage. When the writepage method was removed, > we neglected to add a migrate_folio method, which means that dirty 9p > folios have been unmovable ever since. This reduced our success at > defragmenting memory on machines which use 9p heavily. > > Fixes: 80105ed2fd27 (9p: Use netfslib read/write_iter) > Cc: stable@vger.kernel.org > Cc: David Howells > Cc: v9fs@lists.linux.dev > Signed-off-by: Matthew Wilcox (Oracle) Given I'm not in Cc of the whole series I'm lacking context but I assume that means I'm not supposed to take this in. I won't pretend I understand folios anyway, but commit messages makes sense to me: Acked-by: Dominique Martinet Thanks, -- Dominique Martinet | Asmadeus