From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 964F0C3600C for ; Thu, 3 Apr 2025 06:19:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6C53280004; Thu, 3 Apr 2025 02:19:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1BFA280001; Thu, 3 Apr 2025 02:19:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0A15280004; Thu, 3 Apr 2025 02:19:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 76E37280001 for ; Thu, 3 Apr 2025 02:19:53 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 26C15593A9 for ; Thu, 3 Apr 2025 06:19:54 +0000 (UTC) X-FDA: 83291731908.29.9F4BAB7 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf04.hostedemail.com (Postfix) with ESMTP id 9237C40005 for ; Thu, 3 Apr 2025 06:19:52 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Kekjkokw; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743661192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fOevX9dVP8B9x142UUWyFx0mzsmVnRTWNRfDMowzrP0=; b=njYXxTGvSWhlWwFlMlQrCrnFq/BoRX3Npc4TN84HMJ3TUXBoAcPHULRmA0hly0t0OtInTX UHVRiHZVC6ycAin9WF8cC9isjBQDodylJjqtL7R2z54NByCgzF5lOGoYGoMKbW3SF7P+JZ ZlGdJJX4ODg8jL0GMjpciCMec54rYb4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743661192; a=rsa-sha256; cv=none; b=dn98ZRKvHCSbdVxV0+FFSk+hVyA6k731xrZYA6lvuU5NytMBfDfKarcDqKLzEhCz2KisXw wzgfcYulNQAe0KYAFAhWzcRUVk1J6otgQYRr2qz64K2mdItKLmY/WacXEEt3dmHFaWfbtz z7FUX0pP1xv24BYFyhoU+ryqZ587saI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Kekjkokw; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id F3F2EA462BA; Thu, 3 Apr 2025 06:14:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9218C4CEE3; Thu, 3 Apr 2025 06:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743661191; bh=IVd8UGsu5sV0jxUV5ZTr4vtRlKqOWafEpnx5MIWbO3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KekjkokwWTfjRow/NzSJ1BwYsusDXfqJsoeMmHiG480Y8LjGYy2xbtX61/d+jYFo0 ya8vgFt32OgC+FwXz9kFye9oILceBeNwoQiIH9SOoCg4yPYbatDWUx6LFTZMhESzQs ZHBz3gh2NEK4nQtkmNnkc7F0kWbEitreUEVRM4N7L9ymOjafn5ulUJapDMUA+8D+Hx tVXkc+RI5kyYKqnaNMJaJuGymZdNG3IvvFSodU7r8gaFI2pzZMlRUA5rgwcRAlxcE0 rc2OyW+HMEHtqx3e2bl7ZRB7uAly4C1XcI76oeqveJO3pTpwR1SHWqxMOcGpMNeTuZ OwZvspfkAEtZg== Date: Thu, 3 Apr 2025 09:19:43 +0300 From: Mike Rapoport To: David Woodhouse Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 2/3] mm: Implement for_each_valid_pfn() for CONFIG_FLATMEM Message-ID: References: <20250402201841.3245371-1-dwmw2@infradead.org> <20250402201841.3245371-2-dwmw2@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250402201841.3245371-2-dwmw2@infradead.org> X-Stat-Signature: 1cp8j4acn7waxk716a8ito3i7c443nsw X-Rspam-User: X-Rspamd-Queue-Id: 9237C40005 X-Rspamd-Server: rspam08 X-HE-Tag: 1743661192-812106 X-HE-Meta: U2FsdGVkX1++awnzGfRnDsVjvAM2xXsSE11ooooolvLmG5MPZ9D8bFOfFywi+qr3cHMqKtm5HLstknxQ5qDdIrZzIZnF7OPDmsPcEPG7SDQOEfP7aOlz4tEP7Vmgx+0uKydw0dGdLz2PweGTmsjoqJxnSUbnhVmQheV5iy9sVuUtBkxoGfLjkLC0WhYRo6h76dvAeAfU+IdCgyd3XFJKLv62mmb2Sq6VRiqYP9Wb08gdZEYDOzbCZR1Qy0pukTbAEVQ8T6GcsWpWlQuTrmSw39Rb6YHmT7RvW2qCKHDBxuydezOLyhYf9j/650pCOXB4xQ/U3oletsaELmeMyj6BfE9YS3VBVzyir2GfTrfCnhGavfVTvYTeToRO0NadhKVja2hFeM6CjLUdh471ZKVlI12J607G/rYI9rNO5CrVrB58ZlQrUs3mIE7qp+aThnrIDyKtPwJnvBs3D8ABdtsHLWg6NyiuzQWyZSjeXlTLUfqmnqPYeFFpW+bN2fyq3QJvuFwCDvYRURGIiHQR3tLrnkJddk2cnaaIHRzBPDJivqUQJnRGYLbCbKjUiDJQMOp+pT8QXNQJVTmQIctRm3KkR4eG8f6/pS0kMyB7PLL8aHtlZI4ApsMm5kBfP2xaElGbjW0S9DLQAcaSG5GIUsUEw7GdyKvUQh1OGt8Fig2og1//u6Hd6H8huKQPw9NlcdorzIGdTMmdwlYjIw/bPQoGr4fLMX69OOVASJ7d1F1+5KrSFqXekKTZIcwLVQUp6Qc7FuHCPfqYSe98OgjFalwQOTSgKuIU+jC/qAIS2avxigXm40H53JNpGkgApmjKgrC5CIExcIZzTKANkfSxyUh3virdt+6nQzSKQdY49NZVCgEAE2GrI+/Ejj7tVJt6rDkKsV0cXfyp6UOCOw8DQuDslR98taiPSc0uk5VFZROYCKJOKxqehpy2YOC6lLS+7BODSPpnmMxm5uXdCEN4ggn VQvQWeLH 6GF0BLoeT/MXG3BA8B/cmKMBa+2eePHvm70ANxqGaYyWbT2MEjiGHMvhT10cQWrbTHWGvjf/3lj8nxKPFMty8hV/QypgSseGYnVHzASZ86lsecPJeALl8SQ2Xe0Qv28lwSlNdMIzZfjhFoHmZr0sIFTPzertjhYl8trqQwXum9SIOgJAJJsV/+PYjd+JRLZgOqURyQ2V2UEz1GP1gRW4bNtQbAcPn3310oQgKkC4dy5VNv2W7dznsm7Ru3WiygeebY6r2Gn7BFAVOXo0mIAZtEyuZ8w/3AyV7CLS4BRCjvvaNpIiv2aqbPO7O6W48pEJUSI34GRp/c3PvCkhFRh++8Vx5hK5SjvXGhmDM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 09:18:40PM +0100, David Woodhouse wrote: > From: David Woodhouse > > In the FLATMEM case, the default pfn_valid() just checks that the PFN is > within the range [ ARCH_PFN_OFFSET .. ARCH_PFN_OFFSET + max_mapnr ). > > The for_each_valid_pfn() function can therefore be a simple for() loop > using those as min/max respectively. > > Signed-off-by: David Woodhouse Reviewed-by: Mike Rapoport (Microsoft) > --- > include/asm-generic/memory_model.h | 26 +++++++++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/include/asm-generic/memory_model.h b/include/asm-generic/memory_model.h > index a3b5029aebbd..4fe7dd3bc09c 100644 > --- a/include/asm-generic/memory_model.h > +++ b/include/asm-generic/memory_model.h > @@ -30,7 +30,31 @@ static inline int pfn_valid(unsigned long pfn) > return pfn >= pfn_offset && (pfn - pfn_offset) < max_mapnr; > } > #define pfn_valid pfn_valid > -#endif > + > +static inline bool first_valid_pfn(unsigned long *pfn) > +{ > + /* avoid include hell */ > + extern unsigned long max_mapnr; > + unsigned long pfn_offset = ARCH_PFN_OFFSET; > + > + if (*pfn < pfn_offset) { > + *pfn = pfn_offset; > + return true; > + } > + > + if ((*pfn - pfn_offset) < max_mapnr) > + return true; > + > + return false; > +} > + > +#ifndef for_each_valid_pfn > +#define for_each_valid_pfn(pfn, start_pfn, end_pfn) \ > + for (pfn = max_t(unsigned long start_pfn, ARCH_PFN_OFFSET); \ > + pfn < min_t(unsigned long, end_pfn, ARCH_PFN_OFFSET + max_mapnr); \ > + pfn++) > +#endif /* for_each_valid_pfn */ > +#endif /* valid_pfn */ > > #elif defined(CONFIG_SPARSEMEM_VMEMMAP) > > -- > 2.49.0 > -- Sincerely yours, Mike.