From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85CD4C3601A for ; Thu, 3 Apr 2025 14:25:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57DB8280004; Thu, 3 Apr 2025 10:25:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52E23280001; Thu, 3 Apr 2025 10:25:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F6BC280004; Thu, 3 Apr 2025 10:25:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 20FB2280001 for ; Thu, 3 Apr 2025 10:25:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 87EE61CACBF for ; Thu, 3 Apr 2025 14:25:17 +0000 (UTC) X-FDA: 83292955074.17.776EBD1 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf27.hostedemail.com (Postfix) with ESMTP id E156A40010 for ; Thu, 3 Apr 2025 14:25:15 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ka40iZjP; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743690315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M5hjQBOOXSibuiDnMLaol/6Mg3J87NueN56dAc55I0E=; b=JD370BF4RRFwdQQrRJJnWGr68BOPx0EUdaNgiW/C5mkaASsE2E79Od7wt50hfYbRWoQQ9d 95BqRD2t+PYLuUTWaiu0yiI0GceVs43/UYiJatqtoOsoz3dF6XpYcFbvDhfSI2VLICcqaT ISKvxn6D9mD6Y156WsoKmh1S5ddD5i8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743690315; a=rsa-sha256; cv=none; b=utXmHb9CG3dCPO1lWGtG1H62+jZ7m2mEsUdlWmPtZw33GUGznf9vxDSAhUIJUbjBxeOKYh 1u3y4c07pVq6kNklwvt9mgNwIG0HumQL3rBE9QvLqMaHuehYKTYvgG2oiox7Z/08QEE6Pt 8EjunnUpKVdn6WQdFHG7oKE2DHhqT9c= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ka40iZjP; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 5F95268431; Thu, 3 Apr 2025 14:25:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 908ADC4CEE3; Thu, 3 Apr 2025 14:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743690315; bh=tkMdYu9t5824/EU4dyTb0cxwDhM/gxde1CbSplGldzM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ka40iZjPw89KP7aEPQCTzPyRorfgRmK7zTLjMQrT4UuOS8V2Bbk/H20fNhAlXnUvt mOAyIGNrj/h0x0BxRGyLZ3CLoNKMQ4UKu2PcRBnC98hblDubLwHjV5NTv/ZiQ2xggF bydhXqc2xYMsTTG5PBELGVSAomByAJbFYT1KsFupzIsBPw0MJ8YybS0T2xAOb2uYwU LHnoy8zABqx9FxwcvkcCzb+aWKu4BWGaQuzCpzq3Z2lG5GToYbBTt41AAD8bOZfF50 Xjg49Bl0RfFtF77JKdgvgirBQlNJL/qgQFCxudletSKhQ+MJ76sO5fJBVD2pnuUgf1 SGTkEH3ZqJ1fg== Date: Thu, 3 Apr 2025 17:25:06 +0300 From: Mike Rapoport To: David Woodhouse Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 3/3] mm: Implement for_each_valid_pfn() for CONFIG_SPARSEMEM Message-ID: References: <20250402201841.3245371-1-dwmw2@infradead.org> <20250402201841.3245371-3-dwmw2@infradead.org> <380d9bff359150f67ca6e0468f99ee746c1abdea.camel@infradead.org> <0d89238f3ad9444abfc905a79ff14388a61cf00d.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0d89238f3ad9444abfc905a79ff14388a61cf00d.camel@infradead.org> X-Stat-Signature: usicmisfdus4fbwpmxnxwmb14bndqy78 X-Rspam-User: X-Rspamd-Queue-Id: E156A40010 X-Rspamd-Server: rspam08 X-HE-Tag: 1743690315-184732 X-HE-Meta: U2FsdGVkX1/7vdWlSHQYWF0I+4LBWjiesUbe00sLtQ9FS41BBNjnYWu6csdn1j86kZ2wjdCxTpwDE3W1q8hVv8wiQ8VJPsMJqUxx449i6ZU0jcqeMB4lKVEeye1UttOS+leyauxt9CjAFFAGoVrv0kAYC8sr5GzJ9chlODBUV8Ve/pz5F6vhNG4izoMCZR+AbxVM9Fw4KnpWVJDJVnB1s61Hj401xacsyXw2sopa0VJm88xEvbmxFuX6rdZ0VG4AlsPFe7dMXBZrWlTL0SyfWNTOcLJbtoZWA60cOA65rb5Up6A1RVC5QA/T1hS9OiCJt5SktHjkeKndBSxIcBOFOK3vBRG9bfJ4x730DFky+RfafLSFayGGWVfgKe1MbD2Q3dTRgC5ZENtyJZX2/g+/t1uD069ZygVgSmL8CbeEbKWs+xsXMqXrcuf9FvrQ+uj7D9x+FxQwslAE2zvgeQFpQacF6BcGEsVLsGbiXqSFfYo5SnNYXUkDSHdD+wQ8+FQdT+ko2jZRkIfxJTBOuJCzGuYimI7Pynmuex82XsKD8JlMQXznqPR8PI/ahHyZ88kikWSbdEG0U5iI2dbXCCxejR1e1yzQENrkYRgCd0uvh7f/U2XNDr5ojh/eD2vBtDGx9iH9gSIkAMRNAfuHwtDTnbH6SHJkgjPQk6ZxrJoJ38PvjY4XsetZCMsgWXuGZRogDwUxLz5ZADi00FJ6xEqELmackNrG/y2wiF1Zd5+jbZX7BY6QmLiAbzK/soy+8xUc4c2C+i2AAtXyiCf0peHNa4d1Vi6xz5rwMCr/Lz706OwOz5qCSGFTFOh357m97ZB382HkPakH/Zicg+g2Hsmb/8gW4tiTd/CTd7VwPkEskTOrDQlBCqYtFXBrirqp/tQZyCTo9Cps5oioZJbZlHi6P+tcpTB1aeAiREzraK+/gnqbROf46gBS1PtU6/LDIV0l/cvZma2QPotQ6Y5SHOM rac2dLys 2nlNT6CCu7PbxvqUsIGbXgKic0cEP3mKu+Omu93wUKbevH6Kao63eLRKb331BC4YEWzX2DgdoFkbu4gu905FrUsJGG4rFB2OQMiYr1NYNxak7f6YdHk6/E2Va48QD/i8eAYwvsAX2VP9z4V+dhqJb9+7BC3NEtebMBCCmOAVJFtqX5pUAzhPrGjJSUOGyJmrbIP+I45aX+famOhtg7BpSACv2vhdH+rIo+dh+qThN+wMGLdY4SPNFz/P26CWDxVWh6qaoY5qGCBlb4gy+rV30KXNaDvg+khA0yRIvdW8XHpe4fWlcUM5kdy36MubqWVBt/U6PTZNe9XnGX2SeWZE3osr+QjJDM7lEz9qutN19MEtCGgae5cGJZXT+pDFH5w16BK7P X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 03, 2025 at 03:17:44PM +0100, David Woodhouse wrote: > On Thu, 2025-04-03 at 17:13 +0300, Mike Rapoport wrote: > >   > > > static inline bool first_valid_pfn(unsigned long *p_pfn) > > > { > > >   unsigned long pfn = *p_pfn; > > >   unsigned long nr = pfn_to_section_nr(pfn); > > >   struct mem_section *ms; > > > > > >   rcu_read_lock_sched(); > > > > > >   while (nr <= __highest_present_section_nr) { > > >   ms = __pfn_to_section(pfn); > > > > Maybe move the declaration here: > > > >   struct mem_section *ms = __pfn_to_section(pfn); > > Ack. > > https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/for_each_valid_pfn Fine with me, keep the RB tag :) -- Sincerely yours, Mike.